From cd53e9c8f708ea3b20d8a7798587d1679f4c5bea Mon Sep 17 00:00:00 2001
From: thePR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
Date: Sat, 21 Jun 2025 19:56:08 -0400
Subject: [PATCH] Fix OnionShare flags

---
 README.md               | 4 +++-
 docs/troubleshooting.md | 5 +++--
 voxvera/cli.py          | 3 +--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index 53c6004..de6ad35 100644
--- a/README.md
+++ b/README.md
@@ -112,7 +112,9 @@ After installing either way, set the ports used by Tor:
 export TOR_SOCKS_PORT=9050
 export TOR_CONTROL_PORT=9051
 ```
-Run `voxvera check` to confirm the binaries are detected before launching.
+These variables let OnionShare connect to the already running Tor using its
+`--use-running-tor` option. Run `voxvera check` to confirm the binaries are
+detected before launching.
 
 ---
 
diff --git a/docs/troubleshooting.md b/docs/troubleshooting.md
index 6a3754a..f27e9f6 100644
--- a/docs/troubleshooting.md
+++ b/docs/troubleshooting.md
@@ -11,8 +11,9 @@ This page collects common issues encountered when hosting or accessing flyers.
 The files in `voxvera/resources/tor/*` are not real executables. Install `tor`
 and `obfs4proxy` yourself (e.g. `apt install tor obfs4proxy`) then set
 `TOR_SOCKS_PORT` and `TOR_CONTROL_PORT` before running `voxvera serve` or the
-Electron GUI. Running `scripts/download_tor.sh` can also populate the missing
-files automatically.
+Electron GUI. OnionShare uses these values with its `--use-running-tor`
+argument. Running `scripts/download_tor.sh` can also populate the missing files
+automatically.
 
 ## Firewall rules
 - If `voxvera serve` fails to start OnionShare, verify that outbound connections on ports 9001 and 80 are permitted.
diff --git a/voxvera/cli.py b/voxvera/cli.py
index 2d0626a..fbc002d 100644
--- a/voxvera/cli.py
+++ b/voxvera/cli.py
@@ -348,8 +348,7 @@ def serve(config_path: str):
     cmd = [
         'onionshare-cli', '--website', '--public',
         '--persistent', str(dir_path / '.onionshare-session'),
-        '--external-tor-socks-port', socks,
-        '--external-tor-control-port', ctl,
+        '--use-running-tor',
         str(dir_path)
     ]
     proc = subprocess.Popen(cmd,