From 314cf01ac1473d8759cdb3c94bfe066ac4f31ec6 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 7 Feb 2026 21:45:47 +0000 Subject: [PATCH] chore: remove unused NIP-46 constants exports Removed `export` from `NIP46_SESSION_STORAGE_KEY`, `NIP46_PUBLISH_TIMEOUT_MS`, `NIP46_RESPONSE_TIMEOUT_MS`, `NIP46_SIGN_EVENT_TIMEOUT_MS`, and `NIP46_MAX_RETRIES` in `js/nostr/nip46Client.js` as they are only used internally. Updated `js/nostr/client.js` to remove unused imports of these constants. Verified that `NIP46_HANDSHAKE_TIMEOUT_MS` and `NIP46_AUTH_CHALLENGE_MAX_ATTEMPTS` are used in `js/nostr/client.js` and thus remain exported. Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> --- js/nostr/client.js | 5 ----- js/nostr/nip46Client.js | 10 +++++----- package-lock.json | 3 +++ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/js/nostr/client.js b/js/nostr/client.js index 6dc72632..e3a4ce26 100644 --- a/js/nostr/client.js +++ b/js/nostr/client.js @@ -160,11 +160,6 @@ import { import { HEX64_REGEX, NIP46_RPC_KIND, - NIP46_SESSION_STORAGE_KEY, - NIP46_PUBLISH_TIMEOUT_MS, - NIP46_RESPONSE_TIMEOUT_MS, - NIP46_SIGN_EVENT_TIMEOUT_MS, - NIP46_MAX_RETRIES, NIP46_HANDSHAKE_TIMEOUT_MS, NIP46_AUTH_CHALLENGE_MAX_ATTEMPTS, sanitizeRelayList, diff --git a/js/nostr/nip46Client.js b/js/nostr/nip46Client.js index 2931266c..53f07f27 100644 --- a/js/nostr/nip46Client.js +++ b/js/nostr/nip46Client.js @@ -30,11 +30,11 @@ import { Nip46RequestQueue, NIP46_PRIORITY } from "./nip46Queue.js"; export const HEX64_REGEX = /^[0-9a-f]{64}$/i; export const NIP46_RPC_KIND = 24_133; -export const NIP46_SESSION_STORAGE_KEY = "bitvid:nip46:session:v1"; -export const NIP46_PUBLISH_TIMEOUT_MS = 8_000; -export const NIP46_RESPONSE_TIMEOUT_MS = 15_000; -export const NIP46_SIGN_EVENT_TIMEOUT_MS = 20_000; -export const NIP46_MAX_RETRIES = 1; +const NIP46_SESSION_STORAGE_KEY = "bitvid:nip46:session:v1"; +const NIP46_PUBLISH_TIMEOUT_MS = 8_000; +const NIP46_RESPONSE_TIMEOUT_MS = 15_000; +const NIP46_SIGN_EVENT_TIMEOUT_MS = 20_000; +const NIP46_MAX_RETRIES = 1; export const NIP46_HANDSHAKE_TIMEOUT_MS = 60_000; export const NIP46_AUTH_CHALLENGE_MAX_ATTEMPTS = 5; export const NIP46_ENCRYPTION_ALGORITHMS = Object.freeze([ diff --git a/package-lock.json b/package-lock.json index 7dc2f8fa..27ff9d46 100644 --- a/package-lock.json +++ b/package-lock.json @@ -32,6 +32,9 @@ "stylelint": "^16.12.0", "stylelint-config-standard": "^36.0.1", "vitest": "^4.0.18" + }, + "engines": { + "node": ">=22" } }, "node_modules/@acemir/cssom": {