diff --git a/decisions/DECISIONS_2026-10-19_20-20-00_dispatch-race-routing.md b/decisions/DECISIONS_2026-10-19_20-20-00_dispatch-race-routing.md new file mode 100644 index 00000000..14346b04 --- /dev/null +++ b/decisions/DECISIONS_2026-10-19_20-20-00_dispatch-race-routing.md @@ -0,0 +1,5 @@ +# Bounded follow-up routing + +- Retain one worker: this is another test-harness boundary; no evidence warrants another product-code owner. +- Grant one race-test file plus regression/integrity notes. Product/shared-helper scope needs explicit routing. +- Preserve separate commits, assertions, natural process exit, and normal full landing gates. No test fix landed yet. diff --git a/docs/TODO.md b/docs/TODO.md index e88843ea..60655790 100644 --- a/docs/TODO.md +++ b/docs/TODO.md @@ -2,6 +2,8 @@ ## dispatch +- 2026-10-19 checkpoint: reviewed dbdac18d/6da037f5, independently verified profile-modal27/27 in2.46s and isolated race assertion62ms/process timeout10s. Routed client-reliability-2 to the existing worker for one-test harness cleanup. Preserve separate commits and normal full gates; no preview rebuild before verified landing. + - 2026-10-19: dispatch-1 startup goal and one-worker proposal landed at fa538097; preparation complete. Baseline at d9059116: lint 11/11, unit run completed 219 files before profile-modal suite timed out at 60s; isolated unrestricted rerun reproduced timeout; 205 files remain untested. fleet/TEAM-PROPOSAL.md proposes one client-reliability worker for this blocker, with queued torrent-probe lifetime as a later candidate. Await first-worker approval before adding/launching it. No product edits or workers started. - 2026-10-19: dispatch-2: first worker approved through desktop-chat relay, routine local work authorized within GOAL. Roster landed at 9e6c310d and client-reliability worker launched in its own tmux window (pid 138193); fleet-bitvid:preview on port 3000 preserved (HTTP 200). Next: monitor blocker/fix evidence, normal landings, and refresh preview after verified product changes. A clean NODE_TEST_CONTEXT-free isolated reproduction also timed out at 60s; one-time roster-only validation is recorded in PROGRAM.md. No product fixes landed yet. diff --git a/docs/agents/RESUME-BRIEF.md b/docs/agents/RESUME-BRIEF.md index 83d2d04a..e9f453fc 100644 --- a/docs/agents/RESUME-BRIEF.md +++ b/docs/agents/RESUME-BRIEF.md @@ -9,7 +9,7 @@ Read fleet/GOAL.md and PROGRAM.md. Robustness/usability/TODO work is authorized. | area | item | state | next step | | --- | --- | --- | --- | | dispatch | dispatch-2 | active coordination | roster landed 9e6c310d; one worker running; monitor results, owner updates, and preview refresh | -| client-reliability | client-reliability-1 | running in fleet-bitvid:client-reliability | classify/fix reproducible profile-modal suite timeout, preserve assertions, mutation-check regression and run full gates | +| client-reliability | client-reliability-1 and client-reliability-2 | profile fix committed dbdac18d/6da037f5; follow-up routed | merge updated prompt; fix retained relay work in the race test, then normal full gate before landing | ## Evidence and local preview @@ -20,3 +20,5 @@ Preserve fleet-bitvid:preview serving dispatch dist at http://127.0.0.1:3000. Af ## Bootstrap exception One administrative roster/brief commit uses temporary exact-scope validation because the worker's assigned existing hang blocks full-suite completion. Persistent gate settings, product code, and tests must be unchanged. Subsequent code uses normal full gates. No additional owner approval pending within routine scope. + +Latest checkpoint: independent profile-modal27/27 in2.46s. Worker full run226 file exits before race-suite retained relay work;198 untested. Independent isolated race assertion62ms, process timeout10s/exit124. Preview unchanged; no test fix landed yet. diff --git a/docs/agents/backlog/client-reliability-2.json b/docs/agents/backlog/client-reliability-2.json new file mode 100644 index 00000000..9547875c --- /dev/null +++ b/docs/agents/backlog/client-reliability-2.json @@ -0,0 +1,9 @@ +{ + "id": "client-reliability-2", + "area": "client-reliability", + "status": "open", + "title": "Make Nostr initialization race test hermetic and release retained relay work", + "blockedOn": null, + "addedOn": "2026-10-19", + "filedAt": "f303ab0e72ac60b49c5e1bd712b080de2a95a483" +} diff --git a/docs/agents/prompts/client-reliability.md b/docs/agents/prompts/client-reliability.md index 4d0a7c92..6579e034 100644 --- a/docs/agents/prompts/client-reliability.md +++ b/docs/agents/prompts/client-reliability.md @@ -1,5 +1,15 @@ # Area: Client reliability (`client-reliability`) +## Current bounded follow-up: client-reliability-2 + +Dispatch grants temporary ownership of tests/race/nostr-client-init-race.test.mjs, its Test Integrity Note, and client-reliability-2 backlog/notes. This extends the initial scope; no second worker or Nostr product-code ownership is granted. Merge unstable to receive this prompt and item before claiming it. Keep the existing profile-modal commits separate. Both items await normal full-gate success before landing. + +Evidence: race assertion passes in about 61ms but the process retains public-relay retries and exceeds isolated 10s/full-run 60s diagnostic bounds. Dispatch independently reproduced this (assertion 62ms, process exit124), and independently verified your profile-modal tree 27/27 in2.46s. + +Inspect the real post-init subscription boundary and cleanup. Make the harness hermetic, preserve concurrent-init/pool-ready/post-init-subscription assertions, and exit naturally without public relay traffic or retry timers. Read docs/nips/01.md and relevant subscription/lifecycle documentation before Nostr-related investigation. Product Nostr code, shared helpers, and the global runner remain excluded; report exact evidence/file needs before broader edits. + +No force-exit, unref-only masking, retries, added sleeps, loose assertions, quarantine, or timeout increases. A deterministic deferred barrier may replace the existing mock delay if appropriate. Pin the actual boundary with a regression and deliberately broken variant; record the integrity note. Run the race file to natural completion, the profile-modal suite, lint, and then full npm test with the existing diagnostic bound. Commit separately with client-reliability-2, merge unstable, verify that tree, and submit through unchanged normal landing gates once the full suite is green. Route any further unowned blocker with exact counts instead of broadening yourself. + ## Role and first assignment Improve client robustness and usability through small, reproducible fixes from the TODO backlog. Start with client-reliability-1: classify and fix the profile-modal controller suite hang, then report before picking a different subsystem. You are the only worker; dispatch owns staffing and priorities. diff --git a/fleet/LOG.md b/fleet/LOG.md index e1b4ed93..81d19a43 100644 --- a/fleet/LOG.md +++ b/fleet/LOG.md @@ -19,3 +19,9 @@ - Launch verified: fleet status reports client-reliability running pid 138193; tmux pane shows it reading rules/backlog. Team: 2 agents total, 1 worker. Roster landed at 9e6c310d (durable landed state and git log unstable). Exact bootstrap validator passed for 13 files, product/tests/persistent gate settings unchanged; normal configuration remains active for future landings. Owner launch update sent. - Preview check: HTTP 200 at http://127.0.0.1:3000; existing built-dist process preserved. No product changes to rebuild yet. No scheduler or additional worker activation. + +## 2026-10-19: Profile-modal progress and bounded follow-up + +- Reviewed dbdac18d and 6da037f5: test-only computed-style fixture optimization plus native-style focus contract. All 26 original scenarios retain assertions, one contract added; product/fixture mutants fail per committed evidence. No browser defect established. Dispatch independently ran 27/27 in2.46s (exit0); worker lint11/11. +- Full worker run: 226 file exits passed, race suite retained relay work after its assertion passed; 198 files untested. Dispatch isolated reproduction: assertion passed62ms, process timeout10s/exit124. No client fixes submitted or landed. +- Assigned client-reliability-2 to same single worker: temporary ownership of one race test and regression/integrity notes. No Nostr product/global runner scope; preserve assertions, hermetic IO and natural exit, then normal full gates. No additional worker. Preview stays on verified unstable. diff --git a/fleet/RULE-CHANGES.md b/fleet/RULE-CHANGES.md index 50b34fa4..d2fd16a8 100644 --- a/fleet/RULE-CHANGES.md +++ b/fleet/RULE-CHANGES.md @@ -9,6 +9,8 @@ a landing rule changes. ## 2026-10-19 +- Bounded routing: existing client-reliability worker temporarily owns tests/race/nostr-client-init-race.test.mjs plus its regression/integrity notes for client-reliability-2. Nostr product code and global runner remain excluded. Preserve assertions, separate commits, and normal landing gates. + - One-time first-worker bootstrap: the administrative roster/brief commit may land through a temporary queue configuration with an exact roster-and-documentation-only validator because the worker is assigned to the existing full-suite hang. No product/test/persistent-gate change is permitted by this check. Record the exception and actual result; subsequent code uses the normal full gate. - Owner direction relayed from Codex desktop chat authorizes dispatch to operate tmux, start the approved single client-reliability worker, and make routine staffing, prioritization, test/build, fix, and local unstable landing decisions without repeated approval. Record relay provenance; this is not approval for deploys, spending, production data, real-wallet operations, or schedulers. Send owner-mailbox event updates and refresh the existing local preview after verified changes. diff --git a/test_logs/TEST_LOG_2026-10-19_20-20-00_dispatch-checkpoint.md b/test_logs/TEST_LOG_2026-10-19_20-20-00_dispatch-checkpoint.md new file mode 100644 index 00000000..0f7df850 --- /dev/null +++ b/test_logs/TEST_LOG_2026-10-19_20-20-00_dispatch-checkpoint.md @@ -0,0 +1,7 @@ +# Dispatch checkpoint evidence + +- Reviewed committed diffs and test/integrity logs at dbdac18d and6da037f5: no product changes; 26 original scenarios retained, one native-style focus contract added. +- Independent read-only run of worker test file from dispatch: env -u NODE_TEST_CONTEXT NODE_ENV=test node --import ./tests/test-helpers/setup-localstorage.mjs --test-reporter=spec /home/user/Documents/GitHub/bitvid-client-reliability/tests/profile-modal-controller.test.mjs. Exit0 naturally,27/27,0 failures,2461.50ms. +- Independent original race-file diagnostic from dispatch: same clean environment/import/reporter with timeout10s. Assertion PASS62.33ms; process exit124 at diagnostic deadline. No test files modified by dispatch. +- Worker evidence: lint11/11, two mutants each fail. Full run226 file exits passed, file227 timed out,198 untested. These full-run/mutant results inspected from committed logs, not repeated independently. +- No client test fixes submitted or landed. Not verified: remaining198 files, full gate, browser, signers, build/release. Preview remains on verified unstable.