diff --git a/scripts/agent/automated-pr-review.mjs b/scripts/agent/automated-pr-review.mjs
deleted file mode 100644
index 19ed4dfd..00000000
--- a/scripts/agent/automated-pr-review.mjs
+++ /dev/null
@@ -1,127 +0,0 @@
-import { spawnSync, execSync } from 'child_process';
-import fs from 'fs';
-import path from 'path';
-
-const REPORT_FILE = 'PR_REVIEW.md';
-const APPLY_FIXES = process.argv.includes('--apply-fixes');
-
-function run(command, args, opts = {}) {
- console.log(`> ${command} ${args.join(' ')}`);
- return spawnSync(command, args, { encoding: 'utf-8', stdio: 'pipe', ...opts });
-}
-
-function getDiffFiles() {
- try {
- // Try to compare against origin/main, fallback to HEAD~1 or just check current changes if no upstream
- // Since this runs on a checkout, we want to see what this branch touches compared to main.
- // If origin/main is not available, we might fail.
- const hasMain = run('git', ['rev-parse', '--verify', 'origin/main']).status === 0;
- const base = hasMain ? 'origin/main' : 'HEAD';
-
- // Check if we are on main? No, we are on a PR branch usually.
- // We want the diff of the *current* code vs main.
- const res = run('git', ['diff', '--name-only', base, 'HEAD']);
- if (res.error || res.status !== 0) return [];
- return res.stdout.trim().split('\n').filter(Boolean);
- } catch (e) {
- console.error("Error getting diff:", e);
- return [];
- }
-}
-
-function main() {
- const report = [];
- report.push('# Automated PR Review');
- report.push(`Date: ${new Date().toISOString()}`);
- report.push('');
-
- // 1. npm ci
- console.log('Running npm ci...');
- const ci = run('npm', ['ci']);
- if (ci.status !== 0) {
- report.push('## đ¨ Dependency Install Failed');
- report.push('```');
- report.push(ci.stderr || ci.stdout);
- report.push('```');
- // If ci fails, we probably can't run other scripts, but we try.
- } else {
- report.push('## â
Dependencies Installed');
- }
-
- // 2. Format
- console.log('Running npm run format...');
- run('npm', ['run', 'format']); // This modifies files
-
- const status = run('git', ['status', '--porcelain']).stdout;
- const formattedFiles = status.split('\n').filter(l => l.trim()).map(l => l.slice(3));
-
- if (formattedFiles.length > 0) {
- report.push('## â ī¸ Formatting Changes');
- report.push('The following files were reformatted:');
- report.push(formattedFiles.map(f => `- ${f}`).join('\n'));
-
- if (APPLY_FIXES) {
- console.log('Applying formatting fixes...');
- run('git', ['add', '.']);
- run('git', ['commit', '-m', 'fix(ai): automated formatting (agent)']);
- report.push('\n**Changes have been automatically committed.**');
- } else {
- report.push('\n**Run `npm run format` to fix these issues.**');
- }
- } else {
- report.push('## â
Formatting Passed');
- }
-
- // 3. Lint
- console.log('Running npm run lint...');
- const lint = run('npm', ['run', 'lint']);
- if (lint.status !== 0) {
- report.push('## â ī¸ Lint Warnings/Errors');
- report.push('Show Lint Output
');
- report.push('');
- report.push('```');
- report.push(lint.stdout + '\n' + lint.stderr);
- report.push('```');
- report.push('Show Test Output
');
- report.push('');
- report.push('```');
- report.push(test.stdout + '\n' + test.stderr);
- report.push('```');
- report.push('');
- formattedFiles.forEach(f => report.push(`- ${f}
`));
- report.push('
');
- report.push('');
-
- // Fast-path suggestion
- report.push('**Suggestion:** apply `npm run format` and re-run tests');
-
- if (options.applyFixes) {
- try {
- log('Applying formatting fixes...');
- runCommand('git', ['add', '.']);
- // Explicit wording: fix(ai): (agent)
- runCommand('git', ['commit', '-m', 'fix(ai): formatting (agent)']);
-
- log('Pushing changes...');
- const pushResult = runCommand('git', ['push']);
-
- if (pushResult.status === 0) {
- report.push('**Action:** Applied and pushed formatting fixes (agent).');
- } else {
- log(`Push failed: ${pushResult.stderr}`);
- report.push('**Action:** Applied formatting fixes locally, but failed to push.');
- report.push(`**Error:** ${pushResult.stderr}`);
-
- if (checkGhAvailability()) {
- const newBranch = `fix/ai-formatting-${Date.now()}`;
- log(`Attempting fallback: creating new branch ${newBranch}...`);
- runCommand('git', ['checkout', '-b', newBranch]);
- const pushNew = runCommand('git', ['push', '-u', 'origin', newBranch]);
- if (pushNew.status === 0) {
- log('Creating fallback PR...');
- const prRes = spawnSync('gh', ['pr', 'create', '--title', 'fix(ai): formatting (agent)', '--body', 'Automated formatting fixes.', '--fill'], { encoding: 'utf-8' });
- if (prRes.status === 0) {
- report.push(`**Action:** Created follow-up PR: ${prRes.stdout.trim()}`);
- } else {
- report.push(`**Error:** Failed to create follow-up PR: ${prRes.stderr}`);
- }
- }
- }
- }
- } catch (e) {
- log(`Error applying fixes: ${e.message}`);
- report.push(`**Error:** Failed to apply formatting fixes: ${e.message}`);
- }
- } else {
- // If we're not applying fixes, we should revert the formatting changes so they don't affect subsequent steps?
- // However, keeping them might be good for running tests on clean code?
- // But if tests rely on formatting (unlikely), it matters.
- // Usually we revert so the working tree matches the PR state for further analysis.
- runCommand('git', ['checkout', '.'], { stdio: 'ignore' });
- }
- } else {
- report.push(`## â
Formatting`);
- report.push(`No formatting issues found.`);
- }
- }
-
- // 3. Lint
- if (!failed) {
- log('Running linter...');
- const lintResult = runCommand('npm', ['run', 'lint'], { shell: true });
- if (lintResult.status !== 0) {
- report.push(`## â ī¸ Linter Warnings/Errors`);
- report.push('`npm run lint` reported issues:');
-
- // Extract lines with "Error" or "Warning"
- const lines = (lintResult.stdout + '\n' + lintResult.stderr).split('\n');
- const issues = lines.filter(l => l.match(/error|warning/i)).slice(0, 20); // Limit to 20
-
- report.push('Show Lint Output
');
- report.push('');
- report.push('```');
- if (issues.length > 0) {
- report.push(issues.join('\n'));
- if (lines.length > issues.length) report.push('...');
- } else {
- report.push(lintResult.stdout.slice(-1000));
- report.push(lintResult.stderr.slice(-1000));
- }
- report.push('```');
- report.push('Show Test Output
');
- report.push('');
- report.push('```');
- // Capture context around the failure?
- // Usually the end of stdout has the failure.
- report.push(output.slice(-3000));
- report.push((testResult.stderr || '').slice(-3000));
- report.push('```');
- report.push('');
- sensitiveChanges.forEach(f => report.push(`- ${f}
`));
- report.push('
');
- }
-
- return report.join('\n');
-
- } catch (error) {
- log(`Error reviewing ${contextName}: ${error.message}`);
- return `Error reviewing ${contextName}: ${error.message}`;
- }
-}
-
-async function main() {
- const args = process.argv.slice(2);
- const options = {
- noInstall: args.includes('--no-install'),
- applyFixes: args.includes('--apply-fixes'),
- all: args.includes('--all'),
- pr: args.indexOf('--pr') > -1 ? args[args.indexOf('--pr') + 1] : null,
- };
-
- const branchArg = args.find(a => !a.startsWith('--') && args.indexOf(a) !== args.indexOf('--pr') + 1);
- const ghAvailable = checkGhAvailability();
-
- if (options.all) {
- if (!ghAvailable) {
- console.error('Error: `gh` CLI not found. Cannot list open PRs.');
- process.exit(1);
- }
- log('Fetching open PRs...');
- try {
- const prsJson = runCommand('gh', ['pr', 'list', '--json', 'number,headRefName,baseRefName,url']);
- if (prsJson.status !== 0) throw new Error(prsJson.stderr);
- const prs = JSON.parse(prsJson.stdout);
- log(`Found ${prs.length} open PRs.`);
-
- for (const pr of prs) {
- log(`Checking out PR #${pr.number} (${pr.headRefName})...`);
- try {
- runCommand('gh', ['pr', 'checkout', pr.number]);
- // Pass baseBranch from PR details
- options.baseBranch = pr.baseRefName;
- const report = await reviewContext(`PR #${pr.number}`, options);
- const tempFile = `pr_review_${pr.number}.md`;
- fs.writeFileSync(tempFile, report);
- log(`Posting comment to PR #${pr.number}...`);
- runCommand('gh', ['pr', 'comment', pr.number, '-F', tempFile]);
- fs.unlinkSync(tempFile);
- } catch (e) {
- log(`Failed to process PR #${pr.number}: ${e.message}`);
- }
- }
- } catch (e) {
- console.error('Error listing/processing PRs:', e);
- process.exit(1);
- }
- } else if (options.pr) {
- if (!ghAvailable) {
- console.error('Error: `gh` CLI not found.');
- process.exit(1);
- }
- log(`Checking out PR #${options.pr}...`);
- try {
- // Fetch base branch first
- const viewRes = runCommand('gh', ['pr', 'view', options.pr, '--json', 'baseRefName']);
- if (viewRes.status === 0) {
- const prDetails = JSON.parse(viewRes.stdout);
- options.baseBranch = prDetails.baseRefName;
- }
-
- const res = runCommand('gh', ['pr', 'checkout', options.pr]);
- if (res.status !== 0) throw new Error(res.stderr);
-
- const report = await reviewContext(`PR #${options.pr}`, options);
- console.log(report);
- fs.writeFileSync(LOG_FILE, report);
- log(`Report saved to ${LOG_FILE}`);
- } catch (e) {
- console.error(e);
- process.exit(1);
- }
- } else {
- let originalBranch;
- if (branchArg) {
- try {
- originalBranch = runCommand('git', ['branch', '--show-current']).stdout.trim();
- const res = runCommand('git', ['checkout', branchArg]);
- if (res.status !== 0) throw new Error(`Could not checkout ${branchArg}`);
- } catch(e) {
- console.error(e.message);
- process.exit(1);
- }
- }
-
- const currentBranch = runCommand('git', ['branch', '--show-current']).stdout.trim();
- // Logic for local run: can we guess the target?
- // Usually local run is 'against' something.
- // But we can just skip or default.
-
- const report = await reviewContext(currentBranch, options);
-
- console.log('\n--- REPORT ---\n');
- console.log(report);
- fs.writeFileSync(LOG_FILE, report);
- log(`Report saved to ${LOG_FILE}`);
-
- if (originalBranch) {
- runCommand('git', ['checkout', originalBranch]);
- }
- }
-}
-
-main();
diff --git a/scripts/automated-pr-review.mjs b/scripts/automated-pr-review.mjs
index 7e11be0c..c672d4ab 100644
--- a/scripts/automated-pr-review.mjs
+++ b/scripts/automated-pr-review.mjs
@@ -6,7 +6,10 @@ import path from 'node:path';
const SENSITIVE_PATHS = [
/^js\/nostr\//,
/^js\/storage\//,
+ /^js\/auth\//,
/^js\/dmDecryptor\.js$/,
+ /^js\/magnetUtils\.js$/,
+ /^js\/nostr\/adapters\/nip07Adapter\.js$/,
/^js\/services\/storageService\.js$/,
/^js\/services\/attachmentService\.js$/,
/^js\/services\/hashtagPreferencesService\.js$/,
@@ -86,6 +89,13 @@ function checkReleaseChannel(changedFiles) {
warnings.push(`â ī¸ **Release Channel Warning**: This PR targets \`main\` but modifies the following critical configuration files: ${modifiedCriticalFiles.map(f => `\`${f}\``).join(', ')}.`);
warnings.push(`> **Guidance:** \`main\` is the production track. Ensure feature flags in \`js/constants.js\` are set to safe defaults (usually \`false\`) and \`config/instance-config.js\` has production-appropriate settings (e.g. \`IS_DEV_MODE\`).`);
}
+ } else if (baseRef === 'unstable') {
+ const criticalFiles = ['js/constants.js'];
+ const modifiedCriticalFiles = changedFiles.filter(f => criticalFiles.includes(f));
+ if (modifiedCriticalFiles.length > 0) {
+ warnings.push(`âšī¸ **Release Channel Info**: This PR targets \`unstable\`.`);
+ warnings.push(`> **Guidance:** \`unstable\` is the experimentation lane. If you are adding risky behavior, gate it behind feature flags in \`js/constants.js\` and document the toggle/rollback plan. See \`AGENTS.md\` for details.`);
+ }
}
return warnings;
}