From 5fe938ef9fd10157a65c644bf7b68c96a9f07931 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 31 Jan 2026 10:34:19 +0000 Subject: [PATCH] fix(ci): address failures in lint, login permissions, and unit tests - Update `scripts/check-hex.js` to ignore `releases/` directory to prevent false positives from PR numbers. - Update `js/nostr/client.js` to request full NIP-07 permissions (including encryption) during login, fixing `tests/nostr-login-permissions.test.mjs`. - Update `tests/hashtag-preferences.test.mjs` to make the mock fetch function consistently return the event, allowing retry logic to be tested correctly. Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> --- js/nostr/client.js | 2 +- scripts/check-hex.js | 3 ++- tests/hashtag-preferences.test.mjs | 4 +--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/js/nostr/client.js b/js/nostr/client.js index 1ab71bac..2b7e5ae3 100644 --- a/js/nostr/client.js +++ b/js/nostr/client.js @@ -2079,7 +2079,7 @@ export class NostrClient { } const permissionResult = await this.ensureExtensionPermissions( - DEFAULT_NIP07_CORE_METHODS, + DEFAULT_NIP07_PERMISSION_METHODS, { context: "login", logMetrics: true, showStatus: false }, ); if (!permissionResult.ok) { diff --git a/scripts/check-hex.js b/scripts/check-hex.js index 3874779d..33976245 100755 --- a/scripts/check-hex.js +++ b/scripts/check-hex.js @@ -31,7 +31,8 @@ const IGNORED_GLOBS = [ 'tests/unit/embed-accent.test.mjs', 'tests/visual/embed-layout.spec.ts', 'ai/**', - '**/*.ai' + '**/*.ai', + 'releases/**' ]; const gitArgs = [ diff --git a/tests/hashtag-preferences.test.mjs b/tests/hashtag-preferences.test.mjs index f72827cd..afd68da7 100644 --- a/tests/hashtag-preferences.test.mjs +++ b/tests/hashtag-preferences.test.mjs @@ -248,10 +248,8 @@ test( tags: [["encrypted", "nip04"]], }; - let fetchCalls = 0; nostrClient.fetchListIncrementally = async () => { - fetchCalls += 1; - return fetchCalls === 1 ? [event] : []; + return [event]; }; nostrClient.relays = relayUrls; nostrClient.writeRelays = relayUrls;