From 73be11403b6d5e0d117ecbb6ada240774f2ff581 Mon Sep 17 00:00:00 2001
From: thePR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
Date: Tue, 7 Oct 2025 11:40:24 -0400
Subject: [PATCH] Refine profile modal service dependencies

---
 js/app.js                       | 55 +--------------------------------
 js/ui/profileModalController.js |  8 ++++-
 2 files changed, 8 insertions(+), 55 deletions(-)

diff --git a/js/app.js b/js/app.js
index 4c13282b..9889530c 100644
--- a/js/app.js
+++ b/js/app.js
@@ -7,7 +7,7 @@ import {
 } from "./nostr.js";
 import { torrentClient } from "./webtorrent.js";
 import { isDevMode, ADMIN_SUPER_NPUB } from "./config.js";
-import { accessControl, normalizeNpub } from "./accessControl.js";
+import { accessControl } from "./accessControl.js";
 import { safeDecodeMagnet } from "./magnetUtils.js";
 import { extractMagnetHints, normalizeAndAugmentMagnet } from "./magnet.js";
 import { deriveTorrentPlaybackConfig } from "./playbackUtils.js";
@@ -122,9 +122,6 @@ const UNSUPPORTED_BTITH_MESSAGE =
   "This magnet link is missing a compatible BitTorrent v1 info hash.";
 
 const FALLBACK_THUMBNAIL_SRC = "assets/jpg/video-thumbnail-fallback.jpg";
-const ADMIN_DM_IMAGE_URL =
-  "https://beta.bitvid.network/assets/jpg/video-thumbnail-fallback.jpg";
-const BITVID_WEBSITE_URL = "https://bitvid.network/";
 const MAX_DISCUSSION_COUNT_VIDEOS = 24;
 const VIDEO_EVENT_KIND = 30078;
 const HEX64_REGEX = /^[0-9a-f]{64}$/i;
@@ -1273,8 +1270,6 @@ class Application {
           createDefaultNwcSettings: () => createDefaultNwcSettings(),
           ensureWallet: (options) => this.ensureWallet(options),
           loadVideos: (forceFetch) => this.loadVideos(forceFetch),
-          sendAdminListNotification: (payload) =>
-            this.sendAdminListNotification(payload),
           describeAdminError: (code) => this.describeAdminError(code),
           describeNotificationError: (code) =>
             this.describeNotificationError(code),
@@ -1782,54 +1777,6 @@ class Application {
     }
   }
 
-  async sendAdminListNotification({ listType, actorNpub, targetNpub }) {
-    const normalizedTarget = normalizeNpub(targetNpub);
-    if (!normalizedTarget) {
-      return { ok: false, error: "invalid-target" };
-    }
-
-    if (!this.pubkey) {
-      return { ok: false, error: "missing-actor-pubkey" };
-    }
-
-    const actorHex = this.pubkey;
-    const fallbackActor = this.safeEncodeNpub(actorHex) || "a BitVid moderator";
-    const actorDisplay = normalizeNpub(actorNpub) || fallbackActor;
-    const isWhitelist = listType === "whitelist";
-
-    const introLine = isWhitelist
-      ? `Great news—your npub ${normalizedTarget} has been added to the BitVid whitelist by ${actorDisplay}.`
-      : `We wanted to let you know that your npub ${normalizedTarget} has been placed on the BitVid blacklist by ${actorDisplay}.`;
-
-    const statusLine = isWhitelist
-      ? `You now have full creator access across BitVid (${BITVID_WEBSITE_URL}).`
-      : `This hides your channel and prevents uploads across BitVid (${BITVID_WEBSITE_URL}) for now.`;
-
-    const followUpLine = isWhitelist
-      ? "Please take a moment to review our community guidelines (https://bitvid.network/#view=community-guidelines), and reply to this DM if you have any questions."
-      : "Please review our community guidelines (https://bitvid.network/#view=community-guidelines). If you believe this was a mistake, you can submit an appeal at https://bitvid.network/?modal=appeals to request reinstatement, or reply to this DM with any questions.";
-
-    const messageBody = [
-      "Hi there,",
-      "",
-      introLine,
-      "",
-      statusLine,
-      "",
-      followUpLine,
-      "",
-      "— The BitVid Team",
-    ].join("\n");
-
-    const message = `![BitVid status update](${ADMIN_DM_IMAGE_URL})\n\n${messageBody}`;
-
-    return nostrClient.sendDirectMessage(
-      normalizedTarget,
-      message,
-      actorHex
-    );
-  }
-
   async onAccessControlUpdated() {
     try {
       await this.refreshAdminPaneState();
diff --git a/js/ui/profileModalController.js b/js/ui/profileModalController.js
index 6e3006d8..e3758403 100644
--- a/js/ui/profileModalController.js
+++ b/js/ui/profileModalController.js
@@ -111,6 +111,7 @@ const SERVICE_CONTRACT = [
     type: "function",
     description:
       "Sends an administrative notification when moderators/whitelist/blacklist entries change.",
+    optional: true,
   },
   {
     key: "describeAdminError",
@@ -246,6 +247,9 @@ function buildServicesContract(services = {}) {
   SERVICE_CONTRACT.forEach((definition) => {
     const value = services[definition.key];
     if (value == null) {
+      if (definition.optional) {
+        return;
+      }
       missing.push(`- ${definition.key}: ${definition.description}`);
       return;
     }
@@ -341,7 +345,9 @@ export class ProfileModalController {
     this.safeDecodeNpub = this.services.safeDecodeNpub;
     this.truncateMiddle = this.services.truncateMiddle;
     this.sendAdminListNotificationService =
-      this.services.sendAdminListNotification;
+      typeof this.services.sendAdminListNotification === "function"
+        ? this.services.sendAdminListNotification
+        : null;
     this.describeAdminErrorService = this.services.describeAdminError;
     this.describeNotificationErrorService =
       this.services.describeNotificationError;