From 75fe39c862fbe4a4b7f2ace8e445be4821378c71 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Fri, 30 Jan 2026 01:31:17 +0000
Subject: [PATCH] fix(test): mock nostrClient.readRelays in profile batch
 fetcher test

This fixes a CI failure where `batchFetchProfilesFromRelays` made duplicate relay calls because `nostrClient.readRelays` was not mocked, causing it to fall back to default values or overlap with the mocked `nostrClient.relays`.

The test `tests/app-batch-fetch-profiles.test.mjs` now explicitly saves, mocks, and restores `nostrClient.readRelays` to ensure test isolation and accurate call counts.

Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
---
 tests/app-batch-fetch-profiles.test.mjs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/app-batch-fetch-profiles.test.mjs b/tests/app-batch-fetch-profiles.test.mjs
index df90a4bc..f682cab3 100644
--- a/tests/app-batch-fetch-profiles.test.mjs
+++ b/tests/app-batch-fetch-profiles.test.mjs
@@ -52,12 +52,16 @@ test("batchFetchProfiles handles fast and failing relays", async () => {
   const originalWriteRelays = Array.isArray(nostrClient.writeRelays)
     ? [...nostrClient.writeRelays]
     : nostrClient.writeRelays;
+  const originalReadRelays = Array.isArray(nostrClient.readRelays)
+    ? [...nostrClient.readRelays]
+    : nostrClient.readRelays;
   const originalPool = nostrClient.pool;
 
   const poolListCalls = [];
 
   nostrClient.relays = [FAST_RELAY, FAIL_RELAY];
   nostrClient.writeRelays = [FAST_RELAY, FAIL_RELAY];
+  nostrClient.readRelays = [FAST_RELAY, FAIL_RELAY];
   nostrClient.pool = {
     list: (relays, filters) => {
       poolListCalls.push({ relays, filters });
@@ -93,6 +97,7 @@ test("batchFetchProfiles handles fast and failing relays", async () => {
   } finally {
     nostrClient.relays = originalRelays;
     nostrClient.writeRelays = originalWriteRelays;
+    nostrClient.readRelays = originalReadRelays;
     nostrClient.pool = originalPool;
   }