From 7ccba8ab61208f3bd36eb956ab4a88d8d1e581f0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 17 Feb 2026 00:47:08 +0000 Subject: [PATCH] =?UTF-8?q?[security]=20replace=20innerHTML=20usages=20in?= =?UTF-8?q?=20js/historyView.js=20=E2=80=94=20convert=20to=20safe=20DOM=20?= =?UTF-8?q?APIs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> --- ...-02-17_00-44-39_innerhtml-migration-agent_completed.md | 1 + js/historyView.js | 8 ++++---- scripts/check-innerhtml.mjs | 1 - 3 files changed, 5 insertions(+), 5 deletions(-) create mode 100644 docs/agents/task-logs/daily/2026-02-17_00-44-39_innerhtml-migration-agent_completed.md diff --git a/docs/agents/task-logs/daily/2026-02-17_00-44-39_innerhtml-migration-agent_completed.md b/docs/agents/task-logs/daily/2026-02-17_00-44-39_innerhtml-migration-agent_completed.md new file mode 100644 index 00000000..5be84d04 --- /dev/null +++ b/docs/agents/task-logs/daily/2026-02-17_00-44-39_innerhtml-migration-agent_completed.md @@ -0,0 +1 @@ +Successfully migrated 4 innerHTML assignments in `js/historyView.js` to `replaceChildren()`. Updated baseline. diff --git a/js/historyView.js b/js/historyView.js index 144ed5c0..4246a440 100644 --- a/js/historyView.js +++ b/js/historyView.js @@ -1782,7 +1782,7 @@ export function createWatchHistoryRenderer(config = {}) { function showEmptyState() { if (elements.grid) { - elements.grid.innerHTML = ""; + elements.grid.replaceChildren(); setHidden(elements.grid, true); } clearHistoryCardRegistry(); @@ -1806,7 +1806,7 @@ export function createWatchHistoryRenderer(config = {}) { } detachObserver(); if (elements.grid) { - elements.grid.innerHTML = ""; + elements.grid.replaceChildren(); setHidden(elements.grid, true); } if (elements.empty) { @@ -2304,7 +2304,7 @@ export function createWatchHistoryRenderer(config = {}) { } state.cursor = 0; state.hasMore = state.items.length > 0; - elements.grid.innerHTML = ""; + elements.grid.replaceChildren(); clearHistoryCardRegistry(); removeEmptyDayContainers(elements.grid); if (!state.items.length) { @@ -2427,7 +2427,7 @@ export function createWatchHistoryRenderer(config = {}) { } clearSubscriptions(); if (elements.grid) { - elements.grid.innerHTML = ""; + elements.grid.replaceChildren(); } clearHistoryCardRegistry(); state.initialized = false; diff --git a/scripts/check-innerhtml.mjs b/scripts/check-innerhtml.mjs index e218763e..95a192f2 100644 --- a/scripts/check-innerhtml.mjs +++ b/scripts/check-innerhtml.mjs @@ -27,7 +27,6 @@ const BASELINE = { "js/docsView.js": 1, "js/exploreView.js": 1, "js/forYouView.js": 1, - "js/historyView.js": 4, "js/index.js": 1, "js/kidsView.js": 1, "js/ui/components/DeleteModal.js": 3,