From 7a3476f92641db429de95c72fc0fbae5ec8707f2 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Fri, 30 Jan 2026 07:37:47 +0000
Subject: [PATCH] fix: flaky unit test in profile batch fetcher

Updated `tests/app-batch-fetch-profiles.test.mjs` to correctly mock `readRelays` in addition to `relays` and `writeRelays`. `profileMetadataService.js` prioritizes `readRelays`, causing the test to make unexpected network calls when falling back to default values. This fix ensures the test isolation holds and assertions pass consistently.

Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
---
 tests/app-batch-fetch-profiles.test.mjs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/app-batch-fetch-profiles.test.mjs b/tests/app-batch-fetch-profiles.test.mjs
index df90a4bc..45148645 100644
--- a/tests/app-batch-fetch-profiles.test.mjs
+++ b/tests/app-batch-fetch-profiles.test.mjs
@@ -49,6 +49,9 @@ test("batchFetchProfiles handles fast and failing relays", async () => {
   const originalRelays = Array.isArray(nostrClient.relays)
     ? [...nostrClient.relays]
     : [];
+  const originalReadRelays = Array.isArray(nostrClient.readRelays)
+    ? [...nostrClient.readRelays]
+    : nostrClient.readRelays;
   const originalWriteRelays = Array.isArray(nostrClient.writeRelays)
     ? [...nostrClient.writeRelays]
     : nostrClient.writeRelays;
@@ -57,6 +60,7 @@ test("batchFetchProfiles handles fast and failing relays", async () => {
   const poolListCalls = [];
 
   nostrClient.relays = [FAST_RELAY, FAIL_RELAY];
+  nostrClient.readRelays = [FAST_RELAY, FAIL_RELAY];
   nostrClient.writeRelays = [FAST_RELAY, FAIL_RELAY];
   nostrClient.pool = {
     list: (relays, filters) => {
@@ -92,6 +96,7 @@ test("batchFetchProfiles handles fast and failing relays", async () => {
     });
   } finally {
     nostrClient.relays = originalRelays;
+    nostrClient.readRelays = originalReadRelays;
     nostrClient.writeRelays = originalWriteRelays;
     nostrClient.pool = originalPool;
   }