From 99e6fe3c9c4b0ae6ecf82c2e4cf764f742fbaec3 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Thu, 12 Feb 2026 02:23:29 +0000
Subject: [PATCH] chore(ai): CI health fixes (flaky tests)

Fix flaky test in `tests/hashtag-preferences.test.mjs` by using `waitFor` to handle async decryption timing. The previous implementation relied on direct assertion after a promise resolution, which was prone to microtask timing issues with `runNip07WithRetry`.

Also ran `npm audit` and `npm install` to ensure environment health, but no lockfile changes were needed.

Ref: https://github.com/bitvid/bitvid/issues/CI-HEALTH

Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
---
 tests/hashtag-preferences.test.mjs | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/tests/hashtag-preferences.test.mjs b/tests/hashtag-preferences.test.mjs
index e30a9a30..df7c7db8 100644
--- a/tests/hashtag-preferences.test.mjs
+++ b/tests/hashtag-preferences.test.mjs
@@ -1,5 +1,6 @@
 import test from "node:test";
 import assert from "node:assert/strict";
+import { waitFor } from "./test-helpers/wait-for.mjs";
 
 const hashtagPreferencesModule = await import(
   "../js/services/hashtagPreferencesService.js"
@@ -301,19 +302,17 @@ test(
       );
       assert.deepEqual(hashtagPreferences.getInterests(), []);
 
-      // TODO: This part of the test is flaky in CI environments.
-      // Logs confirm the code attempts decryption ("Attempting decryption via window.nostr fallback"),
-      // but the mock spy is not consistently called, likely due to runNip07WithRetry/microtask timing.
-
       permissionState.enabled = true;
       await hashtagPreferences.load(pubkey, { allowPermissionPrompt: true });
 
-      assert.equal(
-        decryptCalls.length,
-        1,
-        "explicit permission prompts should retry decryption",
-      );
-      assert.deepEqual(hashtagPreferences.getInterests(), ["late"]);
+      await waitFor(() => {
+        assert.equal(
+          decryptCalls.length,
+          1,
+          "explicit permission prompts should retry decryption",
+        );
+        assert.deepEqual(hashtagPreferences.getInterests(), ["late"]);
+      });
     } finally {
       relayManager.setEntries(originalRelayEntries, { allowEmpty: true, updateClient: false });
       nostrClient.fetchListIncrementally = originalFetchIncremental;