From 9d3a0df02a2b3b62e64fcacba176e0e62bdbabd0 Mon Sep 17 00:00:00 2001
From: thePR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
Date: Sat, 20 Jun 2026 15:00:43 -0400
Subject: [PATCH] feat(my-videos): wire bucket reconciliation into the tab
 (Phase 2, step 3b)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After the note-side list renders, the My Videos tab now reconciles against the
bucket: lists the user's objects (unlock-gated), then marks any active note whose
hosted file is gone as a 🟠 "Missing file", and lists bucket objects no current
video references in an "Orphaned storage objects" section — including files left
behind by videos deleted on Nostr (the headline cleanup case). Each orphan has a
"Delete file" button (with a confirm) that calls deleteStorageKeys and refreshes.

Reconciliation runs after the list is shown so the UI stays responsive, and is a
no-op (orphan section hidden) when storage is locked/unconfigured. Rows carry a
data-video-id + a data-role pill so missing status can be applied in place.

Build + full lint green (DOM via createElement/textContent, no innerHTML).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 components/profile-modal.html            |  14 +++
 js/ui/profileModal/MyVideosController.js | 125 +++++++++++++++++++++++
 2 files changed, 139 insertions(+)

diff --git a/components/profile-modal.html b/components/profile-modal.html
index 559097ba..6cebbf32 100644
--- a/components/profile-modal.html
+++ b/components/profile-modal.html
@@ -993,6 +993,20 @@
                 class="grid-stack"
                 data-orientation="vertical"
               ></ul>
+              <div id="profileMyVideosOrphans" class="space-y-2 hidden">
+                <h4 class="text-sm font-semibold text-text">
+                  Orphaned storage objects
+                </h4>
+                <p class="text-2xs text-muted">
+                  Files in your bucket that no current video references — safe to
+                  remove to reclaim space.
+                </p>
+                <ul
+                  id="profileMyVideosOrphanList"
+                  class="grid-stack"
+                  data-orientation="vertical"
+                ></ul>
+              </div>
             </section>
 
             <section
diff --git a/js/ui/profileModal/MyVideosController.js b/js/ui/profileModal/MyVideosController.js
index b1692c52..45035de5 100644
--- a/js/ui/profileModal/MyVideosController.js
+++ b/js/ui/profileModal/MyVideosController.js
@@ -3,6 +3,7 @@ import { nostrClient } from "../../nostrClientFacade.js";
 import { getApplication } from "../../applicationContext.js";
 import { collapseUserVideos } from "./myVideosData.js";
 import { classifyVideoHealth, isUrlUnderBase } from "./myVideosHealth.js";
+import { reconcileStorage } from "./myVideosReconcile.js";
 
 // Maps a health severity to a status-pill style, mirroring
 // ProfileRelayController.applyStatusPill so the look stays consistent.
@@ -31,8 +32,11 @@ export class MyVideosController {
     this.loadingEl = null;
     this.emptyEl = null;
     this.refreshBtn = null;
+    this.orphansSection = null;
+    this.orphanListEl = null;
     this.loading = false;
     this.publicBaseUrl = "";
+    this.pubkey = "";
   }
 
   cacheDomReferences() {
@@ -41,6 +45,10 @@ export class MyVideosController {
     this.loadingEl = document.getElementById("profileMyVideosLoading") || null;
     this.emptyEl = document.getElementById("profileMyVideosEmpty") || null;
     this.refreshBtn = document.getElementById("profileMyVideosRefreshBtn") || null;
+    this.orphansSection =
+      document.getElementById("profileMyVideosOrphans") || null;
+    this.orphanListEl =
+      document.getElementById("profileMyVideosOrphanList") || null;
   }
 
   registerEventListeners() {
@@ -99,6 +107,7 @@ export class MyVideosController {
     }
 
     this.loading = true;
+    this.pubkey = pubkey;
     this.setLoading(true);
     try {
       this.publicBaseUrl = await this.resolvePublicBaseUrl(pubkey);
@@ -119,12 +128,124 @@ export class MyVideosController {
       const rows = collapseUserVideos(all, pubkey);
       this.renderRows(rows);
       this.setSummary(this.buildSummary(rows));
+      // Bucket reconciliation runs after the note-side list is shown so the UI is
+      // responsive; it then layers missing-file pills + the orphan section on top.
+      void this.runReconciliation(rows, pubkey);
     } finally {
       this.loading = false;
       this.setLoading(false);
     }
   }
 
+  async runReconciliation(rows, pubkey) {
+    const r2Service = this.mainController.services?.r2Service;
+    if (!r2Service || typeof r2Service.listVideoStorageObjects !== "function") {
+      this.renderOrphans([]);
+      return;
+    }
+    let listing;
+    try {
+      listing = await r2Service.listVideoStorageObjects({ pubkey });
+    } catch (err) {
+      devLogger.warn("[myVideos] listVideoStorageObjects failed:", err);
+      this.renderOrphans([]);
+      return;
+    }
+    if (!listing || !listing.ok) {
+      // Locked storage etc. — nothing to reconcile against; leave note-side
+      // health as-is and hide the orphan section.
+      this.renderOrphans([]);
+      return;
+    }
+    const { missing, orphanKeys } = reconcileStorage({
+      videos: rows,
+      bucketKeys: listing.keys,
+      publicBaseUrl: this.publicBaseUrl,
+    });
+    for (const entry of missing) {
+      this.markRowMissing(entry.video);
+    }
+    this.renderOrphans(orphanKeys);
+  }
+
+  markRowMissing(video) {
+    if (!(this.listEl instanceof HTMLElement) || !video?.id) {
+      return;
+    }
+    const li = this.listEl.querySelector(
+      `li[data-video-id="${CSS.escape(video.id)}"]`,
+    );
+    const pill = li?.querySelector('[data-role="health-pill"]');
+    if (li instanceof HTMLElement) {
+      li.dataset.health = "missing-file";
+    }
+    if (pill instanceof HTMLElement) {
+      pill.className = `${PILL_BASE} ${PILL_BY_SEVERITY.warning}`;
+      pill.textContent = "Missing file";
+    }
+  }
+
+  renderOrphans(keys) {
+    const list = Array.isArray(keys) ? keys : [];
+    if (this.orphansSection instanceof HTMLElement) {
+      this.orphansSection.classList.toggle("hidden", list.length === 0);
+    }
+    if (!(this.orphanListEl instanceof HTMLElement)) {
+      return;
+    }
+    this.orphanListEl.replaceChildren();
+    for (const key of list) {
+      this.orphanListEl.appendChild(this.buildOrphanRow(key));
+    }
+  }
+
+  buildOrphanRow(key) {
+    const li = document.createElement("li");
+    li.className =
+      "card flex items-center justify-between gap-3 p-3 border border-border/60";
+
+    const label = document.createElement("span");
+    label.className = "truncate text-2xs text-muted font-mono";
+    label.textContent = key;
+    label.title = key;
+
+    const del = this.buildActionButton("Delete file", () => {
+      void this.handleDeleteOrphan(key);
+    }, true);
+
+    li.appendChild(label);
+    li.appendChild(del);
+    return li;
+  }
+
+  async handleDeleteOrphan(key) {
+    const r2Service = this.mainController.services?.r2Service;
+    if (!r2Service || typeof r2Service.deleteStorageKeys !== "function") {
+      return;
+    }
+    if (typeof window !== "undefined" && typeof window.confirm === "function") {
+      if (!window.confirm(`Permanently delete this file from your bucket?\n\n${key}`)) {
+        return;
+      }
+    }
+    let result;
+    try {
+      result = await r2Service.deleteStorageKeys({ keys: [key], pubkey: this.pubkey });
+    } catch (err) {
+      devLogger.warn("[myVideos] deleteStorageKeys failed:", err);
+      this.mainController.showError?.("Failed to delete the file. Please try again.");
+      return;
+    }
+    if (result?.ok && result.deleted?.length) {
+      this.mainController.showSuccess?.("Removed the orphaned file from your bucket.");
+      void this.populate({ forceFetch: false });
+    } else if (result?.reason === "storage-locked") {
+      this.mainController.showError?.("Unlock storage first, then delete the file.");
+    } else {
+      this.mainController.showError?.("Failed to delete the file. Please try again.");
+    }
+  }
+
   buildSummary(rows) {
     if (!rows.length) {
       return "";
@@ -182,6 +303,9 @@ export class MyVideosController {
     const li = document.createElement("li");
     li.className = "card flex items-center gap-3 p-3 border border-border/60";
     li.dataset.health = health.status;
+    if (typeof video.id === "string" && video.id) {
+      li.dataset.videoId = video.id;
+    }
 
     li.appendChild(this.buildThumb(video));
 
@@ -199,6 +323,7 @@ export class MyVideosController {
     const pill = document.createElement("span");
     pill.className = `${PILL_BASE} ${PILL_BY_SEVERITY[health.severity] || PILL_BY_SEVERITY.info}`;
     pill.textContent = health.label;
+    pill.dataset.role = "health-pill";
 
     titleRow.appendChild(title);
     titleRow.appendChild(pill);