From 3571b52b13db59279545fadb48e44101513cc846 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 11 Feb 2026 22:41:18 +0000 Subject: [PATCH] fix(ci): unskip visual tests and align node versions - Unskip `mobile sidebar shares desktop rail behavior` in `tests/visual/overlay-layers.spec.ts`. - Enable visibility check in `tests/visual/moderation.spec.ts` (removed TODO). - Update `daily-design-system-audit.yml` and `agent-pr-review.yml` to use Node.js 22. - Set `fetch-depth: 0` in `ci.yml` build job to ensure `sw-compat` lint check runs. Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> --- .github/workflows/agent-pr-review.yml | 2 +- .github/workflows/ci.yml | 2 ++ .github/workflows/daily-design-system-audit.yml | 2 +- tests/visual/moderation.spec.ts | 4 +--- tests/visual/overlay-layers.spec.ts | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/agent-pr-review.yml b/.github/workflows/agent-pr-review.yml index 497478b0..6f2f14a5 100644 --- a/.github/workflows/agent-pr-review.yml +++ b/.github/workflows/agent-pr-review.yml @@ -26,7 +26,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: 'npm' - name: Add upstream remote diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b87d4a60..447a539e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,6 +22,8 @@ jobs: steps: - name: Check out repository uses: actions/checkout@v4 + with: + fetch-depth: 0 - name: Set up Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 diff --git a/.github/workflows/daily-design-system-audit.yml b/.github/workflows/daily-design-system-audit.yml index c16cffa3..07693caf 100644 --- a/.github/workflows/daily-design-system-audit.yml +++ b/.github/workflows/daily-design-system-audit.yml @@ -23,7 +23,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '20' + node-version: '22' cache: 'npm' - name: Verify gh CLI availability diff --git a/tests/visual/moderation.spec.ts b/tests/visual/moderation.spec.ts index 7f05beaa..a698ecb9 100644 --- a/tests/visual/moderation.spec.ts +++ b/tests/visual/moderation.spec.ts @@ -211,9 +211,7 @@ test.describe("moderation fixtures", () => { await expect(muteCard).toHaveAttribute("data-moderation-trusted-mute-count", "1"); await expect(badge).toContainText("Hidden ยท 1 trusted mute"); await expect(thumbnail).toHaveAttribute("data-thumbnail-state", "blurred"); - // TODO: Visibility check fails in headless environment due to layout issues (0x0 size). - // Verifying existence via selector instead of role/visibility. - // await expect(showAnywayButton).toBeVisible(); + await expect(showAnywayButton).toBeVisible(); const showAnywayLocator = muteCard.locator('button[data-moderation-action="override"]'); await expect(showAnywayLocator).toHaveCount(1); await expect(showAnywayLocator).toHaveAttribute("aria-label", "Show anyway"); diff --git a/tests/visual/overlay-layers.spec.ts b/tests/visual/overlay-layers.spec.ts index 6be5ba7f..07f14d47 100644 --- a/tests/visual/overlay-layers.spec.ts +++ b/tests/visual/overlay-layers.spec.ts @@ -10,7 +10,7 @@ declare global { } test.describe("overlay layering tokens", () => { - test.skip("mobile sidebar shares desktop rail behavior", async ({ page }) => { + test("mobile sidebar shares desktop rail behavior", async ({ page }) => { // Increase timeout for this visual test which is prone to flakiness in CI test.setTimeout(120_000);