From b0c00ebc99e7f692bd3207f6af91c7fcfcfe4e1e Mon Sep 17 00:00:00 2001
From: thePR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com>
Date: Sun, 14 Jun 2026 15:57:34 -0400
Subject: [PATCH] fix(lint): catch bare pool.sub/list calls in chokepoint guard
 (KNOWN_BUG #3)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The guard only matched member access (.pool.sub); bare local-variable calls
(pool.sub/pool.list) slipped through. Broadened the regex and re-baselined the
allowlist — true scope is 22 files (10 were hidden), e.g. viewEvents.js,
relayBatchFetcher.js, watchHistory.js, commentEvents.js. The L1 chokepoint is
now actually enforced; the allowlist only shrinks as P4 migrates subsystems.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 scripts/check-direct-pool-access.mjs | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/scripts/check-direct-pool-access.mjs b/scripts/check-direct-pool-access.mjs
index 7e0d73b6..e5d912e4 100644
--- a/scripts/check-direct-pool-access.mjs
+++ b/scripts/check-direct-pool-access.mjs
@@ -23,7 +23,13 @@ const ROOT = new URL("..", import.meta.url).pathname.replace(/\/$/, "");
 const SOURCE_DIR = join(ROOT, "js");
 
 // Patterns that indicate a direct relay-read outside L1.
-const PATTERNS = [/\.pool\.sub\(/, /\.pool\.list\(/, /\blegacySub\(/, /\blegacyList\(/, /\bsubscribeMap\(/];
+const PATTERNS = [
+  /\bpool\.sub\(/,
+  /\bpool\.list\(/,
+  /\blegacySub\(/,
+  /\blegacyList\(/,
+  /\bsubscribeMap\(/,
+];
 
 // The only modules allowed to touch the pool directly.
 const L1_FILES = new Set([
@@ -38,8 +44,18 @@ const GRANDFATHERED = new Set([
   "js/adminListStore.js",
   "js/app.js",
   "js/channelProfile.js",
+  "js/embed.js",
   "js/feedEngine/watchHistoryFeed.js",
   "js/nostr/client.js",
+  "js/nostr/commentEvents.js",
+  "js/nostr/nip46Client.js",
+  "js/nostr/nip46Connector.js",
+  "js/nostr/reactionEvents.js",
+  "js/nostr/relayBatchFetcher.js",
+  "js/nostr/viewEvents.js",
+  "js/nostr/watchHistory.js",
+  "js/payments/platformAddress.js",
+  "js/payments/zapReceiptValidator.js",
   "js/reactionCounter.js",
   "js/relayManager.js",
   "js/searchView.js",