From cf4e6eb1d41c3063ade28fcba34cff9e727badb4 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 23 Feb 2026 01:00:08 +0000 Subject: [PATCH] fix(ci): Resolve runtime crash in ProfileStorageController and race in UploadModal - Fixes `TypeError: Cannot set properties of null (setting 'value')` in `ProfileStorageController` by adding guards for DOM elements during background login (fixes `feed-pagination-stress` and likely `video-upload-flow`). - Fixes `UploadModal` visibility race condition by awaiting `load()` in `open()` (from previous attempt). - Adds timeout to `notification-system.spec.ts` to prevent flakiness (from previous attempt). - Updates visual baselines (from previous attempt). - Moves `initializeUserInterface` earlier in `app.js` startup (from previous attempt). Co-authored-by: PR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> --- js/ui/profileModal/ProfileStorageController.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/js/ui/profileModal/ProfileStorageController.js b/js/ui/profileModal/ProfileStorageController.js index 853c997f..91f5d488 100644 --- a/js/ui/profileModal/ProfileStorageController.js +++ b/js/ui/profileModal/ProfileStorageController.js @@ -679,14 +679,14 @@ export class ProfileStorageController { } handleClearStorage() { - this.storageEndpointInput.value = ""; - this.storageRegionInput.value = "auto"; - this.storageAccessKeyInput.value = ""; - this.storageSecretKeyInput.value = ""; - this.storageBucketInput.value = ""; - this.storagePrefixInput.value = ""; - this.storageDefaultInput.checked = false; - this.storageProviderInput.value = "cloudflare_r2"; + if (this.storageEndpointInput) this.storageEndpointInput.value = ""; + if (this.storageRegionInput) this.storageRegionInput.value = "auto"; + if (this.storageAccessKeyInput) this.storageAccessKeyInput.value = ""; + if (this.storageSecretKeyInput) this.storageSecretKeyInput.value = ""; + if (this.storageBucketInput) this.storageBucketInput.value = ""; + if (this.storagePrefixInput) this.storagePrefixInput.value = ""; + if (this.storageDefaultInput) this.storageDefaultInput.checked = false; + if (this.storageProviderInput) this.storageProviderInput.value = "cloudflare_r2"; if (this.storageForcePathStyleInput) { this.storageForcePathStyleInput.checked = true; }