diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bf32bf1c..b81333d2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -132,6 +132,10 @@ For a full guide, see the [Local Setup section in README.md](./README.md#local-s npx update-browserslist-db@latest ``` +- **Unit Test Hangs**: `npm run test:unit` may occasionally hang after completion due to open handles. If this happens, use `Ctrl+C` to exit. For CI or faster local runs, consider running specific shards (e.g., `npm run test:unit:shard1`). + +- **Linting Failures**: `npm run lint` includes checks for inline styles (e.g., `style="..."` or `.style.prop = ...`). Move these styles to CSS classes or design tokens to pass linting. + ## Dev Container This project includes a `.devcontainer` configuration for VS Code. It provides a pre-configured environment with Node.js 22 and necessary extensions. diff --git a/css/tailwind.source.css b/css/tailwind.source.css index df2a6e1d..02fbc6cf 100644 --- a/css/tailwind.source.css +++ b/css/tailwind.source.css @@ -492,7 +492,7 @@ @media (min-width: theme("screens.md")) { .search-filters-panel.is-advanced-open { - width: 40rem; + width: var(--size-40rem); } } diff --git a/css/tokens.css b/css/tokens.css index e2020f53..4c7d1fae 100644 --- a/css/tokens.css +++ b/css/tokens.css @@ -321,6 +321,7 @@ --size-20rem: 20rem; --size-28rem: 28rem; --size-34rem: 34rem; + --size-40rem: 40rem; --size-45rem: 45rem; --size-70rem: 70rem; diff --git a/js/ui/components/SearchFilterModal.js b/js/ui/components/SearchFilterModal.js index 8e1bdcbe..b30079a4 100644 --- a/js/ui/components/SearchFilterModal.js +++ b/js/ui/components/SearchFilterModal.js @@ -168,10 +168,10 @@ function toggleAdvanced(forceState = null) { if (newState) { advancedPanel.classList.remove("hidden"); - advancedChevron.style.transform = "rotate(180deg)"; + advancedChevron.classList.add("rotate-180"); } else { advancedPanel.classList.add("hidden"); - advancedChevron.style.transform = "rotate(0deg)"; + advancedChevron.classList.remove("rotate-180"); } }