From 17ac445e7a1d6830f7370243ada583a0414e6226 Mon Sep 17 00:00:00 2001 From: thePR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> Date: Sat, 31 May 2025 10:31:49 -0400 Subject: [PATCH] Unify offset arg name and fix imports --- README.md | 4 ++-- scripts/bitcoin_m2_chart.py | 4 ++-- scripts/custom_chart.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 36f6c7f..a7ac1ac 100644 --- a/README.md +++ b/README.md @@ -183,7 +183,7 @@ After downloading the required series, generate the Bitcoin‐Global M2 overlay ([Real Python][1], [Software Engineering Stack Exchange][2]) 2. Renames each column to `"value"` for consistency. - 3. Finds the overlapping date range, shifts M2 by `--offset-days` (default = 94 days), and overlays the two series on dual axes. + 3. Finds the overlapping date range, shifts M2 by `--offset` (default = 94 days), and overlays the two series on dual axes. 4. Saves the figure—e.g., `outputs/bitcoin_m2_chart_20250531_090608.png` ([martinheinz.dev][4], [Real Python][1]) > **CLI Options for `bitcoin_m2_chart.py`:** @@ -194,7 +194,7 @@ After downloading the required series, generate the Bitcoin‐Global M2 overlay > | `--m2-series` | `GLOBAL_M2` | FRED series code for global M2 money supply | > | `--start` | `2010-01-01` | Start date for fetching both series | > | `--end` | Today | End date for fetching both series | -> | `--offset-days` | `94` | Shift M2 by this many days (positive → M2 leads) | +> | `--offset` | `94` | Shift M2 by this many days (positive → M2 leads) | > | `--extend-years` | `1` | Years beyond `end` to extend the x‐axis | > | `--output` | None | Optional path to save the figure (PNG/PDF) | diff --git a/scripts/bitcoin_m2_chart.py b/scripts/bitcoin_m2_chart.py index 60eec9b..764b88b 100644 --- a/scripts/bitcoin_m2_chart.py +++ b/scripts/bitcoin_m2_chart.py @@ -104,7 +104,7 @@ def main(argv: list[str] | None = None) -> plt.Figure: help="end date YYYY-MM-DD", ) p.add_argument( - "--offset-days", + "--offset", type=int, default=94, help="shift M2 by this many days (positive = M2 leads)", @@ -124,7 +124,7 @@ def main(argv: list[str] | None = None) -> plt.Figure: end_dt = datetime.fromisoformat(args.end) btc, m2 = fetch_series(start_dt, end_dt, args.btc_series, args.m2_series, args.db) - fig = plot_bitcoin_m2(btc, m2, args.offset_days, args.extend_years) + fig = plot_bitcoin_m2(btc, m2, args.offset, args.extend_years) save_figure(fig, args.output, __file__) if argv is None: diff --git a/scripts/custom_chart.py b/scripts/custom_chart.py index 598576d..e2b6adc 100644 --- a/scripts/custom_chart.py +++ b/scripts/custom_chart.py @@ -20,7 +20,7 @@ import matplotlib.pyplot as plt import pandas as pd # IMPORTANT: import common directly (no "scripts." prefix) -from common import fetch_series_db, save_figure +from scripts.common import fetch_series_db, save_figure def fetch_series_multi(