From a89b8d042bcb54b3131c8797f6ca7625952afd7d Mon Sep 17 00:00:00 2001 From: thePR0M3TH3AN <53631862+PR0M3TH3AN@users.noreply.github.com> Date: Tue, 8 Jul 2025 15:09:23 -0400 Subject: [PATCH] Add tag editing from retrieval --- src/password_manager/manager.py | 10 +++++ src/tests/test_add_tags_from_retrieve.py | 49 ++++++++++++++++++++++++ 2 files changed, 59 insertions(+) create mode 100644 src/tests/test_add_tags_from_retrieve.py diff --git a/src/password_manager/manager.py b/src/password_manager/manager.py index d595ff1..390dd8d 100644 --- a/src/password_manager/manager.py +++ b/src/password_manager/manager.py @@ -1623,6 +1623,7 @@ class PasswordManager: print(colored("C. Add Custom Field", "cyan")) print(colored("H. Add Hidden Field", "cyan")) print(colored("E. Edit", "cyan")) + print(colored("T. Add Tags", "cyan")) choice = ( input("Select an action or press Enter to return: ").strip().lower() @@ -1659,6 +1660,15 @@ class PasswordManager: self.entry_manager.modify_entry(index, custom_fields=custom_fields) self.is_dirty = True self.last_update = time.time() + elif choice == "t": + tags_input = input("Enter tags (comma-separated): ").strip() + if tags_input: + new_tags = [t.strip() for t in tags_input.split(",") if t.strip()] + existing_tags = entry.get("tags", []) + tags = list({*existing_tags, *new_tags}) + self.entry_manager.modify_entry(index, tags=tags) + self.is_dirty = True + self.last_update = time.time() elif choice == "e": self._entry_edit_menu(index, entry) else: diff --git a/src/tests/test_add_tags_from_retrieve.py b/src/tests/test_add_tags_from_retrieve.py new file mode 100644 index 0000000..fac5866 --- /dev/null +++ b/src/tests/test_add_tags_from_retrieve.py @@ -0,0 +1,49 @@ +import sys +from pathlib import Path +from tempfile import TemporaryDirectory +from types import SimpleNamespace + +from helpers import create_vault, TEST_SEED, TEST_PASSWORD + +sys.path.append(str(Path(__file__).resolve().parents[1])) + +from password_manager.entry_management import EntryManager +from password_manager.backup import BackupManager +from password_manager.manager import PasswordManager, EncryptionMode +from password_manager.config_manager import ConfigManager + + +class FakePasswordGenerator: + def generate_password(self, length: int, index: int) -> str: # noqa: D401 + return "pw" + + +def test_add_tags_from_retrieve(monkeypatch): + with TemporaryDirectory() as tmpdir: + tmp_path = Path(tmpdir) + vault, enc_mgr = create_vault(tmp_path, TEST_SEED, TEST_PASSWORD) + cfg_mgr = ConfigManager(vault, tmp_path) + backup_mgr = BackupManager(tmp_path, cfg_mgr) + entry_mgr = EntryManager(vault, backup_mgr) + + pm = PasswordManager.__new__(PasswordManager) + pm.encryption_mode = EncryptionMode.SEED_ONLY + pm.encryption_manager = enc_mgr + pm.vault = vault + pm.entry_manager = entry_mgr + pm.backup_manager = backup_mgr + pm.password_generator = FakePasswordGenerator() + pm.parent_seed = TEST_SEED + pm.nostr_client = SimpleNamespace() + pm.fingerprint_dir = tmp_path + pm.secret_mode_enabled = False + + index = entry_mgr.add_entry("example.com", 8) + + inputs = iter([str(index), "t", "work,personal", ""]) + monkeypatch.setattr("builtins.input", lambda *a, **k: next(inputs)) + + pm.handle_retrieve_entry() + + entry = entry_mgr.retrieve_entry(index) + assert set(entry.get("tags", [])) == {"work", "personal"}