mirror of
https://github.com/PR0M3TH3AN/SeedPass.git
synced 2026-11-06 12:52:04 +00:00
Fix index verification for TOTP in modify entry test
The test `test_modify_entry_invalid_fields` was hardcoding `index = 0` for TOTP entries because `add_totp` returns a URI string instead of an index. This change unifies the index determination logic by calling `entry_manager.get_next_index()` before adding the entry. This ensures the correct index is verified for all entry types, including TOTP. Modified: - src/tests/test_modify_entry_validation.py: Use get_next_index() for dynamic index determination. Co-authored-by: PR0M3TH3AN <[email protected]>
This commit is contained in:
1 parent
88781479aa
commit
29b955c913
2 files changed
+4
-63
No files matched your search
@@ -81,17 +81,10 @@ def test_modify_entry_invalid_fields(
|
||||
):
|
||||
"""Test that modify_entry raises ValueError for invalid fields based on EntryType."""
|
||||
# Setup entry
|
||||
if entry_type == EntryType.TOTP:
|
||||
# add_totp returns a URI string, need to fix the index manually or check implementation
|
||||
# Checking implementation: add_totp returns URI string, but index is predictable (0)
|
||||
# However, we should verify the index.
|
||||
# For simplicity, we assume index 0 as it's the first entry.
|
||||
setup_func(entry_manager)
|
||||
index = 0
|
||||
elif entry_type == EntryType.PASSWORD:
|
||||
index = setup_func(entry_manager)
|
||||
else:
|
||||
index = setup_func(entry_manager)
|
||||
# Some setup functions return the index, but add_totp returns a URI string.
|
||||
# To be consistent and verify the index, we get it before calling setup_func.
|
||||
index = entry_manager.get_next_index()
|
||||
setup_func(entry_manager)
|
||||
|
||||
# Verify entry exists and has correct type
|
||||
entry = entry_manager.retrieve_entry(index)
|
||||
|
||||
Reference in new issue
Block a user