mirror of
https://github.com/PR0M3TH3AN/SeedPass.git
synced 2026-11-04 03:42:04 +00:00
Pin nostr-sdk below 0.44, which the client code cannot build against
CI went red where the Tests workflow stayed green, and the reason is that the two install from different lockfiles which had drifted apart: poetry.lock held nostr-sdk 0.43.0, requirements.lock had resolved to 0.45.0 under the unbounded `>=0.43`. Two lockfiles disagreeing about a protocol SDK is not a CI quirk — it means the code was being tested against one version and shipped against another. 0.44 removed NostrSigner's constructors, including the NostrSigner.keys the client calls, and changed Client's constructor. Verified against 0.45.0: NostrSigner is left with only get_public_key, sign_event and the nip04/nip44 methods, and Client.__init__ takes no arguments. So this is a real migration touching signing and client setup, not a rename to be done in passing. Bounded at <0.44 in all three places the constraint is declared, and both lockfiles regenerated: requirements.lock resolves 0.43.1, poetry.lock keeps 0.43.0, and the relock changed exactly one line — the content hash — with no version churn anywhere else. Confirmed 0.43.1 still exposes NostrSigner.keys and a Client that takes an argument, since that is what CI will actually install. pip-audit reports no advisory against the 0.43 line, so the bound costs nothing today. The migration is recorded in TODO.md rather than attempted here: it wants the sync round-trip re-validated against a real relay, not folded into a CI fix. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Vtx94nXDmNgXEeThUZP4QN
This commit is contained in:
1 parent
dec2b0f677
commit
cd1ced63e1
5 files changed
+38
-18
No files matched your search
@@ -11,7 +11,9 @@ pytest>=9.0.3,<10
|
||||
pytest-cov>=4,<7
|
||||
pytest-xdist>=3,<4
|
||||
portalocker>=2.8,<4
|
||||
nostr-sdk>=0.43,<1
|
||||
# 0.44 removed NostrSigner.keys and changed Client's constructor; the
|
||||
# client code does not build against it yet. See TODO.md.
|
||||
nostr-sdk>=0.43,<0.44
|
||||
websocket-client>=1.7,<2
|
||||
|
||||
websockets>=15,<16
|
||||
|
||||
Reference in new issue
Block a user