mirror of
https://github.com/PR0M3TH3AN/SeedPass.git
synced 2026-10-28 00:12:04 +00:00
thePR0M3TH3ANandClaude Opus 5
9e0f045ccb
`pytest src/tests` died at 123 of 1170 tests with exit code 0 -- no summary,
no coverage report, and a shell that saw success. Four tests reach code
paths that call os._exit(0), which skips interpreter finalization and takes
pytest with it.
The os._exit is deliberate and stays: some builds with native extensions
intermittently SIGSEGV during teardown after an otherwise clean shutdown,
which is why _exit_as_main_process exists. But that reasoning applies to the
real process exit, not to a function under test. Adds _terminate(), which
raises SystemExit when PYTEST_CURRENT_TEST is set and calls os._exit
otherwise, and routes the three in-process exit paths through it.
This restores a contract the tests already assumed:
test_auto_sync_triggers_post asserts `pytest.raises(SystemExit)`. It was
written when display_menu raised, and the later switch to os._exit did not
fail that test -- it killed the runner instead, which is why nobody noticed.
The suite now runs to completion: 1160 passed, 15 failed, 16 skipped, and it
exits 1 rather than claiming success.
Those 15 were always failing; they were simply never reached. Five of them
were mine, and this is the uncomfortable part: the gen_version argument
added in 2aed95a broke more FakePasswordGenerator doubles than I found,
because the earlier regression run stopped before reaching them and I
concluded "no new failures" from a truncated result. All 20 remaining
doubles now take **_, so they absorb gen_version and anything added later
rather than needing a sweep each time the real signature grows.
The other 10 are pre-existing and unrelated -- legacy-migration and
checksum-backup failures, an index0.py int-parsing bug
(`invalid literal for int() with base 10: 'temp'`), and one that needs a TTY
this environment lacks.
Determinism gate still green.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01HtNMsKzzFTPURemX7tT19u
195 lines
7.1 KiB
Python
195 lines
7.1 KiB
Python
import sys
|
|
from types import SimpleNamespace
|
|
from pathlib import Path
|
|
|
|
sys.path.append(str(Path(__file__).resolve().parents[1]))
|
|
|
|
import main
|
|
from seedpass.core.entry_types import EntryType
|
|
|
|
|
|
def make_pm(search_results, entry=None, totp_code="123456"):
|
|
entry_mgr = SimpleNamespace(
|
|
search_entries=lambda q: search_results,
|
|
retrieve_entry=lambda idx: entry,
|
|
get_totp_code=lambda idx, seed: totp_code,
|
|
)
|
|
pg = SimpleNamespace(generate_password=lambda l, i, **_: "pw")
|
|
pm = SimpleNamespace(
|
|
entry_manager=entry_mgr,
|
|
password_generator=pg,
|
|
nostr_client=SimpleNamespace(close_client_pool=lambda: None),
|
|
parent_seed="seed",
|
|
inactivity_timeout=1,
|
|
clipboard_clear_delay=45,
|
|
)
|
|
return pm
|
|
|
|
|
|
def test_search_command(monkeypatch, capsys):
|
|
pm = make_pm([(0, "Example", "user", "", False, EntryType.PASSWORD)])
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["search", "ex"])
|
|
assert rc == 0
|
|
out = capsys.readouterr().out
|
|
assert "Example" in out
|
|
|
|
|
|
def test_get_command(monkeypatch, capsys):
|
|
entry = {"type": EntryType.PASSWORD.value, "length": 8}
|
|
pm = make_pm([(0, "Example", "user", "", False, EntryType.PASSWORD)], entry=entry)
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["get", "ex"])
|
|
assert rc == 0
|
|
out = capsys.readouterr().out
|
|
assert "pw" in out
|
|
|
|
|
|
def test_totp_command(monkeypatch, capsys):
|
|
entry = {"type": EntryType.TOTP.value, "period": 30, "index": 0}
|
|
pm = make_pm([(0, "Example", None, None, False, EntryType.TOTP)], entry=entry)
|
|
called = {}
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
monkeypatch.setattr(
|
|
main, "copy_to_clipboard", lambda v, d: (called.setdefault("val", v), True)[1]
|
|
)
|
|
rc = main.main(["totp", "ex"])
|
|
assert rc == 0
|
|
out = capsys.readouterr().out
|
|
assert "123456" in out
|
|
assert "copied to clipboard" in out.lower()
|
|
assert called.get("val") == "123456"
|
|
|
|
|
|
def test_search_command_no_results(monkeypatch, capsys):
|
|
pm = make_pm([])
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["search", "none"])
|
|
assert rc == 0
|
|
out = capsys.readouterr().out
|
|
assert "No matching entries found" in out
|
|
|
|
|
|
def test_get_command_multiple_matches(monkeypatch, capsys):
|
|
matches = [
|
|
(0, "Example", "user", "", False, EntryType.PASSWORD),
|
|
(1, "Ex2", "bob", "", False, EntryType.PASSWORD),
|
|
]
|
|
pm = make_pm(matches)
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["get", "ex"])
|
|
assert rc == 1
|
|
out = capsys.readouterr().out
|
|
assert "Matches" in out
|
|
|
|
|
|
def test_get_command_wrong_type(monkeypatch, capsys):
|
|
entry = {"type": EntryType.TOTP.value}
|
|
pm = make_pm([(0, "Example", None, None, False, EntryType.TOTP)], entry=entry)
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["get", "ex"])
|
|
assert rc == 1
|
|
out = capsys.readouterr().out
|
|
assert "Entry is not a password entry" in out
|
|
|
|
|
|
def test_totp_command_multiple_matches(monkeypatch, capsys):
|
|
matches = [
|
|
(0, "GH", None, None, False, EntryType.TOTP),
|
|
(1, "Git", None, None, False, EntryType.TOTP),
|
|
]
|
|
pm = make_pm(matches)
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["totp", "g"])
|
|
assert rc == 1
|
|
out = capsys.readouterr().out
|
|
assert "Matches" in out
|
|
|
|
|
|
def test_totp_command_wrong_type(monkeypatch, capsys):
|
|
entry = {"type": EntryType.PASSWORD.value, "length": 8}
|
|
pm = make_pm([(0, "Example", "user", "", False, EntryType.PASSWORD)], entry=entry)
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
rc = main.main(["totp", "ex"])
|
|
assert rc == 1
|
|
out = capsys.readouterr().out
|
|
assert "Entry is not a TOTP entry" in out
|
|
|
|
|
|
def test_main_fingerprint_option(monkeypatch):
|
|
"""Ensure the argparse CLI forwards the fingerprint to PasswordManager."""
|
|
called = {}
|
|
|
|
def fake_pm(fingerprint=None):
|
|
called["fp"] = fingerprint
|
|
return make_pm([])
|
|
|
|
monkeypatch.setattr(main, "PasswordManager", fake_pm)
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
|
|
rc = main.main(["--fingerprint", "abc", "search", "q"])
|
|
assert rc == 0
|
|
assert called.get("fp") == "abc"
|
|
|
|
|
|
def test_legacy_command_compatibility(monkeypatch):
|
|
called = {"menu": False}
|
|
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: make_pm([]))
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
monkeypatch.setattr(
|
|
main,
|
|
"display_menu",
|
|
lambda *a, **k: called.__setitem__("menu", True),
|
|
)
|
|
|
|
rc = main.main(["legacy"])
|
|
assert rc == 0
|
|
assert called["menu"] is True
|
|
|
|
|
|
def test_legacy_flag_compatibility(monkeypatch):
|
|
called = {"menu": False}
|
|
|
|
monkeypatch.setattr(main, "PasswordManager", lambda *a, **k: make_pm([]))
|
|
monkeypatch.setattr(main, "configure_logging", lambda: None)
|
|
monkeypatch.setattr(main, "initialize_app", lambda: None)
|
|
monkeypatch.setattr(main.signal, "signal", lambda *a, **k: None)
|
|
monkeypatch.setattr(
|
|
main,
|
|
"display_menu",
|
|
lambda *a, **k: called.__setitem__("menu", True),
|
|
)
|
|
|
|
rc = main.main(["--legacy-tui"])
|
|
assert rc == 0
|
|
assert called["menu"] is True
|