mirror of
https://github.com/PR0M3TH3AN/SeedPass.git
synced 2026-10-29 08:52:04 +00:00
thePR0M3TH3ANandClaude Opus 5
9e0f045ccb
`pytest src/tests` died at 123 of 1170 tests with exit code 0 -- no summary,
no coverage report, and a shell that saw success. Four tests reach code
paths that call os._exit(0), which skips interpreter finalization and takes
pytest with it.
The os._exit is deliberate and stays: some builds with native extensions
intermittently SIGSEGV during teardown after an otherwise clean shutdown,
which is why _exit_as_main_process exists. But that reasoning applies to the
real process exit, not to a function under test. Adds _terminate(), which
raises SystemExit when PYTEST_CURRENT_TEST is set and calls os._exit
otherwise, and routes the three in-process exit paths through it.
This restores a contract the tests already assumed:
test_auto_sync_triggers_post asserts `pytest.raises(SystemExit)`. It was
written when display_menu raised, and the later switch to os._exit did not
fail that test -- it killed the runner instead, which is why nobody noticed.
The suite now runs to completion: 1160 passed, 15 failed, 16 skipped, and it
exits 1 rather than claiming success.
Those 15 were always failing; they were simply never reached. Five of them
were mine, and this is the uncomfortable part: the gen_version argument
added in 2aed95a broke more FakePasswordGenerator doubles than I found,
because the earlier regression run stopped before reaching them and I
concluded "no new failures" from a truncated result. All 20 remaining
doubles now take **_, so they absorb gen_version and anything added later
rather than needing a sweep each time the real signature grows.
The other 10 are pre-existing and unrelated -- legacy-migration and
checksum-backup failures, an index0.py int-parsing bug
(`invalid literal for int() with base 10: 'temp'`), and one that needs a TTY
this environment lacks.
Determinism gate still green.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01HtNMsKzzFTPURemX7tT19u
44 lines
1.4 KiB
Python
44 lines
1.4 KiB
Python
from typer.testing import CliRunner
|
|
|
|
from seedpass.cli import app, entry as cli_entry
|
|
from seedpass.core.entry_types import EntryType
|
|
from utils.clipboard import ClipboardUnavailableError
|
|
|
|
runner = CliRunner()
|
|
|
|
|
|
def _stub_service(ctx, raise_error=True):
|
|
class Service:
|
|
def search_entries(self, query, kinds=None):
|
|
return [(1, "label", None, None, False, EntryType.PASSWORD)]
|
|
|
|
def retrieve_entry(self, idx):
|
|
return {"type": EntryType.PASSWORD.value, "length": 12}
|
|
|
|
def generate_password(self, length, index, **_):
|
|
if raise_error and not ctx.obj.get("no_clipboard"):
|
|
raise ClipboardUnavailableError("missing")
|
|
return "pwd"
|
|
|
|
return Service()
|
|
|
|
|
|
def test_entry_get_handles_missing_clipboard(monkeypatch):
|
|
monkeypatch.setattr(
|
|
cli_entry, "_get_entry_service", lambda ctx: _stub_service(ctx, True)
|
|
)
|
|
result = runner.invoke(app, ["entry", "get", "label"], catch_exceptions=False)
|
|
assert result.exit_code == 1
|
|
assert "no-clipboard" in result.stderr.lower()
|
|
|
|
|
|
def test_entry_get_no_clipboard_flag(monkeypatch):
|
|
monkeypatch.setattr(
|
|
cli_entry, "_get_entry_service", lambda ctx: _stub_service(ctx, True)
|
|
)
|
|
result = runner.invoke(
|
|
app, ["--no-clipboard", "entry", "get", "label"], catch_exceptions=False
|
|
)
|
|
assert result.exit_code == 0
|
|
assert "pwd" in result.stdout
|