mirror of
https://github.com/PR0M3TH3AN/bitgate.git
synced 2026-10-27 08:31:00 +00:00
thePR0M3TH3AN
4f689184e2
The evaluator was a skeleton with invented thresholds (5/3/10/5) and two unimplemented branches. Rebuild it against the migration plan's spec and the behavior characterized from the pinned reference commit. Core: - four independent decision dimensions (ranking, visibility, interaction, transaction) with severity ladders and max-merge composition - stable reason identifiers replacing free-text strings - structured evidence, redacted unless a profile opts in - administrative-state reduction with capability filtering at merge time, so revoking a role drops that actor's entries immediately - protected actors stripped from every denial set - snapshot fingerprints for cache invalidation - generic policy engine: applications supply profiles and category thresholds; the core carries none of its own Characterization: - 34 generated fixtures covering every behavior the plan's Phase 0 requires - conformance suite that actually evaluates them, replacing a placeholder that asserted a list's length - reference thresholds (3/3/20/5, 60-day mute window) live in bitvid-compat as an application profile, not as engine defaults Fixes found while building: - reduceAdminState accepted malformed target identifiers, because getTargetKey formats anything it is given - community-user-deny fired for any contributor rather than only for community-curated sources 273 tests pass; typecheck and the reference-import guard are clean.
77 lines
2.5 KiB
JavaScript
77 lines
2.5 KiB
JavaScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { REASON_IDS, createReason, dedupeReasons, isReasonId } from "../src/reasons.js";
|
|
|
|
describe("reason identifiers", () => {
|
|
it("exposes the documented set", () => {
|
|
expect(REASON_IDS).toContain("viewer-block");
|
|
expect(REASON_IDS).toContain("trusted-mute-threshold");
|
|
expect(REASON_IDS).toContain("surface-policy-bypass");
|
|
});
|
|
|
|
it("has no duplicates", () => {
|
|
expect(new Set(REASON_IDS).size).toBe(REASON_IDS.length);
|
|
});
|
|
|
|
it("recognizes known ids only", () => {
|
|
expect(isReasonId("viewer-block")).toBe(true);
|
|
expect(isReasonId("made-up")).toBe(false);
|
|
expect(isReasonId(undefined)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("createReason", () => {
|
|
it("creates a bare reason", () => {
|
|
expect(createReason("viewer-block")).toEqual({ id: "viewer-block" });
|
|
});
|
|
|
|
it("attaches detail fields", () => {
|
|
expect(
|
|
createReason("trusted-report-threshold", { category: " Spam ", count: 4, threshold: 3 }),
|
|
).toEqual({ id: "trusted-report-threshold", category: "Spam", count: 4, threshold: 3 });
|
|
});
|
|
|
|
it("omits blank and non-numeric detail", () => {
|
|
expect(createReason("trusted-report", { category: " ", count: Number.NaN })).toEqual({
|
|
id: "trusted-report",
|
|
});
|
|
});
|
|
|
|
it("rejects an unknown identifier", () => {
|
|
expect(() => createReason(/** @type {any} */ ("invented"))).toThrow(/Unknown reason identifier/);
|
|
});
|
|
});
|
|
|
|
describe("dedupeReasons", () => {
|
|
it("collapses identical reasons", () => {
|
|
expect(dedupeReasons([createReason("viewer-block"), createReason("viewer-block")])).toHaveLength(1);
|
|
});
|
|
|
|
it("keeps reasons that differ by category", () => {
|
|
const reasons = dedupeReasons([
|
|
createReason("trusted-report", { category: "spam" }),
|
|
createReason("trusted-report", { category: "nudity" }),
|
|
]);
|
|
expect(reasons).toHaveLength(2);
|
|
});
|
|
|
|
it("keeps the highest count when merging", () => {
|
|
const reasons = dedupeReasons([
|
|
createReason("trusted-report", { count: 2 }),
|
|
createReason("trusted-report", { count: 7 }),
|
|
]);
|
|
expect(reasons[0].count).toBe(7);
|
|
});
|
|
|
|
it("preserves first-seen order", () => {
|
|
const reasons = dedupeReasons([createReason("viewer-mute"), createReason("viewer-block")]);
|
|
expect(reasons.map((r) => r.id)).toEqual(["viewer-mute", "viewer-block"]);
|
|
});
|
|
|
|
it("drops malformed entries", () => {
|
|
expect(
|
|
dedupeReasons(/** @type {any[]} */ ([null, { id: "not-real" }, createReason("viewer-block")])),
|
|
).toHaveLength(1);
|
|
});
|
|
});
|