thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-11-06 04:42:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(upload): fail fast on 0-byte files in multipartUpload

Browse Source 
A 0-byte file produced a multipart upload with zero parts, which S3/R2 reject
with a cryptic CompleteMultipartUpload error. Guard file.size === 0 up front
with a clear message, before any S3 request is issued. Cloudflare-upload #4.

Test: tests/multipart-empty-file-guard.test.mjs.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
thePR0M3TH3ANandClaude Opus 4.8 committed 2026-06-16 20:15:17 -04:00
1 parent 6b603cc21c
commit 04ae0ec4e6
2 files changed
+43
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

js/storage/s3-multipart.js
+5
View File
@@ -177,6 +177,11 @@ export async function multipartUpload({
if (!file) {
throw new Error("File is required");
}
// A 0-byte file produces a multipart upload with zero parts, which S3/R2
// rejects with a cryptic CompleteMultipartUpload error. Fail fast and clearly.
if (typeof file.size === "number" && file.size === 0) {
throw new Error("File is empty (0 bytes). Choose a non-empty file to upload.");
}
const {
CreateMultipartUploadCommand,