thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-11-03 11:22:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ai): extract notification logic from js/app.js (agent)

Browse Source 
- Moved `showError`, `showStatus`, `showSuccess`, and `updateNotificationPortalVisibility` logic to `js/ui/notificationController.js`.
- Instantiated `NotificationController` in `js/ui/applicationBootstrap.js`.
- Refactored `js/app.js` to delegate notification calls to the controller.
- Added unit tests for `NotificationController`.
- Followed AGENTS.md refactoring checklist.

Co-authored-by: PR0M3TH3AN <[email protected]>
This commit is contained in:
google-labs-jules[bot]andPR0M3TH3AN committed 2026-02-01 03:08:05 +00:00
1 parent cd6e5862d7
commit 1dfc23c11a
4 files changed
+424 -201
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

js/ui/applicationBootstrap.js
+15 -8
View File
@@ -1,4 +1,4 @@
import { devLogger } from "../utils/logger.js";
import { devLogger, userLogger } from "../utils/logger.js";
import { MediaLoader } from "../utils/mediaLoader.js";
import { attachHealthBadges } from "../gridHealth.js";
import { attachUrlHealthBadges } from "../urlHealthObserver.js";
@@ -36,6 +36,7 @@ import { VideoListView } from "./views/VideoListView.js";
import MoreMenuController from "./moreMenuController.js";
import VideoSettingsMenuController from "./videoSettingsMenuController.js";
import AppChromeController from "./appChromeController.js";
import NotificationController from "./notificationController.js";
import { getSidebarLoadingMarkup } from "../sidebarLoading.js";
import { isWatchHistoryDebugEnabled } from "../watchHistoryDebug.js";
import { splitAndZap as splitAndZapDefault } from "../payments/zapSplit.js";
@@ -706,13 +707,19 @@ export default class ApplicationBootstrap {
app.forYouLink = null;
app.exploreLink = null;
app.notificationPortal = doc?.getElementById("notificationPortal") || null;
app.errorContainer = doc?.getElementById("errorContainer") || null;
app.successContainer = doc?.getElementById("successContainer") || null;
app.statusContainer = doc?.getElementById("statusContainer") || null;
app.statusMessage =
app.statusContainer?.querySelector("[data-status-message]") || null;
app.statusAutoHideHandle = null;
app.notificationController = new NotificationController({
portal: doc?.getElementById("notificationPortal") || null,
errorContainer: doc?.getElementById("errorContainer") || null,
successContainer: doc?.getElementById("successContainer") || null,
statusContainer: doc?.getElementById("statusContainer") || null,
loggers: {
userLogger,
devLogger,
},
documentRef: doc,
windowRef: this.window,
});
app.lastExperimentalWarningKey = null;
app.lastExperimentalWarningAt = 0;