[constants] refactor duplicate numeric constants

- Add `UI_FEEDBACK_DELAY_MS`, `DEBOUNCE_DELAY_MS`, and `NETWORK_RETRY_DELAY_MS` to `js/constants.js`.
- Replace magic numbers (5000, 2000, 1500) with semantic constants in:
  - `js/ui/notificationController.js`
  - `js/ui/profileModal/ProfileDirectMessageActions.js`
  - `js/ui/urlHealthController.js`
  - `js/app/uiCoordinator.js`
  - `js/ui/components/VideoModal.js`
  - `js/ui/components/UploadModal.js`
  - `js/services/dmNostrService.js`
  - `js/services/hashtagPreferencesService.js`
  - `js/app/feedCoordinator.js`
  - `js/services/moderationService.js`

Co-authored-by: PR0M3TH3AN <[email protected]>

js/ui/components/UploadModal.js

@@ -23,6 +23,7 @@ import {
   getActiveSigner,
   requestDefaultExtensionPermissions,
 } from "../../nostrClientFacade.js";
+import { UI_FEEDBACK_DELAY_MS } from "../../constants.js";
 
 const INFO_HASH_PATTERN = /^[a-f0-9]{40}$/;
 
@@ -790,7 +791,7 @@ export class UploadModal {
               if (this.thumbnailUploadId === currentUploadId) {
                   this.sourceSections.thumbnailProgress.classList.add("hidden");
               }
-          }, 2000);
+          }, UI_FEEDBACK_DELAY_MS);
 
       } catch (err) {
           if (this.thumbnailUploadId !== currentUploadId) return;

js/ui/components/VideoModal.js

@@ -47,6 +47,7 @@ import {
   subscribeToLinkPreviewSettings,
 } from "../../utils/linkPreviewSettings.js";
 import { HEX64_REGEX } from "../../utils/hex.js";
+import { UI_FEEDBACK_DELAY_MS } from "../../constants.js";
 
 
 const SIMILAR_CONTENT_LIMIT = 10;
@@ -1534,7 +1535,7 @@ export class VideoModal {
       if (button.dataset.feedbackTimeoutId) {
         delete button.dataset.feedbackTimeoutId;
       }
-    }, 2000);
+    }, UI_FEEDBACK_DELAY_MS);
 
     button.dataset.feedbackTimeoutId = String(nextId);
   }

js/ui/notificationController.js

@@ -1,4 +1,5 @@
 import { userLogger as _fallbackUserLogger, devLogger as _fallbackDevLogger } from "../utils/logger.js";
+import { SHORT_TIMEOUT_MS } from "../constants.js";
 
 export default class NotificationController {
   constructor({
@@ -98,7 +99,7 @@ export default class NotificationController {
         container.textContent = "";
         container.classList.add("hidden");
         this.updateNotificationPortalVisibility();
-      }, 5000);
+      }, SHORT_TIMEOUT_MS);
     }
   }
 
@@ -236,7 +237,7 @@ export default class NotificationController {
         container.textContent = "";
         container.classList.add("hidden");
         this.updateNotificationPortalVisibility();
-      }, 5000);
+      }, SHORT_TIMEOUT_MS);
     }
   }
 

js/ui/profileModal/ProfileDirectMessageActions.js

@@ -3,6 +3,7 @@ import { extractAttachmentsFromMessage, formatAttachmentSize, describeAttachment
 import { downloadAttachment, clearAttachmentCache, getAttachmentCacheStats } from "../../services/attachmentService.js";
 import { getLinkPreviewSettings, setLinkPreviewAutoFetch } from "../../utils/linkPreviewSettings.js";
 import { sanitizeRelayList } from "../../nostr/nip46Client.js";
+import { SHORT_TIMEOUT_MS } from "../../constants.js";
 
 const TYPING_INDICATOR_TTL_SECONDS = 15;
 const TYPING_INDICATOR_COOLDOWN_MS = 4000;
@@ -118,7 +119,7 @@ export class ProfileDirectMessageActions {
     if (this.controller.enableNip17RelayWarning && enabled && !relayHints.length) {
       this.mainController.showStatus(
         "Privacy warning: this recipient has not shared NIP-17 relays, so we'll use your default relays.",
-        { autoHideMs: 5000 },
+        { autoHideMs: SHORT_TIMEOUT_MS },
       );
     }
 
@@ -207,7 +208,7 @@ export class ProfileDirectMessageActions {
     if (this.controller.enableNip17RelayWarning && useNip17 && !recipientRelayHints.length) {
       this.mainController.showStatus(
         "Privacy warning: this recipient has not shared NIP-17 relays, so we'll use your default relays.",
-        { autoHideMs: 5000 },
+        { autoHideMs: SHORT_TIMEOUT_MS },
       );
     }
 
@@ -263,7 +264,7 @@ export class ProfileDirectMessageActions {
         if (this.controller.enableNip17RelayWarning && result?.warning === "dm-relays-fallback") {
           this.mainController.showStatus(
             "Privacy warning: this message used default relays because no NIP-17 relay list was found.",
-            { autoHideMs: 5000 },
+            { autoHideMs: SHORT_TIMEOUT_MS },
           );
         }
         void this.populateProfileMessages({ force: true, reason: "send-message" });
@@ -494,7 +495,7 @@ export class ProfileDirectMessageActions {
     if (useNip17 && !recipientRelayHints.length) {
       this.mainController.showStatus(
         "Privacy warning: this recipient has not shared NIP-17 relays, so we'll use your default relays.",
-        { autoHideMs: 5000 },
+        { autoHideMs: SHORT_TIMEOUT_MS },
       );
     }
 
@@ -523,7 +524,7 @@ export class ProfileDirectMessageActions {
         if (result?.warning === "dm-relays-fallback") {
           this.mainController.showStatus(
             "Privacy warning: this message used default relays because no NIP-17 relay list was found.",
-            { autoHideMs: 5000 },
+            { autoHideMs: SHORT_TIMEOUT_MS },
           );
         }
         if (
@@ -804,7 +805,7 @@ export class ProfileDirectMessageActions {
 
     this.mainController.showStatus(
       "Privacy warning: direct messages are using your default relays because no NIP-17 relay list is available.",
-      { autoHideMs: 5000 },
+      { autoHideMs: SHORT_TIMEOUT_MS },
     );
   }
 

js/ui/urlHealthController.js

@@ -1,3 +1,5 @@
+import { SHORT_TIMEOUT_MS } from "../constants.js";
+
 export default class UrlHealthController {
   constructor({
     state = {},
@@ -249,7 +251,7 @@ export default class UrlHealthController {
   }
 
   async probeUrlWithVideoElement(url, timeoutMs) {
-    const defaultTimeout = this.constants.URL_PROBE_TIMEOUT_MS || 5000;
+    const defaultTimeout = this.constants.URL_PROBE_TIMEOUT_MS || SHORT_TIMEOUT_MS;
     const effectiveTimeout =
       Number.isFinite(timeoutMs) && timeoutMs > 0 ? timeoutMs : defaultTimeout;
 
@@ -346,7 +348,7 @@ export default class UrlHealthController {
     }
 
     const confirmPlayable = options?.confirmPlayable === true;
-    const defaultTimeout = this.constants.URL_PROBE_TIMEOUT_MS || 5000;
+    const defaultTimeout = this.constants.URL_PROBE_TIMEOUT_MS || SHORT_TIMEOUT_MS;
     const urlHealthConstants = this.constants.urlHealthConstants || {};
 
     const confirmWithVideoElement = async () => {