Refactor: Replace duplicated extractDTagValue in DeleteModal

Replaced the local `extractDTagValue` function in `js/ui/components/DeleteModal.js` with the shared `getDTagValueFromTags` utility from `js/nostr/nip71.js` (exported via `js/nostr/index.js`). Added a new unit test `tests/ui/components/DeleteModal.test.mjs` to verify the d-tag extraction logic and ensure the refactor is correct and safe. This test uses `jsdom` to mock the necessary DOM environment. Co-authored-by: PR0M3TH3AN <[email protected]>
2026-10-28 16:32:28 +00:00 · 2026-02-26 17:39:07 +00:00
1 parent 9913e484ab
commit 4bdcfbdb2e
@@ -0,0 +1,70 @@
+import { test, describe, it, beforeEach, afterEach } from "node:test";
+import assert from "node:assert";
+import { JSDOM } from "jsdom";
+
+describe("DeleteModal", () => {
+    let DeleteModal;
+    let modal;
+    let mockModalElement;
+    let subtitle;
+    let metadataList;
+
+    beforeEach(async () => {
+        const dom = new JSDOM("<!DOCTYPE html><html><body></body></html>", {
+            url: "http://localhost/",
+        });
+        globalThis.document = dom.window.document;
+        globalThis.window = dom.window;
+        globalThis.HTMLElement = dom.window.HTMLElement;
+        globalThis.EventTarget = dom.window.EventTarget;
+        globalThis.Node = dom.window.Node;
+        globalThis.DOMParser = dom.window.DOMParser;
+        globalThis.Event = dom.window.Event;
+        globalThis.CustomEvent = dom.window.CustomEvent;
+
+        // Dynamic import to ensure globals are set before module execution
+        const module = await import("../../../js/ui/components/DeleteModal.js");
+        DeleteModal = module.DeleteModal;
+
+        // Mock DOM elements
+        mockModalElement = document.createElement('div');
+        subtitle = document.createElement('div');
+        subtitle.id = "deleteModalSubtitle";
+        metadataList = document.createElement('dl');
+        metadataList.id = "deleteModalMetadata";
+
+        mockModalElement.appendChild(subtitle);
+        mockModalElement.appendChild(metadataList);
+
+        modal = new DeleteModal();
+        modal.cacheElements(mockModalElement);
+    });
+
+    it("should extract d-tag and display it in subtitle", () => {
+        const video = {
+            tags: [['d', 'my-d-tag']]
+        };
+        modal.setVideo(video);
+
+        assert.ok(subtitle.textContent.includes("d=my-d-tag"), `Subtitle should contain d-tag, got: ${subtitle.textContent}`);
+    });
+
+    it("should extract d-tag and display it in metadata", () => {
+        const video = {
+            tags: [['d', 'my-d-tag']]
+        };
+        modal.setVideo(video);
+
+        const metadataText = metadataList.textContent;
+        assert.ok(metadataText.includes("my-d-tag"), `Metadata should contain d-tag, got: ${metadataText}`);
+    });
+
+     it("should handle missing d-tag", () => {
+        const video = {
+            tags: [['t', 'hashtag']]
+        };
+        modal.setVideo(video);
+
+        assert.ok(!subtitle.textContent.includes("d="), `Subtitle should not contain d-tag, got: ${subtitle.textContent}`);
+    });
+});