thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-11-06 12:52:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): prevent automated-pr-review from failing the workflow

Browse Source 
The `automated-pr-review` script was throwing an error when lint or test failures were found, causing the GitHub Action job to fail.
However, the purpose of this script is to provide feedback via a PR comment, not to block the pipeline (other jobs handle blocking).
This change updates the script to log the failure but exit successfully (0), ensuring the review comment is always delivered.

Co-authored-by: PR0M3TH3AN <[email protected]>
This commit is contained in:
google-labs-jules[bot]andPR0M3TH3AN committed 2026-02-10 06:59:04 +00:00
1 parent b993acc09c
commit 4f193e28a4
3 files changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

scripts/automated-pr-review.mjs
+3 -1
View File
@@ -247,7 +247,9 @@ async function reviewPR(prNumber, baseRef) {
console.log('---------------------------------------------------');
if (hasFailures) {
throw new Error('Lint or Test failures detected.');
console.log('Lint or Test failures detected. Reported to PR.');
// Do not throw error here, as we want the workflow to "pass" so that the comment persists
// and the developer can see the feedback. The actual build job (separate) will fail the PR checks.
}
}