thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-10-27 07:52:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: close stale innerHTML TODO — ShareNostrModal has no innerHTML left

Browse Source 
Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LHH3wPBsoruwCaJo8Rpf6a
This commit is contained in:
thePR0M3TH3ANandClaude Fable 5 committed 2026-07-30 11:45:23 -04:00
1 parent 975b996f4c
commit 5cce3b726a
1 file changed
+9 -3
Download Patch File Download Diff File Expand all files Collapse all files
todo/TODO_2026-02-20_innerhtml.md
+9 -3
View File
@@ -1,8 +1,14 @@
# TODO: innerHTML Migration for ShareNostrModal.js # TODO: innerHTML Migration for ShareNostrModal.js
- [ ] L107: `wrapper.innerHTML = html;` (Template loading) - [x] L107: `wrapper.innerHTML = html;` (Template loading)
- Strategy: Use `new DOMParser().parseFromString(html, 'text/html')` and append children to `wrapper`. - Strategy: Use `new DOMParser().parseFromString(html, 'text/html')` and append children to `wrapper`.
- [ ] L274: `this.relayPills.innerHTML = "";` (Clearing content) - [x] L274: `this.relayPills.innerHTML = "";` (Clearing content)
- Strategy: `this.relayPills.replaceChildren();` or `textContent = ""` (replaceChildren is preferred for performance). - Strategy: `this.relayPills.replaceChildren();` or `textContent = ""` (replaceChildren is preferred for performance).
- [ ] L300: `removeButton.innerHTML = '<svg ...>...</svg>';` (SVG Icon) - [x] L300: `removeButton.innerHTML = '<svg ...>...</svg>';` (SVG Icon)
- Strategy: Create SVG elements using `document.createElementNS("http://www.w3.org/2000/svg", "svg")` and children. - Strategy: Create SVG elements using `document.createElementNS("http://www.w3.org/2000/svg", "svg")` and children.
---
**CLOSED 2026-07-30.** All three migrations already landed in later refactors —
`grep innerHTML js/ui/components/ShareNostrModal.js` returns nothing and the
innerHTML lint baseline holds. Kept for the record.