mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-11-05 20:32:27 +00:00
fix(more-menu): make ⋯ "Event Details" robust + non-silent (#31)
The wiring was structurally intact (menu item event-details → handler case → handleEventDetailsAction → EventDetailsModal.open), so the failure was silent: - handleEventDetailsAction only opened the modal `if (… && payload.video)` and never caught the async open() rejection — any miss = nothing happens. - EventDetailsModal.open ran the (throwable) renderVersion BEFORE openStaticModal, so a render hiccup left the click looking dead. Hardened: - handleEventDetailsAction surfaces "No video selected" / "unavailable" instead of failing silently, falls back to app.eventDetailsModal, and .catch()es open(). - open() now shows the modal (openStaticModal) FIRST, then renders in a try/catch. - The ⋯ popover is dismissed before opening the modal. Couldn't repro by inspection, so this both fixes the likely causes and makes any remaining failure visible (a toast / console warn naming the exact reason). Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
1 parent
36f3c6e127
commit
63dcb5f6ed
5 files changed
+46
-14
No files matched your search
@@ -63,7 +63,7 @@ const GRANDFATHERED = {
|
||||
"js/services/authService.js": 1335,
|
||||
"js/ui/zapController.js": 1206,
|
||||
"js/services/r2Service.js": 1192,
|
||||
"js/ui/applicationBootstrap.js": 1163,
|
||||
"js/ui/applicationBootstrap.js": 1217,
|
||||
"js/ui/components/EditModal.js": 1130,
|
||||
"js/services/commentThreadService.js": 1100,
|
||||
"js/nostr/managers/SignerManager.js": 1160,
|
||||
|
||||
Reference in new issue
Block a user