docs(agents): fix behavioral defects in agent prompts (P2)

- Remove AI generation artifacts (:contentReference) from
  docs-code-investigator (4 occurrences)
- Fix require() -> import in event-schema-agent example
  (project uses ES modules)
- Clarify nonexistent script reference in const-refactor-agent
  (scripts/find-numeric-literals.js must be created, not assumed)
- Close truncated code blocks and add TODO notices in interop-agent
  and smoke-agent (both missing Failure Modes and Outputs sections)

No agent mission changes.

https://claude.ai/code/session_01Nz6FJopPp2YHEscJrRAFNv
This commit is contained in:
Claude committed 2026-02-12 20:42:22 +00:00
1 parent c96982f469
commit 6a79cb52c5
5 files changed
+18 -7

No files matched your search

@@ -60,8 +60,8 @@ DETAILED WORKFLOW (step-by-step)
```
- (Adjust regex to include more candidates you want.)
- For a more robust approach, run an AST scan (Node/ES module) to find numeric literals:
- If comfortable, use `node` + `acorn` or `@babel/parser` script `scripts/find-numeric-literals.js` to produce JSON output of numeric literals with file, line, column, and nearby AST context (identifier or property name).
- Example (conceptual):
- If comfortable, use `node` + `acorn` or `@babel/parser` to create a script (e.g., `scripts/find-numeric-literals.js`) that produces JSON output of numeric literals with file, line, column, and nearby AST context (identifier or property name).
- Example (conceptual — script must be created first):
```
node scripts/find-numeric-literals.js js > perf/constants-refactor/numeric-literals.json
```
@@ -6,11 +6,11 @@ This document is your operating manual. Follow it exactly for every file you doc
===============================================================================
WHY / SCOPE / PRIORITY
- Why: The project prefers moving complex UI logic into controllers and keeping `js/app.js` thin. Large or understudied files (especially under `js/nostr/*`, `js/services/*`, or `js/app.js`) carry the most maintenance risk and highest documentation value. See `AGENTS.md` on "bitvidApp vs. UI Controllers". :contentReference[oaicite:0]{index=0}
- Why: The project prefers moving complex UI logic into controllers and keeping `js/app.js` thin. Large or understudied files (especially under `js/nostr/*`, `js/services/*`, or `js/app.js`) carry the most maintenance risk and highest documentation value. See `AGENTS.md` on "bitvidApp vs. UI Controllers".
- Scope:
- Target JS files under `js/` — prefer `js/nostr/*`, `js/services/*`, `js/app.js`, or large controllers.
- Focus on files > ~200 LOC, or files that contain `TODO|FIXME|XXX`.
- Priority: files containing `TODO|FIXME|XXX` or >200 lines. Nostr helpers and signaling modules are high-value places to document. :contentReference[oaicite:1]{index=1}
- Priority: files containing `TODO|FIXME|XXX` or >200 lines. Nostr helpers and signaling modules are high-value places to document.
===============================================================================
HARD CONSTRAINTS & GUARDRAILS
@@ -134,7 +134,7 @@ TESTS & QA (must run before PR)
npm run test:unit
```
- If `package.json` exposes a test script, run that exact command (see `package.json`). :contentReference[oaicite:3]{index=3}
- If `package.json` exposes a test script, run that exact command (see `package.json`).
- If linting is enforced, run linter:
```
@@ -227,7 +227,7 @@ OUTPUTS & ACCEPTANCE
===============================================================================
FINAL NOTES
- Be explicit about the reasons and the invariants — future contributors rely on these docs.
- If you propose moving logic to controllers, include a short extraction plan referencing `AGENTS.md` refactor checklist. :contentReference[oaicite:2]{index=2}
- If you propose moving logic to controllers, include a short extraction plan referencing `AGENTS.md` refactor checklist.
- If you find cryptographic issues, stop and open `requires-security-review`.
- Keep edits minimal and focused: documentation, examples, and safe comments only.
@@ -68,7 +68,7 @@ WORKFLOW
- Responsibilities:
- Import canonical APIs:
```js
const { getNostrEventSchema, buildVideoPostEvent, sanitizeAdditionalTags, /* ... */ } = require('../../js/nostrEventSchemas.js');
import { getNostrEventSchema, buildVideoPostEvent, sanitizeAdditionalTags, /* ... */ } from '../../js/nostrEventSchemas.js';
```
- Provide a configurable set of example inputs for each builder.
- For each builder:
@@ -137,3 +137,8 @@ EXAMPLE RUN (illustrative)
# required:
RELAY_URLS="wss://relay.test.example" node scripts/agent/interop-test.mjs \
--burst=3 --timeout=30 --out=artifacts/interop-2025-07-14.json
```
<!-- TODO: This prompt appears to be truncated. The following sections are
missing and should be added: FAILURE MODES, OUTPUTS PER RUN, BEGIN.
See https://github.com/PR0M3TH3AN/bitvid/issues for tracking. -->
@@ -155,3 +155,9 @@ RELAY_URLS="ws://localhost:8080" node scripts/agent/smoke-test.mjs \
# public relays only with explicit confirmation and extreme throttle
RELAY_URLS="wss://relay.example" node scripts/agent/smoke-test.mjs \
--confirm-public --burst=1 --timeout=30 --out=artifacts/
```
<!-- TODO: This prompt appears to be truncated. The following sections are
missing and should be added: FAILURE MODES, PR & COMMIT CONVENTIONS,
OUTPUTS PER RUN, BEGIN.
See https://github.com/PR0M3TH3AN/bitvid/issues for tracking. -->