Commit Graph
30 Commits
Author SHA1 Message Date
thePR0M3TH3ANandClaude Opus 4.8 47f2a9a865 [nostr] Fix spurious "failed" errors on unconfirmed list publishes across the board
Same class of bug as the subscription fix, applied everywhere an idempotent,
replaceable list is published with an optimistic UI: when no relay ACKs within the
10s window (slow/flaky relays), the event was still sent and almost always
persists (it shows up after a refresh), but assertAnyRelayAccepted threw -> the UI
showed a scary error / reverted, even though it worked.

- nostrPublish.js: add shared helpers relayPublishFailuresAreAllTimeouts() and
  assertAnyRelayAcceptedOrUnconfirmed() — the latter returns a summary flagged
  { unconfirmed: true } on all-timeout instead of throwing; explicit relay
  rejections (and pre-publish signer/encryption errors) still throw.
- Applied to the replaceable-list publishes: subscriptions (kind 30000, refactored
  to the shared helper), user mute/block list (10000), relay list (10002), DM
  relay hints (10050), hashtag preferences (30015).

Left as-is for now (higher-stakes, separate follow-up): the generic content
publish path (video/edit/delete/revert/rebroadcast) in publishHelpers/client.js —
same latent issue but the video outcome-describer needs careful handling.

Tests: tests/subscription-publish-timeout.test.mjs (8) now cover both the
classifier and assertAnyRelayAcceptedOrUnconfirmed (confirmed->summary,
all-timeout->soft, rejection->throws). hashtag-preferences suite green (14).

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-07-01 15:20:58 -04:00
thePR0M3TH3AN 59faf39a19 update 2026-02-22 15:56:05 -05:00
thePR0M3TH3AN 820a810ee4 Merge branch 'unstable' into agents/weekly/race-condition-2026-02-22-4789629545643517997 2026-02-22 15:51:22 -05:00
thePR0M3TH3AN b65ad21901 Merge pull request #2672 from PR0M3TH3AN/agents/daily/prompt-curator-agent-2026-02-22-2018433635480124911
docs(agents): prompt curation run 2026-02-22
2026-02-22 15:51:03 -05:00
google-labs-jules[bot]andPR0M3TH3AN 94c59fe838 fix(ci): restore relay isolation and fix build job failure
- Restore `getTestRelayOverrides` logic in `js/relayManager.js` to ensure E2E tests use local mock relays instead of failing on production relays.
- Restrict `test:visual` script in `package.json` to only run the `visual` project, preventing it from executing E2E tests in the `build` job where Firefox/Webkit are missing.
- Verified fix by confirming `getTestRelayOverrides` is used in `RelayPreferencesManager` constructor.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-22 18:45:07 +00:00
google-labs-jules[bot]andPR0M3TH3AN e6f5ef253f fix(relayManager): robust check for window.location in getTestRelayOverrides
- Fixes a unit test regression where `getTestRelayOverrides` crashed in Node.js environments (where `window` exists but `window.location` is undefined).
- Updated the check to explicitly verify `window.location` before accessing `.search`.
- Verified via `npm run test:unit:shard2`.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-22 17:27:48 +00:00
google-labs-jules[bot]andPR0M3TH3AN e79b2500c8 fix(ci): install firefox in e2e-headless and fix e2e test isolation
- Updated `.github/workflows/ci.yml` to install both chromium and firefox in `e2e-headless` job, resolving missing executable errors.
- Updated `js/relayManager.js` to respect `__testRelays__` overrides (via URL/localStorage) during initialization, preventing race conditions where tests fell back to production relays.
- Updated `tests/e2e/repro_issue.spec.ts` to use dynamic relay ports based on worker index, preventing `EADDRINUSE` errors in parallel runs.
- Updated `scripts/check-hex.js` to ignore `docs/agents/task-logs/**` to prevent lint failures on hex strings in log files.
- Executed `prompt-curator-agent` daily task to fix broken paths in prompt library.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-22 17:09:11 +00:00
google-labs-jules[bot]andPR0M3TH3AN e9ca94e89d test(e2e): stabilize login/feed tests and isolate relays (agent)
- Updated `tests/e2e/helpers/bitvidTestFixture.ts` to inject `__bitvidTestRelays__` into `localStorage` and `window` for reliable isolation.
- Updated `js/relayManager.js` to respect test relays in both `loadFromStorage` and defaults construction, preventing production fallback on profile load.
- Updated `tests/e2e/login-flows.spec.ts` to click the "nsec" provider button before assertions.
- Updated `tests/e2e/feed-pagination-stress.spec.ts` to correctly query title attributes.
- Added `scripts/check-hex.js` fix for log files.
- Added onboarding audit log.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-22 15:31:09 +00:00
google-labs-jules[bot]andPR0M3TH3AN 106f7640c4 fix(exploreData): trigger refresh immediately on visibility change
- `handleVisibility` only scheduled intervals but didn't trigger an immediate refresh when returning to the tab.
- This caused `tests/unit/services/exploreDataService.test.mjs` to fail (assertion `0 !== 1`).
- Added explicit calls to `refreshWatchHistoryTagCounts` and `refreshTagIdf` when `document.hidden` becomes false.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-18 15:10:29 +00:00
google-labs-jules[bot]andPR0M3TH3AN 9d159ae0a7 perf: fix unbounded relay concurrency
Identified and fixed unbounded concurrency in js/relayManager.js during relay list hydration. Uses pMap with RELAY_BACKGROUND_CONCURRENCY (3).

Daily perf agent run 2026-02-17.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-17 13:53:29 +00:00
google-labs-jules[bot]andPR0M3TH3AN 504f4dc90f Refactor: Remove unused imports in relayManager.js
- Removed unused `NOTE_TYPES` from `nostrEventSchemas.js` import.
- Removed unused `CACHE_POLICIES` and `STORAGE_TIERS` imports from `nostr/cachePolicies.js`.
- Verified with targeted tests and lint checks.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-17 04:45:13 +00:00
Claude 53b8a2609c fix: recognize NIP-07 signer type for extension permission pre-granting
The NIP-07 adapter uses type "nip07" but all permission pre-granting
checks only matched type "extension", causing NIP-07 browser extension
users to fail decryption for block/mute lists, subscriptions, DMs, and
watch history. Hashtag preferences appeared to work because their read
path had a separate fix, masking the systemic issue.

Changes:
- shouldRequestExtensionPermissions() now matches both "extension" and
  "nip07" signer types (central fix affecting DM signals, comments,
  publish helpers, and watch history fetch)
- buildDmDecryptContext() pre-grants extension permissions for NIP-07
- userBlocks.js: remove capabilities-gated decryptor check that failed
  with lazy NIP-07 module injection (same fix already in subscriptions.js);
  always resolve signer regardless of allowPermissionPrompt; increase
  fast-path relay timeout from 6s to 10s
- watchHistoryService: recognize NIP-07 type and always resolve signer
- All publish paths (blocks, subscriptions, hashtags, relays, uploads,
  sharing, moderation) now pre-grant permissions for NIP-07 signers

https://claude.ai/code/session_01PipsdaTQmw7wBTJ1LmJjkk
2026-02-11 19:41:53 +00:00
thePR0M3TH3AN c3e986c9d3 Improve relay hygiene and count status 2026-01-29 09:58:35 -05:00
google-labs-jules[bot] 4a0b81ad98 chore(ai): remove dead code (unused exports & deps) 2026-01-24 20:28:53 +00:00
google-labs-jules[bot] 926e6ebf39 Refactor user-specific lists to use centralized profileCache 2026-01-17 20:47:27 +00:00
google-labs-jules[bot] 86ffb8cb2a Define centralized cache policies and wire them into fetchers 2026-01-17 19:12:09 +00:00
thePR0M3TH3AN 9ed0fae127 refactor: route nostr imports through facades 2025-10-22 22:40:17 -04:00
thePR0M3TH3AN 5536180682 refactor: centralize nostr client bootstrap 2025-10-22 21:09:18 -04:00
thePR0M3TH3AN 75ea73b178 Refactor Nostr client imports 2025-10-22 20:55:54 -04:00
thePR0M3TH3AN 23482808b6 refactor: extract nostr toolkit helpers 2025-10-22 10:42:49 -04:00
thePR0M3TH3AN 578d2ddde4 Refactor Nostr signer integration 2025-10-21 15:13:48 -04:00
thePR0M3TH3AN d7405883d2 Ensure subscription publishing targets configured write relays 2025-10-20 22:59:29 -04:00
thePR0M3TH3AN deffbf7670 Ensure NIP-07 permissions are granted before signing and encrypting 2025-10-15 22:36:57 -04:00
thePR0M3TH3AN 0a2a2c4e78 Fix syntax errors blocking app bootstrap 2025-10-15 15:08:55 -04:00
thePR0M3TH3AN 7ae07b1369 refactor: migrate console usage to shared loggers 2025-10-15 14:37:25 -04:00
thePR0M3TH3AN d705cf176b Revert "Refactor logging to centralized logger" 2025-10-15 11:14:10 -04:00
thePR0M3TH3AN 37ba57aa37 Refactor logging to centralized logger 2025-10-15 11:11:14 -04:00
thePR0M3TH3AN 77fa149cc3 Speed up profile and relay fetches 2025-10-09 18:55:18 -04:00
thePR0M3TH3AN 92cc05f1f6 Refactor relay publish acknowledgements 2025-10-02 08:00:21 -04:00
thePR0M3TH3AN 9f2e06744c Add relay list management for profile relays 2025-10-01 14:13:11 -04:00