- Updates `.github/workflows/ci.yml` to install `firefox` for the `e2e-headless` job, resolving the "Executable doesn't exist" error.
- Updates `js/app.js` to make `_initAccessControl` async (returning a Promise) and adds a 15-second timeout safeguard. This ensures the app waits for ACLs to load (fixing the race condition) but doesn't hang indefinitely if the network is slow or unresponsive (fixing E2E timeouts).
Co-authored-by: PR0M3TH3AN <[email protected]>
Explicitly injects the GITHUB_TOKEN into the upstream remote URL in the agent-pr-review workflow. This prevents authentication failures when fetching the upstream repository in CI environments where plain HTTPS URLs trigger interactive credential prompts.
Co-authored-by: PR0M3TH3AN <[email protected]>
- Add docs/capacitor-native-app-plan.md to hex-lint ignore list (code examples
naturally reference hex colors in Capacitor config)
- Replace direct console.error/console.log calls with logger utility in
historyView.js, profileCache.js, EventDetailsModal.js, ZapInterface.js,
and notificationController.js
- Update CI workflow from Node 20 to Node 22 to match package.json engines
https://claude.ai/code/session_01LzErpH9FNw4hAPsjoYb1v9
Replaces `git rev-parse` with `git ls-remote` to verify the existence of the upstream base branch before attempting to fetch and diff. This prevents workflow failures when the PR targets a branch that does not exist on the upstream remote (e.g. `unstable` or other feature branches), gracefully skipping the diff step with a warning instead.
Co-authored-by: PR0M3TH3AN <[email protected]>
Updates the `agent-pr-review.yml` workflow to prevent failures when calculating diffs against the upstream repository.
Changes:
- Reverts `git fetch` to a full fetch to ensure all remote-tracking branches (like `refs/remotes/upstream/unstable`) are correctly updated in the local environment.
- Adds a mandatory `Verify upstream branch and diff` step that checks for the existence of the target base branch (`upstream/${{ github.base_ref }}`) using `git rev-parse`.
- Performs a dry-run `git diff` to confirm connectivity before running the main review script.
- Ensures the job fails explicitly with a clear error message if the upstream branch is missing, rather than crashing later with an obscure exit code 1.
Co-authored-by: PR0M3TH3AN <[email protected]>
- Add `scripts/automated-pr-review.mjs` to run format, lint, tests, and security checks.
- Add `.github/workflows/agent-pr-review.yml` to trigger the review on PRs.
- Script flags sensitive file changes (crypto/storage) and posts comments.
- Script attempts to commit formatting micro-fixes if permissions allow.
