Commit Graph
1048 Commits
Author SHA1 Message Date
thePR0M3TH3AN 98e1181783 Merge branch 'unstable' into security-fix-qrcode-innerhtml-16143867429725848701 2026-02-26 14:42:34 -05:00
thePR0M3TH3AN 475e1f71f1 Merge branch 'unstable' into refactor/delete-modal-dtag-extraction-9801703157260752806 2026-02-26 14:41:48 -05:00
thePR0M3TH3AN 7b1ac9903a Merge branch 'unstable' into refactor/revert-modal-nip71-d-tag-2158505577819364487 2026-02-26 14:41:24 -05:00
thePR0M3TH3AN b74e2df01c Merge pull request #2731 from PR0M3TH3AN/test/link-preview-settings-coverage-2904834955738247686
test: Add tests for LinkPreviewSettings utility
2026-02-26 14:40:53 -05:00
thePR0M3TH3AN 9453a40c82 Merge branch 'unstable' into test/comment-avatar-7190109823382715625 2026-02-26 14:39:15 -05:00
thePR0M3TH3AN 19d3e0dfbd Merge pull request #2736 from PR0M3TH3AN/update-watch-history-test-items-15094903720553574923
Update watch history test to use aggregated items
2026-02-26 13:04:27 -05:00
thePR0M3TH3AN de80e58b5d Merge pull request #2725 from PR0M3TH3AN/refactor-delete-modal-dtag-919037621417068012
Refactor DeleteModal to use shared getDTagValueFromTags utility
2026-02-26 13:04:19 -05:00
thePR0M3TH3AN 0e5e56b146 Merge branch 'unstable' into refactor-revert-modal-dtag-18208308647871133769 2026-02-26 13:04:04 -05:00
thePR0M3TH3AN ecdea6ac94 Merge pull request #2724 from PR0M3TH3AN/test/link-preview-settings-coverage-13742612794998658634
test: Add unit tests for linkPreviewSettings.js
2026-02-26 13:03:45 -05:00
thePR0M3TH3AN 143dcf771d Merge pull request #2727 from PR0M3TH3AN/test/video-menu-renderers-15090243999919330255
🧪 Add tests for video menu renderers
2026-02-26 13:02:53 -05:00
thePR0M3TH3AN 73f7540b4e Merge pull request #2730 from PR0M3TH3AN/security-fix-qrcode-innerhtml-10127011832917430140
🔒 Fix unsafe innerHTML usage in qrcode.js
2026-02-26 13:02:46 -05:00
thePR0M3TH3AN c7cbe086bc Merge pull request #2728 from PR0M3TH3AN/test/static-modal-accessibility-13129271747123339314
🧪 Add tests for staticModalAccessibility.js
2026-02-26 13:02:39 -05:00
thePR0M3TH3AN f536c71917 Merge pull request #2721 from PR0M3TH3AN/test/comment-avatar-16584237555601496118
Add unit tests for commentAvatar.js
2026-02-26 13:02:25 -05:00
google-labs-jules[bot]andPR0M3TH3AN 311e14c66c test(watch-history): rely on aggregated items from publishRecords
Updated `tests/watch-history.test.mjs` to consume `snapshotResult.items` directly, as `WatchHistoryManager`'s `publishRecords` correctly returns aggregated items. Removed the fallback logic and TODO comment that suggested otherwise.

This cleanup aligns the test with the current implementation of `WatchHistoryManager` which flattens monthly results into a top-level `items` array.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 18:02:18 +00:00
thePR0M3TH3AN c28d1e2c2b Merge pull request #2734 from PR0M3TH3AN/refactor/revert-modal-rendering-15253432646628070109
Refactor RevertModal rendering logic
2026-02-26 13:00:38 -05:00
google-labs-jules[bot]andPR0M3TH3AN 2703382ab4 Refactor RevertModal rendering logic into separate module
Extracted excessive DOM rendering logic from `RevertModal.js` into `revertModalRenderers.js`.
This improves code readability and maintainability by separating the view construction from the modal logic.
Added unit tests for the new renderers using a lightweight DOM mock.
Replaced local d-tag extraction with shared utility `getDTagValueFromTags`.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:50:10 +00:00
google-labs-jules[bot]andPR0M3TH3AN 56ffdb693d Refactor decryptLegacyDm to use ordered parallel race for decryptors.
Replaces Promise.any with raceOrdered utility to respect decryptor preference order while maintaining parallel execution.
Adds regression test for order preference.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:45:31 +00:00
google-labs-jules[bot]andPR0M3TH3AN fd5e6fef6b test: add missing tests for LinkPreviewSettings utility
- Refactor `tests/utils/linkPreviewSettings.test.mjs` to be self-contained and remove dependency on `jsdom` (via `test-setup.mjs`).
- Add comprehensive test cases for `getLinkPreviewSettings`, `setLinkPreviewAutoFetch`, `allowLinkPreviewDomain`, `isLinkPreviewDomainAllowed`, and `subscribeToLinkPreviewSettings`.
- Add robustness checks for missing `localStorage` (simulated) and invalid inputs.
- Polyfill `EventTarget` and `CustomEvent` (as fallback) to ensure tests run reliably in environments where `jsdom` is unavailable.

This addresses the gap in testing coverage for `js/utils/linkPreviewSettings.js` while ensuring test stability.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:44:51 +00:00
google-labs-jules[bot]andPR0M3TH3AN e2835603c5 Refactor js/utils/qrcode.js to replace innerHTML with DOM manipulation
- Replaced `innerHTML` usage in `Drawing.prototype.draw` (table fallback) with `document.createElement`, `appendChild`, etc.
- Replaced `innerHTML` usage in `Drawing.prototype.clear` with `removeChild` loop.
- Added `tests/qrcode_table_fallback.test.mjs` to verify the table generation logic in a simulated environment (JSDOM) without Canvas support.
- Updated `package.json` to include `jsdom` in `devDependencies` (if it wasn't already there and committed, though I verified it is present after install).

This change eliminates the potential for HTML injection vulnerabilities in the QR code generation library.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:42:43 +00:00
google-labs-jules[bot]andPR0M3TH3AN 0fcfc6009f Refactor qrcode.js to use DOM methods instead of innerHTML
- Replaces unsafe innerHTML usage with document.createElement and appendChild in the table drawing fallback.
- Adds a unit test `tests/qrcode_table_fallback.test.mjs` to verify the table generation logic using JSDOM.
- Addresses a potential security vulnerability where HTML injection could occur (though unlikely in this specific context, it is best practice).
- Updates package.json to include jsdom in devDependencies (if not already present).

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:42:28 +00:00
google-labs-jules[bot]andPR0M3TH3AN 7ec726aad1 Add tests for staticModalAccessibility.js
- Create `tests/static-modal-accessibility.test.mjs` to test `prepareStaticModal`, `openStaticModal`, and `closeStaticModal`.
- Tests cover element resolution, DOM state updates (classes, attributes), and edge cases (missing elements, null targets).
- Use `jsdom` to mock the browser environment.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:42:07 +00:00
google-labs-jules[bot]andPR0M3TH3AN e95355fdb0 Add unit tests for video menu renderers
- Created `tests/video-menu-renderers.test.mjs` to test `js/ui/components/videoMenuRenderers.js`.
- Implemented comprehensive test coverage for `createVideoMoreMenuPanel`, `createVideoShareMenuPanel`, `createChannelProfileMenuPanel`, and `createVideoSettingsMenuPanel`.
- Tests use `jsdom` to simulate DOM element creation and verify structure, classes, and dataset attributes.
- Ensured dependencies (`jsdom`) are installed.
- Verified tests pass with `npm run test:unit`.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:41:34 +00:00
google-labs-jules[bot]andPR0M3TH3AN 822ba4d478 Refactor DeleteModal to use shared getDTagValueFromTags
Replaced the local `extractDTagValue` function in `js/ui/components/DeleteModal.js` with the shared `getDTagValueFromTags` utility from `js/nostr/nip71.js` to reduce code duplication and improve maintainability.

Added `tests/ui/components/DeleteModal.test.mjs` with manual DOM mocks to verify the refactor and ensure no regressions.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:39:38 +00:00
google-labs-jules[bot]andPR0M3TH3AN 4bdcfbdb2e Refactor: Replace duplicated extractDTagValue in DeleteModal
Replaced the local `extractDTagValue` function in `js/ui/components/DeleteModal.js` with the shared `getDTagValueFromTags` utility from `js/nostr/nip71.js` (exported via `js/nostr/index.js`).

Added a new unit test `tests/ui/components/DeleteModal.test.mjs` to verify the d-tag extraction logic and ensure the refactor is correct and safe. This test uses `jsdom` to mock the necessary DOM environment.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:39:07 +00:00
google-labs-jules[bot]andPR0M3TH3AN c4fc0cdb16 test: Add unit tests for linkPreviewSettings.js
- Added comprehensive tests for default settings, storage parsing, and error handling.
- Covered `setLinkPreviewAutoFetch` and `allowLinkPreviewDomain` (including normalization and silent mode).
- Verified `isLinkPreviewDomainAllowed` and event subscriptions.
- Mocked `window.dispatchEvent`, `addEventListener`, and `CustomEvent` locally as they are missing from test helpers.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:38:30 +00:00
google-labs-jules[bot]andPR0M3TH3AN 931f57eebe Refactor RevertModal to use shared d-tag extraction utility
- Removed duplicated `extractDTagValue` method from `js/ui/components/RevertModal.js`
- Imported and used `getDTagValueFromTags` from `js/nostr/nip71.js`
- Added unit tests for `getDTagValueFromTags` in `tests/nostr/nip71-d-tag.test.mjs`

This reduces code duplication and ensures consistent d-tag extraction logic.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:37:26 +00:00
google-labs-jules[bot]andPR0M3TH3AN 30fbb8d81a Refactor RevertModal to use shared nip71.getDTagValueFromTags
Replaced the duplicated `extractDTagValue` method in `RevertModal.js` with the standard `getDTagValueFromTags` utility from `js/nostr/nip71.js`.

Verified by adding a new unit test suite `tests/nostr/nip71-d-tag.test.mjs` ensuring the utility covers all edge cases.

This improves code health by reducing duplication and centralizing NIP-71 logic.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:36:43 +00:00
google-labs-jules[bot]andPR0M3TH3AN b1b797a12b Add unit tests for commentAvatar.js utility functions
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:36:00 +00:00
google-labs-jules[bot]andPR0M3TH3AN 2eec105545 Add tests for commentAvatar.js utility functions
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-26 17:33:09 +00:00
google-labs-jules[bot]andPR0M3TH3AN b8cf1315e1 fix(test): add wait for logout state in login-flows e2e
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-25 16:11:48 +00:00
thePR0M3TH3AN 10148d043f Merge pull request #2707 from PR0M3TH3AN/agents/weekly/test-coverage-agent-5998265445794573406
Add unit tests for js/nostr/utils.js (test-coverage-agent)
2026-02-24 21:59:55 -05:00
google-labs-jules[bot]andPR0M3TH3AN 6058b632ba test(ai): add unit tests for js/nostr/utils.js (test-coverage-agent)
Added focused unit tests for `getActiveKey` in `js/nostr/utils.js` to improve test coverage.
This module was identified as having 0% coverage.
The new tests cover all branches:
- ROOT key generation
- pubkey:d key generation
- LEGACY key fallback
- Handling of missing/empty tags

Artifacts:
- tests/nostr/utils.test.mjs
- docs/agents/task-logs/weekly/2026-02-25_test-coverage-agent_completed.md

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-25 01:32:06 +00:00
google-labs-jules[bot]andPR0M3TH3AN 881e31a661 chore(ai): CI health fixes (flaky tests)
Fixed flaky test in tests/hashtag-preferences.test.mjs caused by mock timing issue where load() triggered concurrent fetches, breaking the assumption of sequential calls. Updated assertions to robustly handle multi-kind fetching.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-24 20:51:19 +00:00
thePR0M3TH3AN 812bfb03d6 [ci] stabilize flaky e2e assertions and non-secret deploy checks 2026-02-23 09:21:15 -05:00
thePR0M3TH3AN 3f4316f64e Merge pull request #2681 from PR0M3TH3AN/agents/weekly/refactor-agent-2026-02-23-8774352260885712650
refactor(ui): extract bindThumbnailFallbacks from app.js
2026-02-23 07:13:32 -05:00
thePR0M3TH3AN 22fb4cbd0a Merge pull request #2679 from PR0M3TH3AN/agents/daily/style-agent-2026-02-22-3871995359379843897
Daily Scheduler: style-agent execution
2026-02-23 07:12:38 -05:00
thePR0M3TH3AN 3dbacd20cc fix(sync): emit settled list state for hashtags and blocks with regression tests 2026-02-22 21:09:08 -05:00
thePR0M3TH3AN c23dcc6c46 [e2e] Improve runtime coverage and fix logout coordinator call 2026-02-22 20:44:31 -05:00
google-labs-jules[bot]andPR0M3TH3AN fd1bbfd978 refactor(ui): extract bindThumbnailFallbacks and update visual baselines
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-23 01:37:45 +00:00
google-labs-jules[bot]andPR0M3TH3AN 4a5099d745 refactor(ui): extract bindThumbnailFallbacks from app.js
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-23 01:16:32 +00:00
thePR0M3TH3AN 0af7de6c07 [ui] Fix DM tab blank shell and harden profile modal tests 2026-02-22 20:14:32 -05:00
thePR0M3TH3AN ee8569a99b update 2026-02-22 19:21:28 -05:00
google-labs-jules[bot]andPR0M3TH3AN 81c0fc67db fix(ci): resolve e2e and visual test failures
- Fix race condition in UploadModal.js by making open() await load()
- Stabilize notification-system.spec.ts by waiting for app initialization
- Update visual test baselines for default theme
- Complete scheduled style-agent task

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-23 00:19:48 +00:00
thePR0M3TH3AN 8adaee87db [testing] add high-impact Playwright coverage for theme, notifications, history, and edit/delete flows 2026-02-22 17:33:26 -05:00
thePR0M3TH3ANandClaude Opus 4.6 e925562bfe test(e2e): add engagement, CRUD, and navigation coverage
Add 3 new Playwright E2E spec files (31 tests each across 2 browsers):

- video-engagement.spec.ts: reaction buttons, comment composer,
  reaction meter, count labels, empty state
- video-crud-flows.spec.ts: settings menu, edit modal open/close/form,
  delete modal confirm/cancel/warning
- view-navigation.spec.ts: sidebar links, login-gated visibility,
  hash routing, sidebar collapse/expand, feed persistence

Raises E2E function coverage from 38.6% to 40.6%.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
2026-02-22 17:10:05 -05:00
thePR0M3TH3AN 0866af2e39 test(e2e): harden modal flows and expand runtime coverage 2026-02-22 16:34:19 -05:00
thePR0M3TH3AN 5f1e3c8fe2 test(visual): refresh kitchen-sink baselines for CI 2026-02-22 16:08:17 -05:00
thePR0M3TH3AN 820a810ee4 Merge branch 'unstable' into agents/weekly/race-condition-2026-02-22-4789629545643517997 2026-02-22 15:51:22 -05:00
thePR0M3TH3AN b65ad21901 Merge pull request #2672 from PR0M3TH3AN/agents/daily/prompt-curator-agent-2026-02-22-2018433635480124911
docs(agents): prompt curation run 2026-02-22
2026-02-22 15:51:03 -05:00
thePR0M3TH3AN a95343e471 Merge branch 'unstable' into agents/daily/prompt-curator-agent-2026-02-22-2018433635480124911 2026-02-22 15:41:30 -05:00