Files
bitvid/js/channelProfileVideos.js
thePR0M3TH3ANandClaude Opus 4.8 f05ba5edf9 channel: union live fetch with known events so the grid never shrinks
loadUserVideos rendered only the live relay fetch, and the render REPLACES the
grid container. So when a relay holding a creator's video transiently failed or
EOSE'd late, that video disappeared from the wall even though it was already
known in memory/cache — the "channel doesn't pull in all of a creator's videos"
bug (#20, symptom 1).

Union the live events with the already-known author events
(mergeChannelVideoSources, live wins on id collision) before building the
renderable list, so the rendered set is a superset and can't shrink on a
transient relay gap. Existing dedupe-by-root + access/delete filtering still
decide precedence downstream, so newer versions and deletions still win.

Helper + tests live in channelProfileVideos.js (channelProfile.js is at its
size cap); the call site stays net-zero. Streaming/first-relay-wins render is
still the separate 17d UX follow-up.

Regression: tests/channel-video-merge.test.mjs.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-06-24 08:19:37 -04:00

113 lines
4.5 KiB
JavaScript

// Channel-profile video sourcing: a creator's wall should show BOTH their
// bitvid-native kind-30078 videos AND the NIP-71 videos they published via other
// apps (Nostube etc.) — matching what the main feed shows via ingest. Previously
// the profile fetched only kind-30078, so cross-posted NIP-71 videos were absent.
import { convertEventToVideo as sharedConvertEventToVideo } from "./nostr/index.js";
import { buildVideoFromNip71Event, NIP71_KINDS } from "./nostr/nip71IngestAdapter.js";
// Two filters for one author: native video notes (kind 30078, tagged "video")
// and their NIP-71 videos (kinds 21/22/34235/34236).
export function buildChannelVideoFilters(pubkey, { limit = 200 } = {}) {
return [
{ kinds: [30078], authors: [pubkey], "#t": ["video"], limit },
{ kinds: Array.from(NIP71_KINDS), authors: [pubkey], limit },
];
}
// Convert a raw channel event to a bitvid video object. Foreign NIP-71 kinds go
// through the ingest adapter (which also rejects bitvid's own outbound mirrors so
// they don't duplicate the canonical kind-30078 note); everything else uses the
// standard kind-30078 converter. May return an { invalid: true } object — the
// caller filters those out (same contract as convertEventToVideo).
export function convertChannelEvent(entry) {
const kind = Number(entry?.kind);
if (NIP71_KINDS.has(kind)) {
return buildVideoFromNip71Event(entry);
}
return sharedConvertEventToVideo(entry);
}
// Reconcile a fresh live fetch with already-known events (the in-memory video
// store + persisted cache) so a transiently-failing relay can't SHRINK the grid.
// The channel render replaces the container with the live set, so rendering only
// what this load fetched drops any video whose sole relay timed out — the "some
// of a creator's videos are missing" bug. Union the two by event id (live wins on
// collision since it's the freshest copy); the caller's dedupe-by-root + access
// checks still handle versioning, deletes, and precedence downstream.
export function mergeChannelVideoSources(liveEvents, knownEvents) {
const byId = new Map();
const extras = [];
const add = (list) => {
if (!Array.isArray(list)) return;
for (const entry of list) {
if (!entry || typeof entry !== "object") continue;
const id = typeof entry.id === "string" ? entry.id : "";
if (!id) {
extras.push(entry);
continue;
}
if (!byId.has(id)) byId.set(id, entry);
}
};
add(liveEvents); // live first → wins on id collision
add(knownEvents);
return [...byId.values(), ...extras];
}
// ---- Per-channel persisted cache (instant cold-load paint) -------------------
// Mirrors the main feed's optimistic cache: on a cold hard-refresh of a profile,
// render the last-seen videos from localStorage BEFORE relays connect, then the
// live fetch replaces them. Keyed per author; bounded so storage can't grow
// without limit.
const CHANNEL_CACHE_KEY = "bitvid:channel-videos:v1";
const MAX_CACHED_CHANNELS = 20;
const MAX_VIDEOS_PER_CHANNEL = 60;
function normPubkey(pubkey) {
return typeof pubkey === "string" ? pubkey.trim().toLowerCase() : "";
}
function readChannelCacheMap() {
try {
if (typeof localStorage === "undefined") return {};
const raw = localStorage.getItem(CHANNEL_CACHE_KEY);
const parsed = raw ? JSON.parse(raw) : {};
return parsed && typeof parsed === "object" ? parsed : {};
} catch (error) {
return {};
}
}
export function loadCachedChannelVideos(pubkey) {
const pk = normPubkey(pubkey);
if (!pk) return [];
const entry = readChannelCacheMap()[pk];
return entry && Array.isArray(entry.videos) ? entry.videos : [];
}
export function saveCachedChannelVideos(pubkey, videos) {
const pk = normPubkey(pubkey);
if (!pk || !Array.isArray(videos) || typeof localStorage === "undefined") {
return;
}
try {
const map = readChannelCacheMap();
// Drop the heavy raw `tags` array — the render + dedupe paths use parsed
// top-level fields; the live fetch restores full objects moments later.
const slim = videos.slice(0, MAX_VIDEOS_PER_CHANNEL).map(({ tags, ...rest }) => rest);
map[pk] = { videos: slim, ts: Date.now() };
const keys = Object.keys(map);
if (keys.length > MAX_CACHED_CHANNELS) {
keys
.sort((a, b) => (map[a]?.ts || 0) - (map[b]?.ts || 0))
.slice(0, keys.length - MAX_CACHED_CHANNELS)
.forEach((k) => delete map[k]);
}
localStorage.setItem(CHANNEL_CACHE_KEY, JSON.stringify(map));
} catch (error) {
// best-effort; cache is non-critical
}
}