bitvid/tests/hashtag-preferences.test.mjs

import test from "node:test";
import assert from "node:assert/strict";
import { waitFor } from "./test-helpers/wait-for.mjs";

const hashtagPreferencesModule = await import(
  "../js/services/hashtagPreferencesService.js"
);
const hashtagPreferences = hashtagPreferencesModule.default;
const [{ nostrClient }, { setActiveSigner, clearActiveSigner }] =
  await Promise.all([
    import("../js/nostrClientFacade.js"),
    import("../js/nostr/client.js"),
  ]);
const { relayManager } = await import("../js/relayManager.js");

if (typeof globalThis.window === "undefined") {
  globalThis.window = {};
}

const originalPool = nostrClient.pool;
const originalRelays = Array.isArray(nostrClient.relays)
  ? [...nostrClient.relays]
  : nostrClient.relays;
const originalWriteRelays = Array.isArray(nostrClient.writeRelays)
  ? [...nostrClient.writeRelays]
  : nostrClient.writeRelays;
const originalRelayEntries = relayManager.getEntries();
const originalWindowNostr = window.nostr;

function restoreNostrClient() {
  nostrClient.pool = originalPool;
  nostrClient.relays = Array.isArray(originalRelays)
    ? [...originalRelays]
    : originalRelays;
  nostrClient.writeRelays = Array.isArray(originalWriteRelays)
    ? [...originalWriteRelays]
    : originalWriteRelays;
}

function restoreRelayManager() {
  relayManager.setEntries(originalRelayEntries, { allowEmpty: true, updateClient: false });
}

test.beforeEach(async () => {
  hashtagPreferences.reset();
  restoreNostrClient();
  restoreRelayManager();
  window.nostr = originalWindowNostr;

  // Setup default mock signer to prevent auto-save errors
  setActiveSigner({
    signEvent: async (e) => ({ ...e, id: "fake" }),
    nip44Encrypt: async () => "encrypted",
    nip04Encrypt: async () => "encrypted",
  });

  // Setup default pool mock for publish and list
  nostrClient.pool = {
    list: async () => [],
    publish: (urls, event) => ({
      on: (eventName, handler) => {
        if (eventName === "ok") {
          setTimeout(() => handler(), 0);
        }
        return true;
      },
    }),
  };

  // Ensure writeRelays are set
  nostrClient.writeRelays = ["wss://mock.relay"];

  // Ensure active pubkey is set for publish operations
  await hashtagPreferences.load("0".repeat(64));

  if (nostrClient.extensionPermissionCache) {
    nostrClient.extensionPermissionCache.clear();
  }
});

test.after(() => {
  restoreNostrClient();
  restoreRelayManager();
  window.nostr = originalWindowNostr;
  clearActiveSigner();
  setTimeout(() => process.exit(0), 100);
});

test(
  "load decrypts nip44 payloads and normalizes tags",
  { concurrency: false },
  async (t) => {
    const pubkey = "a".repeat(64);
    const decryptCalls = [];

    setActiveSigner({
      nip44Decrypt: async (target, ciphertext) => {
        decryptCalls.push({ target, ciphertext });
        return JSON.stringify({
          version: 1,
          interests: ["TagOne", "  #TagTwo  "],
          disinterests: ["TagThree"],
        });
      },
    });

    nostrClient.pool = {
      async list(relays, filters) {
        assert.deepEqual(relays, ["wss://relay.one"]);
        assert.equal(filters.length, 1);
        // Note: fetchListIncrementally calls pool.list separately for each kind
        const kind = filters[0].kinds[0];
        assert.ok([30015, 30005].includes(kind));
        assert.equal(filters[0]["#d"][0], "bitvid:tag-preferences");

        // Return event only for canonical kind to verify logic picks it up
        if (kind === 30015) {
          return [
            {
              id: "evt1",
              created_at: 100,
              pubkey,
              content: "ciphertext",
              tags: [["encrypted", "nip44_v2"]],
            },
          ];
        }
        return [];
      },
    };
    nostrClient.relays = ["wss://relay.one"];
    nostrClient.writeRelays = ["wss://relay.one"];
    relayManager.setEntries([{ url: "wss://relay.one", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);

    assert.deepEqual(hashtagPreferences.getInterests(), ["tagone", "tagtwo"]);
    assert.deepEqual(hashtagPreferences.getDisinterests(), ["tagthree"]);
    assert.equal(decryptCalls.length, 1);
    assert.equal(decryptCalls[0].target, pubkey);
  },
);

test(
  "load falls back to nip04 decryption",
  { concurrency: false },
  async () => {
    const pubkey = "b".repeat(64);

    setActiveSigner({
      nip04Decrypt: async () =>
        JSON.stringify({
          version: 1,
          interests: ["Alpha"],
          disinterests: ["alpha", "Beta"],
        }),
    });

    nostrClient.pool = {
      async list() {
        return [
          {
            id: "evt2",
            created_at: 200,
            pubkey,
            content: "legacycipher",
            tags: [["encrypted", "nip04"]],
          },
        ];
      },
    };
    nostrClient.relays = ["wss://relay.two"];
    nostrClient.writeRelays = ["wss://relay.two"];
    relayManager.setEntries([{ url: "wss://relay.two", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);

    assert.deepEqual(hashtagPreferences.getInterests(), []);
    assert.deepEqual(hashtagPreferences.getDisinterests(), ["alpha", "beta"]);
  },
);

// Spec correction (was "load retries decryptors when hinted scheme fails"):
// the old test stubbed an impossible scenario — the SAME ciphertext decrypting
// under nip04 after nip44 "failed". A real NIP-04 payload (carrying "?iv=") can
// only be decrypted by nip04, and a NIP-44 payload only by nip44, so the other
// family never succeeds on a given ciphertext. Decryption now routes by the
// ciphertext format and does NOT race the non-matching family — which also
// avoids a wasted published RPC under a NIP-46 remote signer. This asserts the
// real contract: the ciphertext format wins even over a misleading `encrypted`
// tag, and only the matching decryptor is invoked.
test(
  "load routes decryption by ciphertext format (ignores a misleading tag)",
  { concurrency: false },
  async () => {
    const pubkey = "d".repeat(64);
    const attempts = [];

    setActiveSigner({
      nip44Decrypt: async () => {
        attempts.push("nip44");
        throw new Error("nip44 must not be attempted for a nip04 (?iv=) payload");
      },
      nip04Decrypt: async () => {
        attempts.push("nip04");
        return JSON.stringify({
          version: 1,
          interests: ["Retry"],
          disinterests: [],
        });
      },
    });

    nostrClient.pool = {
      async list() {
        return [
          {
            id: "evt-retry",
            created_at: 300,
            pubkey,
            // NIP-04 ciphertext format ("?iv=") but a misleading "nip44" tag.
            content: "deadbeefdeadbeef?iv=cafebabecafebabe",
            tags: [["encrypted", "nip44"]],
          },
        ];
      },
    };
    nostrClient.relays = ["wss://relay.retry"];
    nostrClient.writeRelays = ["wss://relay.retry"];
    relayManager.setEntries([{ url: "wss://relay.retry", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);

    // Only nip04 is tried — the "?iv=" format overrides the misleading tag, and
    // nip44 is never invoked (no wasted attempt / wasted NIP-46 RPC).
    assert.deepEqual(attempts, ["nip04"]);
    assert.deepEqual(hashtagPreferences.getInterests(), ["retry"]);
    assert.deepEqual(hashtagPreferences.getDisinterests(), []);
  },
);

test(
  "load defers permission-required decrypts until explicitly enabled",
  { concurrency: false },
  async () => {
    const pubkey = "e".repeat(64);

    const relayUrls = ["wss://relay-permissions.example"];
    const originalRelayEntries = relayManager.getEntries();
    relayManager.setEntries(relayUrls.map(url => ({ url, mode: "both" })), { allowEmpty: false, updateClient: false });

    const originalFetchIncremental = nostrClient.fetchListIncrementally;
    const originalRelays = Array.isArray(nostrClient.relays)
      ? [...nostrClient.relays]
      : nostrClient.relays;
    const originalWriteRelays = Array.isArray(nostrClient.writeRelays)
      ? [...nostrClient.writeRelays]
      : nostrClient.writeRelays;
    const originalWindowNostr = window.nostr;

    let fetchCalls = 0;

    const event = {
      id: "pref-permission",
      created_at: 400,
      pubkey,
      content: "cipher-permission",
      tags: [["encrypted", "nip04"]],
    };

    fetchCalls = 0;
    nostrClient.fetchListIncrementally = async () => {
      fetchCalls += 1;
      return fetchCalls <= 4 ? [event] : [];
    };
    nostrClient.relays = relayUrls;
    nostrClient.writeRelays = relayUrls;

    const decryptCalls = [];
    const permissionState = { enabled: false };

    // Create a mock window.nostr that properly simulates extension behavior.
    // Specifically, enable() needs to exist so nostrClient detects it as an extension.
    window.nostr = {
      enable: async () => {},
      getPublicKey: async () => pubkey,
      nip04: {
        decrypt: async () => {
          if (!permissionState.enabled) throw new Error("permission denied");
          decryptCalls.push("nip04");
          return JSON.stringify({
            version: 1,
            interests: ["Late"],
            disinterests: [],
          });
        },
      },
    };

    clearActiveSigner();

    try {
      await hashtagPreferences.load(pubkey, { allowPermissionPrompt: false });

      assert.equal(
        decryptCalls.length,
        0,
        "decryption should be skipped when permissions are deferred",
      );
      assert.equal(
        hashtagPreferences.lastLoadError?.code,
        "hashtag-preferences-permission-required",
        "permission-required errors should be captured for deferred prompts",
      );
      assert.deepEqual(hashtagPreferences.getInterests(), []);

      permissionState.enabled = true;
      await hashtagPreferences.load(pubkey, { allowPermissionPrompt: true });

      await waitFor(() => {
        assert.equal(
          decryptCalls.length,
          1,
          "explicit permission prompts should retry decryption",
        );
        assert.deepEqual(hashtagPreferences.getInterests(), ["late"]);
      });
    } finally {
      relayManager.setEntries(originalRelayEntries, { allowEmpty: true, updateClient: false });
      nostrClient.fetchListIncrementally = originalFetchIncremental;
      nostrClient.relays = originalRelays;
      nostrClient.writeRelays = originalWriteRelays;
      window.nostr = originalWindowNostr;
    }
  },
);

test(
  "load emits load-settled with readiness metadata for empty relay results",
  { concurrency: false },
  async () => {
    const pubkey = "1".repeat(64);
    const changes = [];
    const unsubscribe = hashtagPreferences.on("change", (detail) => {
      changes.push(detail);
    });

    const originalFetchIncremental = nostrClient.fetchListIncrementally;
    try {
      relayManager.setEntries(
        [{ url: "wss://relay.empty", mode: "both" }],
        { allowEmpty: false, updateClient: false },
      );
      nostrClient.fetchListIncrementally = async () => [];

      await hashtagPreferences.load(pubkey);

      const settled = changes.filter((entry) => entry?.action === "load-settled");
      assert.ok(settled.length >= 1, "load should emit a final load-settled event");

      const final = settled[settled.length - 1];
      assert.equal(final.activePubkey, pubkey);
      assert.equal(final.uiReady, true);
      assert.equal(final.dataReady, true);
      assert.equal(final.loaded, true);
      assert.equal(final.loadedFromCache, false);
      assert.equal(final.lastLoadError, null);
      assert.deepEqual(final.interests, []);
      assert.deepEqual(final.disinterests, []);
    } finally {
      unsubscribe();
      nostrClient.fetchListIncrementally = originalFetchIncremental;
    }
  },
);

test(
  "load emits load-settled with permission-required metadata when decrypt is deferred",
  { concurrency: false },
  async () => {
    const pubkey = "2".repeat(64);
    const changes = [];
    const unsubscribe = hashtagPreferences.on("change", (detail) => {
      changes.push(detail);
    });

    const originalFetchIncremental = nostrClient.fetchListIncrementally;
    const originalWindowNostr = window.nostr;
    const relayUrls = ["wss://relay.permission-metadata"];

    try {
      relayManager.setEntries(
        relayUrls.map((url) => ({ url, mode: "both" })),
        { allowEmpty: false, updateClient: false },
      );
      nostrClient.relays = relayUrls;
      nostrClient.writeRelays = relayUrls;
      nostrClient.fetchListIncrementally = async () => [
        {
          id: "pref-permission-metadata",
          created_at: 401,
          pubkey,
          content: "cipher-permission-metadata",
          tags: [["encrypted", "nip04"]],
        },
      ];

      window.nostr = {
        enable: async () => {},
        getPublicKey: async () => pubkey,
        nip04: {
          decrypt: async () => {
            throw new Error("permission denied");
          },
        },
      };
      clearActiveSigner();

      await hashtagPreferences.load(pubkey, { allowPermissionPrompt: false });

      const settled = changes.filter((entry) => entry?.action === "load-settled");
      assert.ok(settled.length >= 1, "load should emit load-settled even on deferred decrypt");

      const final = settled[settled.length - 1];
      assert.equal(final.activePubkey, pubkey);
      assert.equal(final.uiReady, true);
      assert.equal(typeof final.dataReady, "boolean");
      assert.equal(final.dataReady, hashtagPreferences.dataReady === true);
      assert.equal(typeof final.loaded, "boolean");
      assert.equal(final.loaded, hashtagPreferences.loaded === true);
      assert.equal(final.lastLoadError?.code, "hashtag-preferences-permission-required");
    } finally {
      unsubscribe();
      nostrClient.fetchListIncrementally = originalFetchIncremental;
      window.nostr = originalWindowNostr;
    }
  },
);

test(
  "load emits load-settled with loadedFromCache when relay fetch is unavailable",
  { concurrency: false },
  async () => {
    const pubkey = "3".repeat(64);
    const originalPool = nostrClient.pool;
    const originalLoadFromCache = hashtagPreferences.loadFromCache;
    const originalInterests = hashtagPreferences.interests;
    const originalDisinterests = hashtagPreferences.disinterests;
    const originalEventId = hashtagPreferences.eventId;
    const originalEventCreatedAt = hashtagPreferences.eventCreatedAt;
    const originalLoaded = hashtagPreferences.loaded;
    const originalUiReady = hashtagPreferences.uiReady;
    const originalDataReady = hashtagPreferences.dataReady;
    const originalLoadedFromCache = hashtagPreferences.loadedFromCache;
    const originalLastSuccessfulSyncAt = hashtagPreferences.lastSuccessfulSyncAt;
    const originalPreferencesVersion = hashtagPreferences.preferencesVersion;

    try {
      hashtagPreferences.loadFromCache = (candidate) => {
        if (candidate !== pubkey) {
          return false;
        }
        hashtagPreferences.activePubkey = candidate;
        hashtagPreferences.interests = new Set(["cachepref"]);
        hashtagPreferences.disinterests = new Set();
        hashtagPreferences.eventId = "cache-event";
        hashtagPreferences.eventCreatedAt = 777;
        hashtagPreferences.loaded = true;
        hashtagPreferences.uiReady = true;
        hashtagPreferences.dataReady = true;
        hashtagPreferences.loadedFromCache = true;
        hashtagPreferences.lastSuccessfulSyncAt = 777000;
        hashtagPreferences.preferencesVersion = 1;
        hashtagPreferences.emitChange("cache-load");
        return true;
      };

      const changes = [];
      const unsubscribe = hashtagPreferences.on("change", (detail) => {
        changes.push(detail);
      });
      try {
        nostrClient.pool = null;
        await hashtagPreferences.load(pubkey, { allowPermissionPrompt: false });

        const settled = changes.filter((entry) => entry?.action === "load-settled");
        assert.ok(settled.length >= 1, "cache-backed load should emit load-settled");
        const final = settled[settled.length - 1];

        assert.equal(final.activePubkey, pubkey);
        assert.equal(final.loadedFromCache, true);
        assert.equal(final.dataReady, true);
        assert.equal(final.uiReady, true);
        assert.deepEqual(final.interests, ["cachepref"]);
      } finally {
        unsubscribe();
      }
    } finally {
      nostrClient.pool = originalPool;
      hashtagPreferences.loadFromCache = originalLoadFromCache;
      hashtagPreferences.interests = originalInterests;
      hashtagPreferences.disinterests = originalDisinterests;
      hashtagPreferences.eventId = originalEventId;
      hashtagPreferences.eventCreatedAt = originalEventCreatedAt;
      hashtagPreferences.loaded = originalLoaded;
      hashtagPreferences.uiReady = originalUiReady;
      hashtagPreferences.dataReady = originalDataReady;
      hashtagPreferences.loadedFromCache = originalLoadedFromCache;
      hashtagPreferences.lastSuccessfulSyncAt = originalLastSuccessfulSyncAt;
      hashtagPreferences.preferencesVersion = originalPreferencesVersion;
    }
  },
);

test(
  "interest and disinterest lists remain exclusive",
  { concurrency: false },
  async () => {
    hashtagPreferences.reset();

    assert.equal(await hashtagPreferences.addInterest("Focus"), true);
    assert.equal(await hashtagPreferences.addDisinterest("focus"), true);
    assert.deepEqual(hashtagPreferences.getInterests(), []);
    assert.deepEqual(hashtagPreferences.getDisinterests(), ["focus"]);

    assert.equal(await hashtagPreferences.removeDisinterest("focus"), true);
    assert.equal(hashtagPreferences.getDisinterests().length, 0);
    assert.equal(await hashtagPreferences.removeInterest("focus"), false);
  },
);

test(
  "publish encrypts payload and builds event via builder",
  { concurrency: false },
  async (t) => {
    const pubkey = "c".repeat(64);
    const plaintextCalls = [];

    setActiveSigner({
      nip44Encrypt: async (target, plaintext) => {
        plaintextCalls.push({ target, plaintext });
        return "ciphertext";
      },
      signEvent: async (event) => ({ ...event, id: "signed-event" }),
    });

    const publishedEvents = [];
    nostrClient.pool = {
      list: async () => [],
      publish(urls, event) {
        publishedEvents.push({ urls, event });
        return {
          on(eventName, handler) {
            if (eventName === "ok") {
              setImmediate(() => handler());
            }
            return true;
          },
        };
      },
    };
    nostrClient.relays = ["wss://relay.publish"];
    nostrClient.writeRelays = ["wss://relay.publish"];
    relayManager.setEntries([{ url: "wss://relay.publish", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);
    hashtagPreferences.addInterest("TagA");
    hashtagPreferences.addDisinterest("TagB");

    const signedEvent = await hashtagPreferences.publish();
    assert.equal(signedEvent.id, "signed-event");

    // Expect 3 calls: addInterest (auto-save), addDisinterest (auto-save), manual publish
    assert.equal(plaintextCalls.length, 3);
    const lastCall = plaintextCalls[plaintextCalls.length - 1];
    assert.equal(lastCall.target, pubkey);
    const payload = JSON.parse(lastCall.plaintext);
    assert.equal(payload.version, 1);
    assert.deepEqual(payload.interests, ["taga"]);
    assert.deepEqual(payload.disinterests, ["tagb"]);

    // Expect 3 publish events
    assert.equal(publishedEvents.length, 3);
    const publishedEvent = publishedEvents[publishedEvents.length - 1].event;
    assert.deepEqual(publishedEvents[publishedEvents.length - 1].urls, ["wss://relay.publish"]);
    assert.equal(publishedEvent.kind, 30015);
    const encryptedTag = publishedEvent.tags.find(
      (tag) => Array.isArray(tag) && tag[0] === "encrypted",
    );
    assert.ok(encryptedTag);
    assert.equal(encryptedTag[1], "nip44_v2");
  },
);

test(
  "publish falls back to window nostr encryptors",
  { concurrency: false },
  async () => {
    const pubkey = "e".repeat(64);
    const encryptCalls = [];

    // The service relies on the signer interface, so we mock the encryption methods on the signer directly.
    // The "fallback" logic is handled by the signer implementation (e.g. Nip07Signer) in the real app.
    setActiveSigner({
      type: "inpage",
      signEvent: async (event) => ({ ...event, id: "signed-window" }),
      nip44Encrypt: async (target, plaintext) => {
        // The service calls this for both nip44_v2 and nip44 schemes.
        // Since nip44_v2 is registered first, it will be called first.
        // We return success immediately, so loop breaks.
        encryptCalls.push({ scheme: "nip44_call", target, plaintext });
        return "cipher-from-window";
      },
      nip04Encrypt: async (target, plaintext) => {
         encryptCalls.push({ scheme: "nip04", target, plaintext });
         return "cipher-nip04";
      }
    });

    const publishedEvents = [];
    nostrClient.pool = {
      list: async () => [],
      publish(urls, event) {
        publishedEvents.push({ urls, event });
        return {
          on(eventName, handler) {
            if (eventName === "ok") {
              setImmediate(() => handler());
            }
            return true;
          },
        };
      },
    };
    nostrClient.relays = ["wss://relay.window"];
    nostrClient.writeRelays = ["wss://relay.window"];
    relayManager.setEntries([{ url: "wss://relay.window", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);
    hashtagPreferences.addInterest("WindowTag");

    const signedEvent = await hashtagPreferences.publish();

    assert.equal(signedEvent.id, "signed-window");
    // Expect 2 calls: addInterest (auto-save) + manual publish
    assert.equal(encryptCalls.length, 2);
    const lastEncryptCall = encryptCalls[encryptCalls.length - 1];
    assert.equal(lastEncryptCall.scheme, "nip44_call");
    assert.equal(lastEncryptCall.target, pubkey);
    assert.ok(lastEncryptCall.plaintext.includes("windowtag"));

    assert.equal(publishedEvents.length, 2);
    const lastPublished = publishedEvents[publishedEvents.length - 1];
    assert.deepEqual(lastPublished.urls, ["wss://relay.window"]);
    assert.equal(lastPublished.event.kind, 30015);
    const encryptedTag = lastPublished.event.tags.find(
      (tag) => Array.isArray(tag) && tag[0] === "encrypted",
    );
    // nip44_v2 is the first tried scheme, so it is the one used
    assert.equal(encryptedTag[1], "nip44_v2");
  },
);

test(
  "load prefers canonical kind when timestamps match while accepting legacy payload",
  { concurrency: false },
  async () => {
    const pubkey = "f".repeat(64);
    const decryptCalls = [];

    setActiveSigner({
      nip44Decrypt: async (target, ciphertext) => {
        decryptCalls.push({ target, ciphertext });
        if (ciphertext === "canonical-cipher") {
          return JSON.stringify({
            version: 2,
            interests: ["NewKind"],
            disinterests: [],
          });
        }
        if (ciphertext === "legacy-cipher") {
          return JSON.stringify({
            version: 1,
            interests: ["Legacy"],
            disinterests: [],
          });
        }
        throw new Error(`unexpected ciphertext: ${ciphertext}`);
      },
    });

    nostrClient.pool = {
      async list(relays, filters) {
        assert.deepEqual(relays, ["wss://relay.tie"]);
        const kind = filters[0].kinds[0];
        assert.ok([30015, 30005].includes(kind));

        if (kind === 30015) {
          return [
            {
              id: "evt-canonical",
              kind: 30015,
              created_at: 500,
              pubkey,
              content: "canonical-cipher",
              tags: [["encrypted", "nip44_v2"]],
            },
          ];
        }
        if (kind === 30005) {
          return [
            {
              id: "evt-legacy",
              kind: 30005,
              created_at: 500,
              pubkey,
              content: "legacy-cipher",
              tags: [["encrypted", "nip44_v2"]],
            },
          ];
        }
        return [];
      },
    };
    nostrClient.relays = ["wss://relay.tie"];
    nostrClient.writeRelays = ["wss://relay.tie"];
    relayManager.setEntries([{ url: "wss://relay.tie", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);

    assert.deepEqual(decryptCalls.map((call) => call.ciphertext), [
      "canonical-cipher",
    ]);
    assert.deepEqual(hashtagPreferences.getInterests(), ["newkind"]);

    nostrClient.pool.list = async () => [
      {
        id: "evt-legacy-only",
        kind: 30005,
        created_at: 600,
        pubkey,
        content: "legacy-cipher",
        tags: [["encrypted", "nip44_v2"]],
      },
    ];

    await hashtagPreferences.load(pubkey);

    assert.deepEqual(decryptCalls.map((call) => call.ciphertext), [
      "canonical-cipher",
      "legacy-cipher",
    ]);
    assert.deepEqual(hashtagPreferences.getInterests(), ["legacy"]);
  },
);

test(
  "load falls back to window.nostr when active signer is missing",
  { concurrency: false },
  async (t) => {
    const pubkey = "abcdef".repeat(10) + "1234";

    // Ensure no active signer (override beforeEach)
    clearActiveSigner();

    // Mock window.nostr
    window.nostr = {
        nip04: {
            decrypt: async (pk, ciphertext) => {
                if (pk !== pubkey) throw new Error("Wrong pubkey");
                if (ciphertext === "window-encrypted") {
                    return JSON.stringify({
                        version: 1,
                        interests: ["WindowSuccess"],
                        disinterests: []
                    });
                }
                throw new Error("Decrypt failed");
            }
        }
    };

    // Mock pool list to return an event
    nostrClient.pool = {
        list: async () => [{
            id: "evt1",
            created_at: 1000,
            pubkey,
            content: "window-encrypted",
            tags: [["encrypted", "nip04"]]
        }]
    };

    relayManager.setEntries([{ url: "wss://relay.fallback", mode: "both" }], { allowEmpty: false, updateClient: false });

    await hashtagPreferences.load(pubkey);

    assert.deepEqual(hashtagPreferences.getInterests(), ["windowsuccess"]);
  }
);

test(
    "load falls back to window.nostr when active signer lacks decrypt capabilities",
    { concurrency: false },
    async (t) => {
      const pubkey = "abcdef".repeat(10) + "5678";

      // Set a signer that can sign but NOT decrypt (override beforeEach)
      setActiveSigner({
          signEvent: async (e) => ({ ...e, id: "fake" }),
          // No nip04Decrypt or nip44Decrypt
      });

      // Mock window.nostr
      window.nostr = {
          nip04: {
              decrypt: async (pk, ciphertext) => {
                  if (pk !== pubkey) throw new Error("Wrong pubkey");
                  if (ciphertext === "window-encrypted-2") {
                      return JSON.stringify({
                          version: 1,
                          interests: ["SignerFallback"],
                          disinterests: []
                      });
                  }
                  throw new Error("Decrypt failed");
              }
          }
      };

      // Mock pool list to return an event
      nostrClient.pool = {
          list: async () => [{
              id: "evt2",
              created_at: 1000,
              pubkey,
              content: "window-encrypted-2",
              tags: [["encrypted", "nip04"]]
          }]
      };

      relayManager.setEntries([{ url: "wss://relay.fallback", mode: "both" }], { allowEmpty: false, updateClient: false });

      await hashtagPreferences.load(pubkey);

      assert.deepEqual(hashtagPreferences.getInterests(), ["signerfallback"]);
    }
  );

test(
  "load applies same-timestamp updates deterministically with overlap fetch",
  { concurrency: false },
  async () => {
    const pubkey = "c".repeat(64);
    const sinceCalls = [];
    let callCount = 0;
    const originalFetchIncremental = nostrClient.fetchListIncrementally;

    setActiveSigner({
      nip04Decrypt: async (_target, ciphertext) => {
        if (ciphertext === "cipher-new") {
          return JSON.stringify({
            version: 1,
            interests: ["newpref"],
            disinterests: [],
          });
        }
        return JSON.stringify({
          version: 1,
          interests: ["oldpref"],
          disinterests: [],
        });
      },
    });

    try {
      nostrClient.fetchListIncrementally = async (params = {}) => {
        sinceCalls.push(params.since);
        callCount += 1;
        const events = [
          {
            id: "0000",
            created_at: 1500,
            kind: 30015,
            pubkey,
            content: "cipher-old",
            tags: [["encrypted", "nip04"]],
          },
        ];
        if (params.since > 0) {
          events.push({
            id: "ffff",
            created_at: 1500,
            kind: 30015,
            pubkey,
            content: "cipher-new",
            tags: [["encrypted", "nip04"]],
          });
        }
        return events;
      };

      relayManager.setEntries(
        [{ url: "wss://relay.same-second", mode: "both" }],
        { allowEmpty: false, updateClient: false },
      );

      await hashtagPreferences.load(pubkey);
      assert.deepEqual(hashtagPreferences.getInterests(), ["oldpref"]);

      await hashtagPreferences.load(pubkey);
      assert.deepEqual(
        hashtagPreferences.getInterests(),
        ["newpref"],
        "newer same-second event should replace prior snapshot",
      );

      // Verify incremental fetch behavior.
      // Since load() may fetch multiple kinds concurrently, checking specific indices is unreliable.
      // Instead, verify that at least one call used the incremental since timestamp.
      const incrementalCalls = sinceCalls.filter((since) => since === 1499);
      assert.ok(incrementalCalls.length >= 1, "second fetch should include one-second overlap");
    } finally {
      nostrClient.fetchListIncrementally = originalFetchIncremental;
    }
  },
);