Files
bitvid/tests/video-modal-controllers.test.mjs
T
thePR0M3TH3ANandClaude Opus 4.8 a20388c5d6 [video-modal] Fix dead channel/creator link — event-name mismatch (#53)
Clicking the creator avatar/name in the video player modal did nothing. VideoModal
dispatched "navigate:profile", but ModalManager only listens for "creator:navigate"
(→ app.openCreatorChannel), so the event went into the void — same class as the old
action:embed bug noted just above the handler.

Fix:
- VideoModal.handleCreatorNavigation dispatches "creator:navigate" (the listened name)
  with { pubkey }.
- ModalManager's handler forwards event.detail.pubkey to app.openCreatorChannel.
- routerCoordinator.openCreatorChannel(pubkey) accepts an optional pubkey (prefers it,
  falls back to the active video's creator), so it navigates to the modal's own
  creator rather than whatever currentVideo happens to be.

Tests: tests/video-modal-controllers.test.mjs (+2 — dispatches creator:navigate with
the pubkey and never the dead navigate:profile; no-op without a pubkey). Lint + build green.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-07-02 08:51:10 -04:00

251 lines
7.6 KiB
JavaScript

import test from "node:test";
import assert from "node:assert/strict";
import { setupModal } from "./video-modal-accessibility.test.mjs";
test("CommentsController lifecycle manages comment references", async (t) => {
const { modal, cleanup } = await setupModal();
t.after(cleanup);
assert.ok(modal.commentsRoot, "comments should be initialized after hydrate");
modal.commentsController.destroy();
assert.equal(modal.commentsRoot, null, "destroy should clear comment root");
modal.commentsController.initialize({ playerModal: modal.getRoot() });
assert.ok(modal.commentsRoot, "initialize should restore comment root");
});
test("ReactionsController delegates reaction updates", async (t) => {
const { modal, cleanup } = await setupModal();
t.after(cleanup);
modal.reactionsController.update({ type: "set-user-reaction", reaction: "+" });
assert.equal(
modal.reactionState.userReaction,
"+",
"user reaction should be updated via controller",
);
modal.reactionsController.destroy();
assert.equal(
modal.reactionButtons["+"],
null,
"destroy should clear reaction button references",
);
});
test("SimilarContentController toggles section visibility", async (t) => {
const { modal, cleanup } = await setupModal();
t.after(cleanup);
const container = modal.similarContentContainer;
assert.ok(container, "similar content container should exist");
modal.similarContentController.update({ type: "set-visibility", visible: false });
assert.equal(
container.hasAttribute("hidden"),
true,
"controller should hide similar content when requested",
);
modal.similarContentController.update({ type: "set-visibility", visible: true });
assert.equal(
container.hasAttribute("hidden"),
false,
"controller should reveal similar content",
);
});
test("ModerationController reset clears moderation overlay references", async (t) => {
const { modal, cleanup } = await setupModal();
t.after(cleanup);
assert.ok(modal.moderationOverlay, "moderation overlay should be present");
modal.moderationController.destroy();
assert.equal(
modal.moderationOverlay,
null,
"destroy should clear moderation overlay references",
);
modal.moderationController.initialize({ playerModal: modal.getRoot() });
assert.ok(
modal.moderationOverlay,
"initialize should restore moderation overlay references",
);
});
test("VideoModal trims tag strip to fit modal width", async (t) => {
const { window, modal, cleanup } = await setupModal();
t.after(cleanup);
const root = modal.videoTagsRoot;
assert.ok(root, "tag container should be available after hydrate");
modal.setTagPreferenceStateResolver((tag) => {
if (tag === "#alpha") {
return "interest";
}
if (tag === "#beta") {
return "disinterest";
}
return "neutral";
});
let containerWidth = 180;
Object.defineProperty(root, "clientWidth", {
configurable: true,
get() {
return containerWidth;
},
});
root.getBoundingClientRect = () => ({ width: containerWidth });
const elementPrototype = window.HTMLElement.prototype;
const originalScrollWidthDescriptor =
Object.getOwnPropertyDescriptor(elementPrototype, "scrollWidth") || null;
Object.defineProperty(elementPrototype, "scrollWidth", {
configurable: true,
get() {
if (this.classList?.contains("video-tag-strip")) {
const buttonCount = this.querySelectorAll("button[data-tag]").length;
return buttonCount * 90;
}
if (originalScrollWidthDescriptor?.get) {
return originalScrollWidthDescriptor.get.call(this);
}
return 0;
},
});
t.after(() => {
if (originalScrollWidthDescriptor) {
Object.defineProperty(
elementPrototype,
"scrollWidth",
originalScrollWidthDescriptor,
);
} else {
delete elementPrototype.scrollWidth;
}
delete root.clientWidth;
delete root.getBoundingClientRect;
});
modal.renderVideoTags(["gamma", "beta", "delta", "alpha"]);
const trimmedButtons = [
...root.querySelectorAll("button[data-tag]"),
];
assert.equal(trimmedButtons.length, 2, "tag list should be trimmed to fit");
assert.deepEqual(
trimmedButtons.map((button) => button.dataset.tag),
["#alpha", "#beta"],
"leading tags should remain after trimming",
);
assert.equal(
trimmedButtons[0].dataset.preferenceState,
"interest",
"interest styling should persist on trimmed buttons",
);
assert.equal(
trimmedButtons[0].dataset.variant,
"success",
"interest variant token should remain on trimmed buttons",
);
assert.equal(
trimmedButtons[1].dataset.preferenceState,
"disinterest",
"disinterest styling should persist on trimmed buttons",
);
assert.equal(
trimmedButtons[1].dataset.variant,
"critical",
"disinterest variant token should remain on trimmed buttons",
);
assert.equal(
root.hasAttribute("hidden"),
false,
"tag container should stay visible when pills remain",
);
containerWidth = 300;
modal.reflowVideoTags();
const expandedButtons = [
...root.querySelectorAll("button[data-tag]"),
];
assert.equal(
expandedButtons.length,
3,
"reflow should allow more tags when width increases",
);
assert.deepEqual(
expandedButtons.map((button) => button.dataset.tag),
["#alpha", "#beta", "#delta"],
"reflow should restore full list order before trimming",
);
});
// Channel-profile link in the player modal (TODO #53): clicking the creator
// avatar/name must navigate to the creator's channel. It dispatched
// "navigate:profile", which had NO listener (ModalManager listens for
// "creator:navigate"), so the click did nothing — same class as the old
// action:embed bug. Now it dispatches "creator:navigate" with the pubkey.
//
// test_integrity_note:
// change_type: ["new_tests"]
// scenarios:
// - id: SCN-video-modal-creator-nav
// given: "a video modal with an active video"
// when: "handleCreatorNavigation runs (creator avatar/name click)"
// then: "it dispatches creator:navigate with the pubkey, not the dead navigate:profile"
// observable_outcomes:
// - "creator:navigate fires with { pubkey }"
// - "the old dead navigate:profile event never fires"
// determinism_controls:
// - "JSDOM modal via setupModal; synchronous dispatch"
// anti_cheat_rationale:
// prevents: ["hard-coded return value", "asserting the broken event name"]
// relaxation:
// did_relax_any_assertion: false
test("creator link dispatches creator:navigate with the pubkey (not the dead navigate:profile)", async (t) => {
const { modal, cleanup } = await setupModal();
t.after(cleanup);
modal.activeVideo = { pubkey: "a".repeat(64) };
let creatorNavigate = null;
let deadEventFired = false;
modal.addEventListener("creator:navigate", (event) => {
creatorNavigate = event.detail;
});
modal.addEventListener("navigate:profile", () => {
deadEventFired = true;
});
modal.handleCreatorNavigation();
assert.ok(creatorNavigate, "creator:navigate should fire (ModalManager listens for it)");
assert.equal(creatorNavigate.pubkey, "a".repeat(64));
assert.equal(deadEventFired, false, "the old listener-less navigate:profile must not be used");
});
test("creator navigation is a no-op without an active video pubkey", async (t) => {
const { modal, cleanup } = await setupModal();
t.after(cleanup);
modal.activeVideo = { pubkey: "" };
let fired = false;
modal.addEventListener("creator:navigate", () => {
fired = true;
});
modal.handleCreatorNavigation();
assert.equal(fired, false, "no pubkey → no navigation event");
});