mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-28 16:32:28 +00:00
Setting CARD_LIVENESS_POLICY=hide-foreign made all foreign/NIP-71 content disappear: a hide-until-verified card starts display:none, which has no layout box, so the IntersectionObserver never fires for it — its liveness probe never runs, it never gets a healthy verdict, and it stays hidden forever (deadlock). Fix: cardNeedsEagerLivenessProbe() identifies cards governed by a hide-until-verified policy (foreign under hide-foreign; all non-owner under hide-all). Both health observers now kick the probe for those cards from onCardRegister — which fires for every card regardless of visibility — instead of waiting for an intersection that a hidden card can never produce. The URL probe is deferred one microtask so attachUrlHealthBadges has wired state.onCheck after observe(). Probes stay concurrency-capped + priority-ordered; show-pending is unchanged (no eager probing). Tests: cardNeedsEagerLivenessProbe predicate coverage in tests/video-card-source-visibility.test.mjs. Co-Authored-By: Claude Opus 4.8 <[email protected]>
126 lines
3.8 KiB
JavaScript
126 lines
3.8 KiB
JavaScript
import { getCardLivenessPolicy } from "../constants.js";
|
|
|
|
/**
|
|
* Whether a card is governed by a hide-until-verified policy (so it starts hidden
|
|
* and must be PROBED to ever appear). Such cards can't rely on the viewport
|
|
* IntersectionObserver — a `display:none` card never intersects, so the probe
|
|
* must be kicked eagerly on register. Owner's own cards are always visible and
|
|
* never gated.
|
|
*/
|
|
export function cardNeedsEagerLivenessProbe(cardLike) {
|
|
const card = resolveCardElement(cardLike);
|
|
if (!card || card.dataset.ownerIsViewer === "true") {
|
|
return false;
|
|
}
|
|
const policy = getCardLivenessPolicy();
|
|
if (policy === "hide-all") {
|
|
return true;
|
|
}
|
|
if (policy === "hide-foreign") {
|
|
return card.dataset.foreign === "true";
|
|
}
|
|
return false;
|
|
}
|
|
|
|
function resolveCardElement(cardLike) {
|
|
if (!cardLike) {
|
|
return null;
|
|
}
|
|
|
|
const isElement =
|
|
typeof cardLike === "object" && cardLike !== null && cardLike.nodeType === 1;
|
|
|
|
if (isElement) {
|
|
const element = cardLike;
|
|
if (typeof element.closest === "function") {
|
|
if (element.classList?.contains("card")) {
|
|
return element;
|
|
}
|
|
return element.closest(".card");
|
|
}
|
|
return element.classList?.contains("card") ? element : null;
|
|
}
|
|
|
|
if (
|
|
typeof HTMLElement !== "undefined" &&
|
|
cardLike instanceof HTMLElement &&
|
|
typeof cardLike.closest === "function"
|
|
) {
|
|
if (cardLike.classList.contains("card")) {
|
|
return cardLike;
|
|
}
|
|
return cardLike.closest(".card");
|
|
}
|
|
|
|
if (typeof cardLike === "object" && cardLike !== null) {
|
|
if (typeof cardLike.card === "object" && cardLike.card?.nodeType === 1) {
|
|
return resolveCardElement(cardLike.card);
|
|
}
|
|
if (typeof cardLike.root === "object" && cardLike.root?.nodeType === 1) {
|
|
return resolveCardElement(cardLike.root);
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
export function updateVideoCardSourceVisibility(cardLike) {
|
|
const card = resolveCardElement(cardLike);
|
|
if (!card) {
|
|
return;
|
|
}
|
|
|
|
if (card.dataset.ownerIsViewer === "true") {
|
|
if (card.hidden) {
|
|
card.hidden = false;
|
|
}
|
|
if (card.dataset.sourceVisibility !== "visible") {
|
|
card.dataset.sourceVisibility = "visible";
|
|
}
|
|
return;
|
|
}
|
|
|
|
const cdnState = (card.dataset.urlHealthState || "").toLowerCase();
|
|
const streamState = (card.dataset.streamHealthState || "").toLowerCase();
|
|
|
|
const cdnPending = !cdnState || cdnState === "checking";
|
|
const streamPending = !streamState || streamState === "checking";
|
|
|
|
const cdnHealthy = cdnState === "healthy";
|
|
const streamHealthy = streamState === "healthy";
|
|
|
|
// Liveness visibility policy (config/instance-config.js → CARD_LIVENESS_POLICY):
|
|
// show-pending : show now, hide only once every source is confirmed dead.
|
|
// hide-foreign : foreign/ingested cards stay hidden until a source is proven
|
|
// playable; native cards keep show-pending.
|
|
// hide-all : every non-owner card stays hidden until proven playable.
|
|
const policy = getCardLivenessPolicy();
|
|
const isForeign = card.dataset.foreign === "true";
|
|
const hideUntilVerified =
|
|
policy === "hide-all" || (policy === "hide-foreign" && isForeign);
|
|
|
|
const shouldHide = hideUntilVerified
|
|
? // Hidden until at least one source proves playable (covers the pending
|
|
// window too, so a dead foreign stranger never flashes in).
|
|
!cdnHealthy && !streamHealthy
|
|
: // Default: only hide once every source has come back dead.
|
|
!cdnHealthy && !streamHealthy && !cdnPending && !streamPending;
|
|
|
|
if (shouldHide) {
|
|
if (!card.hidden) {
|
|
card.hidden = true;
|
|
}
|
|
if (card.dataset.sourceVisibility !== "hidden") {
|
|
card.dataset.sourceVisibility = "hidden";
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (card.hidden) {
|
|
card.hidden = false;
|
|
}
|
|
if (card.dataset.sourceVisibility !== "visible") {
|
|
card.dataset.sourceVisibility = "visible";
|
|
}
|
|
}
|