mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-27 07:52:24 +00:00
Real-env console shows the encrypted lists are FETCHED but DECRYPTION fails on cold login: hashtags time out at 6s, blocks report signerStatus 'missing', DMs throw 'helpers unavailable'. Root cause: a relay-connection storm to the user's ~20 dead NIP-65 relays (subsystems use uncapped relayManager read+write) starves the nip-07 extension. Bumping the decrypt timeout to 15s (matching blocks) is a partial mitigation for hashtags/subscriptions. The proper fix (bound reads to a liveness-ranked healthy core incl. defaults + DM decrypt retry) is documented in KNOWN_BUGS #0 — a first capReadRelays attempt was reverted because capping block reads broke the security-critical user-blocks integration test. Co-Authored-By: Claude Opus 4.8 <[email protected]>
6.3 KiB
6.3 KiB
Known Bugs (deferred)
Running list of confirmed bugs/limitations found during the data-flow refactor (see architecture-refactor.md) that we chose to fix later rather than block the current phase. Distinct from the planned refactor work in that doc — these are defects.
Format: [severity] short title — where — what — suggested fix / phase.
Open
0. Encrypted lists (hashtags, DMs, blocks) fail to DECRYPT on login (top priority)
- Severity: high — the user's recurring "hashtags/DMs/watch-history don't load in the profile modal."
- Diagnosed from real-env console (2026-06-14): the lists are fetched (e.g.
block events
Array(2)) but decryption fails, three different ways:- DMs:
DM decryption helpers are unavailable(client.jslistDirectMessages →buildDmDecryptContextreturns 0 decryptors → hard throw, no retry). Happens whenensureExtensionPermissionsreturnsok:false. - Blocks:
Decryption timed out; signerStatus: 'missing'/'unknown'(userBlocks.jsapplyEvents) — the signer/decrypt capability isn't resolved. - Hashtags:
Decryption timed out after 6s(hashtagPreferencesService.js).
- DMs:
- Root cause (strong): a relay-connection STORM. On cold load the app opens
WebSockets to the user's full ~20-relay NIP-65 list (most dead) because
subsystems build relay lists from
relayManager.getReadRelayUrls()+getWriteRelayUrls()(uncapped) — e.g.userBlocks.loadBlocksInternal. The dozens of failing connections churn the main thread and starve the nip-07 extension's postMessage round-trips → permission/decrypt calls fail or time out. - Partial mitigation shipped: hashtag + subscription decrypt timeout 6s→15s.
- Proper fix (next): RelayHealth — bound the SUBSCRIBE/read set to a small,
liveness-ranked healthy core that ALWAYS includes the reliable default
aggregators, applied centrally so every subsystem (blocks, hashtags, subs,
profiles, batch fetcher) reads from it; writes stay uncapped. Plus decrypt
resilience: don't hard-fail DMs on a transient permission miss (retry).
NOTE: a first attempt (
capReadRelays) was reverted — capping the block-list read path broke the security-criticaluser-blocksintegration test (it orchestrates per-relay block hydration), so this needs a test-aware rework. Repro:scripts/perf/disclaimer-repro.mjsshape; real-env console is the source of truth.
1. Logged-out: video grid stays empty until a manual refresh
- Severity: medium (first-load UX, logged-out).
- Where: initial feed render path (
js/index.jsdisclaimer flow →viewManager→feedCoordinator); rendering is a side-effect of event ordering. - Symptom: logged out, after dismissing the disclaimer the grid doesn't populate until the page is refreshed.
- Root cause (suspected): the grid paints as a side-effect of a data event that can fire before the grid container is mounted (render coupled to event ordering, not to state).
- Fix: P5 — unidirectional flow: render from AppState whenever it changes, decoupled from event ordering. Could not reproduce headlessly (real-relay feed returned nothing in the sandbox); reproduce in a real browser first.
2. Residual full-feed reload loop on list-loaded signals — FIXED (P5)
- Status: RESOLVED 2026-06-14.
handleBlocksLoadednow reloads the feed only when the block-set signature actually changes (emit-on-change guard);handleRelaysLoadedonly refreshes the relay UI (never the feed), andhandleHashtagPreferencesChangealready deduped by signature. Regression test:tests/app/blocks-loaded-reload-guard.test.mjs(cheat-resistant).
3. Direct-pool-access lint still misses MULTI-LINE access
- Severity: low (tooling gap — weakens the L1 chokepoint guarantee).
- Status: partially fixed — the regex now catches bare
pool.sub(/pool.list((re-baselined to 22 files). Still MISSES access split across lines, e.g.js/services/profileMetadataService.jswritesnostr.poolnewline.list(— so profiles is an unflagged fetch source. - Fix: normalize whitespace before matching (collapse
\.pool\s*\n\s*\.list) or move to an AST/grep -A1check. Add profileMetadataService (and any other multi-line offenders) to the allowlist once detected.
4. Interim relay cap is static, not liveness-ranked
- Severity: low (acceptable interim).
- Where:
js/nostr/client.jscapSubscribeRelays— keeps the first 6 relays (known-good defaults prioritized) but does NOT re-rank by live health. If a user's first relays are dead, reads degrade until other paths recover. - Fix: P1's deferred
RelayHealth— rank the subscribe set by rolling liveness and re-resolve on health changes.
Pre-existing test failures (predate this refactor)
Confirmed failing at the pre-session baseline (4bd9503c) — not caused by the
refactor, but should be triaged. Not in KNOWN_ISSUES.md.
5. tests/nostr-delete-flow.test.mjs
- "deleted events should not trigger subscription callbacks" — a deleted event
reaches the feed callback (buffer delete-filter or dedupe). Investigate the
VideoEventBufferdelete handling.
6. tests/view-counter.test.mjs
- "view event should append the session tag when requested" — view-event publishing tag composition (unrelated to the P3 counting refactor).
7. tests/nostr-count-fallback.test.mjs
- Fails at baseline; NIP-45 COUNT fallback path. Triage.
8. tests/nostr/nip07Permissions.test.js
writeStoredNip07Permissions/clearStoredNip07Permissionsfail under Node (no reallocalStorage). Likely environmental — provide a localStorage shim (seetests/test-helpers/setup-localstorage.mjs) or guard the test.
9. tests/app/hydrate-sidebar-navigation.test.mjs
- Fails at the pre-session baseline (
4bd9503c). Triage.
10. tests/app/is-user-logged-in.test.mjs
- Fails at the pre-session baseline (
4bd9503c). Triage.
Perf follow-ups (not bugs, but tracked)
- One-time login enrichment burst (~75 REQ frames): batched and O(relays), settles to idle, but could be trimmed by hydrating only on-screen cards.
- Remove
js/devReqMonitor.jsimport +scripts/perf/*diagnostics in P6 cleanup once the refactor lands.