bitvid/tests/nostr-publish-rejection.test.mjs

import "./test-helpers/setup-localstorage.mjs";
import assert from "node:assert/strict";

// Force dev mode BEFORE any config-importing module loads: the dev-mode default
// assertions below depend on it, and outside a dev env isDevMode falls back to
// false (the quarantine cause — see todo 11b / todo 50).
globalThis.__BITVID_DEV_MODE_OVERRIDE__ = true;

if (typeof globalThis.window === "undefined") {
  globalThis.window = {};
}

if (!window.crypto || !window.crypto.getRandomValues) {
  const { webcrypto } = await import("node:crypto");
  window.crypto = webcrypto;
}

const originalWindowNostr = window.nostr;
const originalWindowNostrTools = window.NostrTools;
const nostrToolsModule = await import("nostr-tools");

window.nostr = {
  ...(originalWindowNostr || {}),
  signEvent: async (event) => ({
    ...event,
    id: event?.id || `stub-${Math.random().toString(36).slice(2)}`,
    sig: "stub-signature",
  }),
  nip04: {
    ...(originalWindowNostr?.nip04 || {}),
    encrypt: async () => "cipher-text",
  },
};

window.NostrTools = {
  ...(originalWindowNostrTools || {}),
  ...nostrToolsModule,
  generatePrivateKey: () => {
    const raw = nostrToolsModule.generateSecretKey();
    const bytes = raw instanceof Uint8Array ? raw : Uint8Array.from(raw || []);
    return Array.from(bytes)
      .map((byte) => byte.toString(16).padStart(2, "0"))
      .join("");
  },
  getEventHash: nostrToolsModule.getEventHash,
  signEvent: (event, priv) => {
    const signed = nostrToolsModule.finalizeEvent(event, priv);
    return signed.sig;
  },
};

let activeSignerCleanup = null;

try {
  const { RelayPublishError } = await import("../js/nostrPublish.js");
  const [{ nostrClient }, { setActiveSigner, clearActiveSigner }] =
    await Promise.all([
      import("../js/nostrClientFacade.js"),
      import("../js/nostr/client.js"),
    ]);
  const { subscriptions } = await import("../js/subscriptions.js");
  const { userBlocks } = await import("../js/userBlocks.js");
  const { Application } = await import("../js/app.js");
  const { isDevMode } = await import("../js/config.js");

  setActiveSigner({
    type: "session",
    pubkey: "f".repeat(64),
    signEvent: async (event) => ({
      ...event,
      id: event?.id || `signed-${event.kind}`,
      sig: `sig-${event.kind}`,
    }),
    nip04Encrypt: async (_pubkey, plaintext) => `cipher:${plaintext}`,
  });
  activeSignerCleanup = clearActiveSigner;

  function createRejectingPool(reason = "relay rejected") {
    const calls = [];
    return {
      calls,
      publish(urls, event) {
        calls.push({
          urls: Array.isArray(urls) ? [...urls] : [],
          event,
        });
        return {
          on(eventName, handler) {
            if (eventName === "failed") {
              handler(new Error(reason));
            }
            return this;
          },
        };
      },
    };
  }

  function snapshotRelayState(client) {
    return {
      relays: Array.isArray(client.relays) ? [...client.relays] : [],
      readRelays: Array.isArray(client.readRelays)
        ? [...client.readRelays]
        : [],
      writeRelays: Array.isArray(client.writeRelays)
        ? [...client.writeRelays]
        : [],
      pool: client.pool,
    };
  }

  function restoreRelayState(client, snapshot) {
    client.relays = [...snapshot.relays];
    client.readRelays = [...snapshot.readRelays];
    client.writeRelays = [...snapshot.writeRelays];
    client.pool = snapshot.pool;
  }

  function applyTestRelayState(client, relays, pool) {
    client.relays = [...relays];
    client.readRelays = [...relays];
    client.writeRelays = [...relays];
    client.pool = pool;
  }

  async function testPublishVideoRejectsWhenAllRelaysFail() {
    const testRelays = [
      "wss://relay-a.example",
      "wss://relay-b.example",
    ];
    const pool = createRejectingPool("video rejected");
    const relaySnapshot = snapshotRelayState(nostrClient);
    applyTestRelayState(nostrClient, testRelays, pool);

    try {
      await assert.rejects(
        nostrClient.publishVideo(
          {
            legacyFormData: {
              title: "Test video",
              magnet: "magnet:?xt=urn:btih:TESTVIDEO1234567890",
              mode: "live",
            },
            nip71: {
              imeta: [
                {
                  m: "video/mp4",
                  url: "https://cdn.example/test.mp4",
                },
              ],
            },
          },
          "f".repeat(64)
        ),
        (error) => {
          assert.ok(
            error instanceof RelayPublishError,
            "publishVideo should reject with RelayPublishError"
          );
          assert.equal(
            error.relayFailures.length,
            testRelays.length,
            "relayFailures should include every relay"
          );
          const urls = error.relayFailures
            .map((entry) => entry.url)
            .sort();
          assert.deepEqual(
            urls,
            [...testRelays].sort(),
            "relayFailures should include the rejecting relay URLs"
          );
          return true;
        }
      );

      assert.equal(
        pool.calls.length,
        testRelays.length,
        "publishVideo should attempt each relay"
      );
    } finally {
      restoreRelayState(nostrClient, relaySnapshot);
    }
  }

  async function testPublishSubscriptionListRejectsWhenAllRelaysFail() {
    const testRelays = [
      "wss://relay-a.example",
      "wss://relay-b.example",
    ];
    const pool = createRejectingPool("subscription rejected");
    const relaySnapshot = snapshotRelayState(nostrClient);
    applyTestRelayState(nostrClient, testRelays, pool);

    const originalSubs = new Set(subscriptions.subscribedPubkeys);
    const originalSubsEventId = subscriptions.subsEventId;
    subscriptions.subscribedPubkeys = new Set(["abcdef1234567890"]);
    subscriptions.subsEventId = null;

    try {
      await assert.rejects(
        subscriptions.publishSubscriptionList("f".repeat(64)),
        (error) => {
          assert.ok(
            error instanceof RelayPublishError,
            "publishSubscriptionList should reject with RelayPublishError"
          );
          assert.equal(
            error.relayFailures.length,
            testRelays.length,
            "relayFailures should include each relay for subscriptions"
          );
          const urls = error.relayFailures
            .map((entry) => entry.url)
            .sort();
          assert.deepEqual(urls, [...testRelays].sort());
          return true;
        }
      );

      assert.equal(
        pool.calls.length,
        testRelays.length,
        "publishSubscriptionList should attempt each relay"
      );
      assert.equal(
        subscriptions.subsEventId,
        null,
        "subsEventId should remain unset on failure"
      );
    } finally {
      subscriptions.subscribedPubkeys = originalSubs;
      subscriptions.subsEventId = originalSubsEventId;
      restoreRelayState(nostrClient, relaySnapshot);
    }
  }

  async function testPublishBlockListRejectsWhenAllRelaysFail() {
    const testRelays = [
      "wss://relay-a.example",
      "wss://relay-b.example",
    ];
    const pool = createRejectingPool("block list rejected");
    const relaySnapshot = snapshotRelayState(nostrClient);
    applyTestRelayState(nostrClient, testRelays, pool);

    const originalBlocked = new Set(userBlocks.blockedPubkeys);
    const originalBlockEventId = userBlocks.blockEventId;
    const originalMuteEventId = userBlocks.muteEventId;
    const originalMuteEventCreatedAt = userBlocks.muteEventCreatedAt;
    userBlocks.blockedPubkeys = new Set(["abcd".repeat(16)]);
    userBlocks.blockEventId = null;
    userBlocks.muteEventId = null;
    userBlocks.muteEventCreatedAt = null;

    try {
      await assert.rejects(
        userBlocks.publishBlockList("f".repeat(64)),
        (error) => {
          assert.ok(
            error instanceof RelayPublishError,
            "publishBlockList should reject with RelayPublishError"
          );
          assert.equal(
            error.relayFailures.length,
            testRelays.length,
            "relayFailures should include each relay for block list"
          );
          const urls = error.relayFailures
            .map((entry) => entry.url)
            .sort();
          assert.deepEqual(urls, [...testRelays].sort());
          return true;
        }
      );

      assert.equal(
        pool.calls.length,
        testRelays.length,
        "publishBlockList should attempt each relay"
      );
      assert.equal(
        userBlocks.blockEventId,
        null,
        "blockEventId should remain unset on failure"
      );
    } finally {
      userBlocks.blockedPubkeys = originalBlocked;
      userBlocks.blockEventId = originalBlockEventId;
      userBlocks.muteEventId = originalMuteEventId;
      userBlocks.muteEventCreatedAt = originalMuteEventCreatedAt;
      restoreRelayState(nostrClient, relaySnapshot);
    }
  }

  async function testPublishVideoNoteDefaultsToLiveModeInDev() {
    assert.equal(isDevMode, true, "Test expects isDevMode to be true");

    let capturedPayload = null;
    let capturedPubkey = null;

    const fakeApp = {
      pubkey: "f".repeat(64),
      nostrService: {
        publishVideoNote: async (payload, pubkey) => {
          capturedPayload = payload;
          capturedPubkey = pubkey;
        },
      },
      showError(message) {
        throw new Error(`showError invoked: ${message}`);
      },
      showSuccess() {},
      showStatus() {},
      loadVideos: async () => {},
      uploadModal: null,
    };

    const publishResult = await Application.prototype.publishVideoNote.call(
      fakeApp,
      {
        legacyFormData: {
          title: "Dev Mode Default",
          url: "https://cdn.example/dev.mp4",
        },
      },
    );

    assert.equal(publishResult, true, "publishVideoNote should resolve truthy");
    assert.equal(
      capturedPubkey,
      fakeApp.pubkey,
      "publishVideoNote should forward the viewer pubkey",
    );
    assert.equal(
      capturedPayload?.legacyFormData?.mode,
      "live",
      "publishVideoNote should default mode to live even in dev mode",
    );
  }

  async function testPublishVideoNoteRespectsProvidedMode() {
    let capturedPayload = null;

    const fakeApp = {
      pubkey: "f".repeat(64),
      nostrService: {
        publishVideoNote: async (payload) => {
          capturedPayload = payload;
        },
      },
      showError(message) {
        throw new Error(`showError invoked: ${message}`);
      },
      showSuccess() {},
      showStatus() {},
      loadVideos: async () => {},
      uploadModal: null,
    };

    await Application.prototype.publishVideoNote.call(
      fakeApp,
      {
        legacyFormData: {
          title: "Dev Mode Override",
          url: "https://cdn.example/dev.mp4",
          mode: "dev",
        },
      },
    );

    assert.equal(
      capturedPayload?.legacyFormData?.mode,
      "dev",
      "publishVideoNote should respect an explicit dev mode value",
    );
  }

  async function testPublishVideoNormalizesPubkeyForNip71Metadata() {
    const uppercasePubkey = "AB".repeat(32);
    const originalSignAndPublish = nostrClient.signAndPublishEvent;
    const originalPublishNip71 = nostrClient.publishNip71Video;

    const publishedEvents = [];
    const nip71Calls = [];

    nostrClient.signAndPublishEvent = async (event, options = {}) => {
      publishedEvents.push({ event, options });
      const contextLabel =
        typeof options?.context === "string" && options.context
          ? options.context
          : "event";
      return {
        signedEvent: {
          ...event,
          id: event?.id || `signed-${contextLabel}`,
        },
      };
    };

    nostrClient.publishNip71Video = async (payload, pubkey, pointerOptions) => {
      nip71Calls.push({ payload, pubkey, pointerOptions });
      return null;
    };

    try {
      const result = await nostrClient.publishVideo(
        {
          legacyFormData: {
            title: "Metadata Video",
            description: "Video with metadata",
            url: "https://cdn.example/video.mp4",
            mode: "live",
          },
          nip71: {
            title: "Metadata Video",
            imeta: [{ url: "https://cdn.example/video.mp4", m: "video/mp4" }],
          },
        },
        uppercasePubkey,
      );

      assert.equal(typeof result?.id, "string", "publishVideo should resolve with a signed event");
      assert.ok(
        publishedEvents.some((entry) => entry.options?.context === "video note"),
        "publishVideo should sign the primary video note",
      );
      // spec_correction (quarantine triage, todo 11b): this test asserted
      // publishVideo invokes publishNip71Video whenever nip71 metadata is
      // present. That is stale spec on two counts: (1) legacy 21/22 auto-publish
      // is deliberately gated OFF by FEATURE_PUBLISH_NIP71 (the opt-in NIP-71
      // MIRROR — 34235/36 from My Videos — is the interop story, and #58 removed
      // the form UI that fed this path); (2) the internal call goes through the
      // module-level publishNip71Video, so stubbing the client method never
      // intercepts it. Correct behavior: with the flag off (default), the video
      // note publishes and NO NIP-71 auto-publish is attempted.
      assert.equal(
        nip71Calls.length,
        0,
        "publishVideo must NOT auto-publish NIP-71 while FEATURE_PUBLISH_NIP71 is off",
      );
    } finally {
      nostrClient.signAndPublishEvent = originalSignAndPublish;
      nostrClient.publishNip71Video = originalPublishNip71;
    }
  }

  await testPublishVideoRejectsWhenAllRelaysFail();
  await testPublishSubscriptionListRejectsWhenAllRelaysFail();
  await testPublishBlockListRejectsWhenAllRelaysFail();
  await testPublishVideoNoteDefaultsToLiveModeInDev();
  await testPublishVideoNoteRespectsProvidedMode();
  await testPublishVideoNormalizesPubkeyForNip71Metadata();

  console.log("nostr publish rejection tests passed");
} finally {
  if (typeof activeSignerCleanup === "function") {
    try {
      activeSignerCleanup();
    } catch (_) {
      // ignore cleanup errors
    }
  }
  if (typeof originalWindowNostr === "undefined") {
    delete window.nostr;
  } else {
    window.nostr = originalWindowNostr;
  }
  if (typeof originalWindowNostrTools === "undefined") {
    delete window.NostrTools;
  } else {
    window.NostrTools = originalWindowNostrTools;
  }
}

// All assertions above run to completion before the cleanup finally block; a
// failure would have rejected the top-level await and exited non-zero. This
// file imports the full app stack (js/app.js, subscriptions, userBlocks) whose
// module-load side effects (timers/connection managers) keep the event loop
// alive after the tests finish, so the process would otherwise hang. Force a
// clean exit — the established pattern for this repo's bare-assert tests with
// lingering handles. The small delay lets the "tests passed" log flush first.
setTimeout(() => process.exit(0), 50);