mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-27 07:52:24 +00:00
thePR0M3TH3ANandClaude Opus 4.8
fb2f12b49d
Switching to a saved nsec profile silently failed: switchProfile -> requestLogin -> the
nsec provider was called with no passphrase, so it threw "secret-required" and the switch
was caught+logged with no user feedback. It never prompted for the PIN.
Now handleProfileSwitchRequest detects an nsec target and, before switching, prepares the
stored-key unlock:
- evaluateStoredNsecSwitch(meta, target) (pure) gates on a persisted nsec key for THIS
account (via getStoredSessionActorMetadata); errors clearly otherwise ("log in with its
nsec", "different account's key saved").
- showPasswordPrompt (js/ui/promptDialog.js) collects the PIN/passphrase in a styled
dialog (Promise<string|null>, stacks above modals).
- switchProfile(pubkey, { unlockStored: true, passphrase }) — authService.switchProfile
now forwards unlockStored/passphrase to requestLogin, which routes to the nsec
provider's unlockStoredSessionActor to restore the signer and activate the account.
- Wrong PIN -> "Incorrect PIN/passphrase" toast (decrypt-failed).
So NIP-07 -> nsec switching works fluently. NIP-46 switching is unchanged (follow-up to
verify/extend); multiple-nsec accounts still share one stored slot (follow-up).
Tests: tests/stored-nsec-switch.test.mjs (6), tests/password-prompt.test.mjs (6). Build +
lint clean; auth suites 25/25.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
72 lines
2.4 KiB
JavaScript
72 lines
2.4 KiB
JavaScript
// showPasswordPrompt() collects a passphrase/PIN via a styled dialog (used to unlock a
|
|
// stored nsec key when switching accounts). Resolves the entered string, or null when
|
|
// the user cancels/escapes.
|
|
|
|
import test, { beforeEach, afterEach } from "node:test";
|
|
import { strict as assert } from "node:assert";
|
|
import { JSDOM } from "jsdom";
|
|
import { showPasswordPrompt } from "../js/ui/promptDialog.js";
|
|
|
|
let dom;
|
|
beforeEach(() => {
|
|
dom = new JSDOM("<!doctype html><html><body></body></html>");
|
|
globalThis.document = dom.window.document;
|
|
globalThis.window = dom.window;
|
|
globalThis.HTMLElement = dom.window.HTMLElement;
|
|
globalThis.KeyboardEvent = dom.window.KeyboardEvent;
|
|
});
|
|
afterEach(() => {
|
|
delete globalThis.document;
|
|
delete globalThis.window;
|
|
delete globalThis.HTMLElement;
|
|
delete globalThis.KeyboardEvent;
|
|
});
|
|
|
|
const overlay = () => dom.window.document.querySelector(".bv-modal");
|
|
const input = () => overlay().querySelector('input[type="password"]');
|
|
|
|
test("resolves the entered value on Confirm and removes the dialog", async () => {
|
|
const p = showPasswordPrompt("Enter your PIN", { confirmLabel: "Switch" });
|
|
input().value = "hunter2";
|
|
overlay().querySelector(".btn").click(); // confirm (cancel is .btn-ghost)
|
|
assert.equal(await p, "hunter2");
|
|
assert.equal(overlay(), null, "dialog removed after resolving");
|
|
});
|
|
|
|
test("resolves the value when Enter is pressed in the input", async () => {
|
|
const p = showPasswordPrompt("PIN");
|
|
const el = input();
|
|
el.value = "s3cret";
|
|
el.dispatchEvent(
|
|
new dom.window.KeyboardEvent("keydown", { key: "Enter", bubbles: true }),
|
|
);
|
|
assert.equal(await p, "s3cret");
|
|
});
|
|
|
|
test("resolves null when cancelled", async () => {
|
|
const p = showPasswordPrompt("PIN");
|
|
overlay().querySelector(".btn-ghost").click();
|
|
assert.equal(await p, null);
|
|
});
|
|
|
|
test("resolves null on Escape", async () => {
|
|
const p = showPasswordPrompt("PIN");
|
|
dom.window.document.dispatchEvent(
|
|
new dom.window.KeyboardEvent("keydown", { key: "Escape", bubbles: true }),
|
|
);
|
|
assert.equal(await p, null);
|
|
});
|
|
|
|
test("focuses the input so the user can type immediately", async () => {
|
|
const p = showPasswordPrompt("PIN");
|
|
assert.equal(dom.window.document.activeElement, input());
|
|
overlay().querySelector(".btn-ghost").click();
|
|
await p;
|
|
});
|
|
|
|
test("without a DOM it resolves null rather than throwing", async () => {
|
|
delete globalThis.document;
|
|
delete globalThis.window;
|
|
assert.equal(await showPasswordPrompt("PIN"), null);
|
|
});
|