Files
bitvid/js/ui/components/editModalUpload.js
T
thePR0M3TH3ANandClaude Opus 4.8 c8a63c57c6 feat(edit): thumbnail + video file upload in Edit modal (steps 2-3/3)
Brings the Edit modal to upload parity with the Upload modal: re-upload a
thumbnail or video file instead of only pasting URLs.

- Wire storage services (r2/s3/storageService) + pubkey/npub accessors into
  EditModal via ModalManager/initEditModal; EditModal constructs a shared
  MediaUploader.
- New editModalUpload.js holds all the upload glue (file-picker wiring, progress,
  storage-unlock checks, field write-back) to keep EditModal under its file-size
  budget. EditModal calls initEditModalUpload(this, context) in one line.
- edit-video-modal.html: "Replace video file…" (under the URL field) and
  "Replace thumbnail file…" (under the thumbnail field), each with a hidden file
  input + status line.
- On thumbnail upload: writes the new URL into the thumbnail field. On video
  upload: writes url + magnet (+ ws/xs hints). All written via setFieldUnlocked,
  which marks the field edited so EditModal.collect actually persists it (gated
  behind storage being configured + unlocked).

setFieldUnlocked is unit-tested (mutation-verified): without the unlock, the
re-upload would silently not save. Build + full lint + unit suite green.

NOTE: the upload/storage flow itself can't be unit-tested (browser + R2/S3);
pending manual verification of editing a video's thumbnail/file.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
2026-06-20 09:09:07 -04:00

156 lines
6.0 KiB
JavaScript

// js/ui/components/editModalUpload.js
//
// "Replace file" upload glue for the Edit modal: wires the optional thumbnail
// and video file-pickers to the shared MediaUploader and writes the resulting
// URLs/magnet back into the (unlocked) edit fields. Kept out of EditModal.js to
// stay within its file-size budget. Operates on the EditModal instance (`modal`)
// and its rendered root (`context`).
import { devLogger, userLogger } from "../../utils/logger.js";
// Set a field's value AND mark it edited/unlocked so EditModal.collect treats it
// as a user change (isEditing() reads readOnly===false || dataset.isEditing).
function setFieldUnlocked(input, value) {
if (!input) return;
input.value = value;
input.readOnly = false;
input.removeAttribute("readonly");
input.dataset.isEditing = "true";
}
function setStatus(el, text) {
if (el) el.textContent = typeof text === "string" ? text : "";
}
// Resolve the active storage connection and surface a user-facing reason when
// upload isn't possible. Returns the connection on success, null otherwise.
async function ensureUploadable(modal) {
if (!modal.mediaUploader) {
modal.showError("Uploads are unavailable in this view.");
return null;
}
let conn = null;
try {
conn = await modal.mediaUploader.resolveActiveConnection();
} catch (error) {
devLogger.warn("[editModalUpload] Failed to resolve storage connection:", error);
}
if (!conn || !conn.configured) {
modal.showError("Configure a storage provider in your profile before uploading.");
return null;
}
if (!conn.unlocked || !conn.credentials) {
modal.showError("Unlock your storage in the profile modal, then try again.");
return null;
}
return conn;
}
export function initEditModalUpload(modal, context) {
if (!context || typeof context.querySelector !== "function") {
return;
}
const els = {
thumbBtn: context.querySelector("#editThumbnailFileBtn") || null,
thumbInput: context.querySelector("#editThumbnailFile") || null,
thumbStatus: context.querySelector("#editThumbnailUploadStatus") || null,
videoBtn: context.querySelector("#editVideoFileBtn") || null,
videoInput: context.querySelector("#editVideoFile") || null,
videoStatus: context.querySelector("#editVideoUploadStatus") || null,
};
// Monotonic guard so a stale upload (modal reused for another video) can't
// overwrite fresh fields.
modal._editUploadId = modal._editUploadId || 0;
if (els.thumbBtn instanceof HTMLElement && els.thumbInput instanceof HTMLElement) {
els.thumbBtn.addEventListener("click", () => els.thumbInput.click());
els.thumbInput.addEventListener("change", async () => {
const file = els.thumbInput.files?.[0];
els.thumbInput.value = "";
if (!file) return;
const conn = await ensureUploadable(modal);
if (!conn) return;
const uploadId = ++modal._editUploadId;
setStatus(els.thumbStatus, "Uploading thumbnail…");
try {
const { url } = await modal.mediaUploader.uploadThumbnail(file, {
provider: conn.provider,
credentials: conn.credentials,
onProgress: (fraction) => {
if (modal._editUploadId === uploadId && Number.isFinite(fraction)) {
setStatus(els.thumbStatus, `Uploading thumbnail… ${Math.round(fraction * 100)}%`);
}
},
});
if (modal._editUploadId !== uploadId) return;
setFieldUnlocked(modal.fields?.thumbnail, url);
setStatus(els.thumbStatus, "Thumbnail uploaded.");
modal.showSuccess?.("Thumbnail uploaded. Save changes to publish it.");
} catch (error) {
if (modal._editUploadId !== uploadId) return;
userLogger.error("[editModalUpload] Thumbnail upload failed:", error);
setStatus(els.thumbStatus, "Thumbnail upload failed.");
modal.showError("Thumbnail upload failed.");
}
});
}
if (els.videoBtn instanceof HTMLElement && els.videoInput instanceof HTMLElement) {
els.videoBtn.addEventListener("click", () => els.videoInput.click());
els.videoInput.addEventListener("change", async () => {
const file = els.videoInput.files?.[0];
els.videoInput.value = "";
if (!file) return;
const conn = await ensureUploadable(modal);
if (!conn) return;
const uploadId = ++modal._editUploadId;
setStatus(els.videoStatus, "Uploading video…");
try {
const result = await modal.mediaUploader.uploadVideo(file, {
provider: conn.provider,
credentials: conn.credentials,
onProgress: ({ fraction, label }) => {
if (modal._editUploadId !== uploadId) return;
if (label) setStatus(els.videoStatus, label);
else if (Number.isFinite(fraction)) {
setStatus(els.videoStatus, `Uploading video… ${Math.round(fraction * 100)}%`);
}
},
});
if (modal._editUploadId !== uploadId) return;
// Write the new source into the (unlocked) fields. The magnet carries
// the new infohash + ws/xs; EditModal.collect re-derives hints from it.
setFieldUnlocked(modal.fields?.url, result.url);
if (result.magnet) {
setFieldUnlocked(modal.fields?.magnet, result.magnet);
if (modal.fields?.ws) setFieldUnlocked(modal.fields.ws, result.url);
if (modal.fields?.xs && result.torrentUrl) {
setFieldUnlocked(modal.fields.xs, result.torrentUrl);
}
}
setStatus(
els.videoStatus,
result.hasValidInfoHash
? "Video uploaded. Save changes to publish it."
: "Video uploaded (no torrent). Save changes to publish it.",
);
modal.showSuccess?.("Video uploaded. Save changes to publish it.");
} catch (error) {
if (modal._editUploadId !== uploadId) return;
userLogger.error("[editModalUpload] Video upload failed:", error);
setStatus(els.videoStatus, "Video upload failed.");
modal.showError("Video upload failed.");
}
});
}
}
export { setFieldUnlocked };