0 Fork 0

mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-10-27 07:52:24 +00:00

Files

T

google-labs-jules[bot]andPR0M3TH3AN f676fb2ff5 [security] replace innerHTML in RevertModal.js

Migrated `js/ui/components/RevertModal.js` to safe DOM APIs (`createElement`, `textContent`, `DOMParser`).
Extracted rendering logic to `js/ui/components/revertModalRenderers.js`.
Updated baseline in `scripts/check-innerhtml.mjs` (0 remaining usages).
Updated tests to mock DOMParser.

Co-authored-by: PR0M3TH3AN <[email protected]>

2026-02-14 18:58:02 +00:00

1.3 KiB

Raw Blame History

Agent Completion Log

Agent: innerhtml-migration-agent Date: 2026-02-14 Cadence: Daily

Task Summary

Migrated js/ui/components/RevertModal.js from innerHTML to safe DOM APIs. This file had the highest usage (10 assignments).

Actions Taken

Refactoring:
- Replaced all innerHTML assignments with document.createElement, textContent, and replaceChildren.
- Switched load() and reset() logic to use DOMParser for safe parsing of trusted templates.
- Extracted complex rendering logic (NIP-71 media metadata, variants, tracks) to a new module js/ui/components/revertModalRenderers.js to manage file size complexity.
Verification:
- Updated tests/modal-accessibility.test.mjs to mock DOMParser in the test environment.
- Ran npm run lint and npm run test:unit successfully.
- Verified innerHTML usage for the file dropped to 0.
Baseline Update:
- Updated scripts/check-innerhtml.mjs to remove RevertModal.js from the tracking list.

Artifacts

js/ui/components/RevertModal.js
js/ui/components/revertModalRenderers.js
scripts/check-innerhtml.mjs
tests/modal-accessibility.test.mjs
decisions/DECISIONS_2026-02-14_17-35-00.md
test_logs/TEST_LOG_2026-02-14_17-35-00.md

1.3 KiB Raw Blame History

Agent Completion Log

Task Summary

Actions Taken

Artifacts

1.3 KiB

Raw Blame History