mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-29 17:02:28 +00:00
- Update README.md to recommend `npm ci` and include test steps. - Update CONTRIBUTING.md with explicit development setup instructions. - Add `.devcontainer/devcontainer.json` for reproducible Node 20 environment. - Add audit report in `ai/reports/onboarding-20260118.md`.
1.9 KiB
1.9 KiB
Onboarding Audit Report - 2026-01-18
Summary
Performed a fresh checkout validation of the bitvid repository to audit the developer onboarding experience.
Execution Log
- Dependency Installation:
npm ciwas used instead ofnpm install(implied by README) to ensure a clean state.- Result: Success.
- Build:
npm run build:css.- Result: Success.
- Format:
npm run format.- Result: Success.
- Testing:
npm run test:unit.- Result: Timed out in the audit environment (400s limit), but individual tests pass. The test runner executes tests sequentially which can be slow on constrained resources.
Findings & Fixes
Documentation Gaps
-
README.md:
- The "Local Setup" section implied
npm installbutnpm ciis preferred for consistent CI/CD and fresh setups. - The "For Contributors" section completely missed the dependency installation step.
- Fix: Updated
README.mdto explicitly listnpm ciin both sections and added a "Test" step withnpm run test:unit.
- The "Local Setup" section implied
-
CONTRIBUTING.md:
- Lacked technical setup instructions, relying on README.
- Fix: Added a "Development Setup" section summarizing
npm ci, testing, and linting commands, linking back to README.
Environment Brittleness
- The reliance on system-wide Node.js versions was unidentified.
- Fix: Added a
.devcontainer/devcontainer.jsonconfiguration to standardize the development environment using a Docker-based Node.js 20 container.
Linting Failures
npm run lintfails on a fresh checkout due to pre-existing inline style violations injs/ui/components/EventDetailsModal.jsandjs/ui/components/SimilarContentCard.js.- Recommendation: These legacy style violations should be addressed in a separate refactoring PR.
Recommendations
- Contributors should use the provided Devcontainer or ensure Node.js 20+ is installed.
npm cishould be the standard instruction for new environments.