mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-27 07:52:24 +00:00
### Motivation - Prevent a browser-policy muted-autoplay retry from overwriting a viewer's explicit mute/unmute preference and ensure fallback mutes are transient. - Ensure that when a user logs in while a video comment modal is open, the open thread is reloaded (not just refreshed) so comments continue to display correctly after relay-backed services are reconfigured. ### Description - Add `js/utils/autoplayPreference.js` with `muteForAutoplayFallback` and `consumeAutoplayFallbackMute` helpers to mark and consume transient fallback mutes. - Update `js/services/playbackService.js` to treat sound as default unless the viewer explicitly chose mute, persist explicit choices via `localStorage`, ignore fallback-generated volume changes using `consumeAutoplayFallbackMute`, and expose `muteForAutoplayFallback` delegating to the new util. - Replace direct `videoElement.muted = true` calls with `playbackService.muteForAutoplayFallback` in `js/app/playbackCoordinator.js` and `js/webtorrent.js` so fallback mutes are marked as transient. - Change `js/app/authSessionCoordinator.js` to reload the currently open video comment thread with `commentController.load(activeModalVideo)` after login if a modal video is active, instead of only calling `refreshAuthState`. - Update tests in `tests/services/playbackService.test.mjs` and add a test in `tests/app/login-defers-dms.test.mjs` to cover the login behavior that reloads an open comment thread. ### Testing - Ran the `PlaybackService` unit tests (`tests/services/playbackService.test.mjs`) which assert `prepareVideoElement` behavior, explicit mute persistence, and the transient nature of fallback mute, and they passed. - Ran the auth login unit tests including `tests/app/login-defers-dms.test.mjs` which verifies DM deferral and reload of an open comment thread, and they passed.
142 lines
4.6 KiB
JavaScript
142 lines
4.6 KiB
JavaScript
// js/feedEngine/mostZappedFeed.js
|
|
//
|
|
// The "Most Zapped" tab (#47): the catalog of approved creators ranked by
|
|
// ZAP TOTAL (sats from kind-9735 receipts). It is intentionally scoped to the
|
|
// creator whitelist for discovery, but still runs the ordinary moderation
|
|
// stages — whitelisting does not waive Web-of-Trust handling.
|
|
// The metric getter uses requestVideoZapTotal, which returns the cached total
|
|
// AND schedules a batched receipt fetch for unknown pointers; the Most Zapped
|
|
// view re-runs the feed on zapTotals' change signal so the order settles as
|
|
// totals stream in.
|
|
|
|
import { FEED_TYPES } from "../constants.js";
|
|
import { requestVideoZapTotal } from "../zapTotals.js";
|
|
import {
|
|
createWhitelistedAuthorsNostrSource,
|
|
createBlacklistFilterStage,
|
|
createDedupeByRootStage,
|
|
createModerationStage,
|
|
createResolvePostedAtStage,
|
|
} from "./index.js";
|
|
import { createMostZappedSorter } from "./sorters.js";
|
|
|
|
// Resolve a video's zap total via the app's canonical pointer derivation (the
|
|
// same pointer keys the zap flow tags receipts with, so ranking and receipts
|
|
// agree).
|
|
function makeGetZapTotal(app) {
|
|
return (video) => {
|
|
if (!video || typeof video !== "object") {
|
|
return 0;
|
|
}
|
|
try {
|
|
const info =
|
|
typeof app.deriveVideoPointerInfo === "function"
|
|
? app.deriveVideoPointerInfo(video)
|
|
: null;
|
|
if (!info?.pointer) {
|
|
return 0;
|
|
}
|
|
const total = requestVideoZapTotal(info.pointer);
|
|
return Number.isFinite(total) ? Number(total) : 0;
|
|
} catch (error) {
|
|
return 0;
|
|
}
|
|
};
|
|
}
|
|
|
|
function getWhitelistedAuthors(app) {
|
|
const accessControl = app?.nostrService?.accessControl;
|
|
if (typeof accessControl?.getWhitelistPubkeys !== "function") {
|
|
return [];
|
|
}
|
|
try {
|
|
const authors = accessControl.getWhitelistPubkeys();
|
|
return Array.isArray(authors) ? authors : [];
|
|
} catch (error) {
|
|
return [];
|
|
}
|
|
}
|
|
|
|
export function buildMostZappedFeedRuntime(app) {
|
|
const blacklist =
|
|
app.blacklistedEventIds instanceof Set
|
|
? new Set(app.blacklistedEventIds)
|
|
: new Set();
|
|
const moderationThresholds =
|
|
typeof app.getActiveModerationThresholds === "function"
|
|
? app.getActiveModerationThresholds()
|
|
: null;
|
|
return {
|
|
blacklistedEventIds: blacklist,
|
|
isAuthorBlocked: (pubkey) => app.isAuthorBlocked(pubkey),
|
|
moderationThresholds: moderationThresholds
|
|
? { ...moderationThresholds }
|
|
: undefined,
|
|
getZapTotal: makeGetZapTotal(app),
|
|
whitelistedAuthors: getWhitelistedAuthors(app),
|
|
};
|
|
}
|
|
|
|
export function registerMostZappedFeed(app) {
|
|
if (!app?.feedEngine || typeof app.feedEngine.registerFeed !== "function") {
|
|
return null;
|
|
}
|
|
const existing =
|
|
typeof app.feedEngine.getFeedDefinition === "function"
|
|
? app.feedEngine.getFeedDefinition(FEED_TYPES.MOST_ZAPPED)
|
|
: null;
|
|
if (existing) {
|
|
return existing;
|
|
}
|
|
|
|
const resolveThreshold = (key) => ({ runtimeValue, defaultValue }) => {
|
|
if (
|
|
Number.isFinite(runtimeValue) ||
|
|
runtimeValue === Number.POSITIVE_INFINITY
|
|
) {
|
|
return runtimeValue;
|
|
}
|
|
if (typeof app.getActiveModerationThresholds === "function") {
|
|
const active = app.getActiveModerationThresholds();
|
|
const candidate =
|
|
active && typeof active === "object" ? active[key] : undefined;
|
|
if (Number.isFinite(candidate) || candidate === Number.POSITIVE_INFINITY) {
|
|
return candidate;
|
|
}
|
|
}
|
|
return defaultValue;
|
|
};
|
|
|
|
try {
|
|
return app.feedEngine.registerFeed(FEED_TYPES.MOST_ZAPPED, {
|
|
source: createWhitelistedAuthorsNostrSource({ service: app.nostrService }),
|
|
stages: [
|
|
createBlacklistFilterStage({
|
|
shouldIncludeVideo: (video, options) =>
|
|
app.nostrService.shouldIncludeVideo(video, options),
|
|
}),
|
|
createDedupeByRootStage({
|
|
dedupe: (videos) => app.dedupeVideosByRoot(videos),
|
|
}),
|
|
createModerationStage({
|
|
getService: () => app.nostrService.getModerationService(),
|
|
autoplayThreshold: resolveThreshold("autoplayBlockThreshold"),
|
|
blurThreshold: resolveThreshold("blurThreshold"),
|
|
trustedMuteHideThreshold: resolveThreshold("trustedMuteHideThreshold"),
|
|
trustedReportHideThreshold: resolveThreshold("trustedSpamHideThreshold"),
|
|
}),
|
|
createResolvePostedAtStage(),
|
|
],
|
|
sorter: createMostZappedSorter(),
|
|
hooks: {
|
|
timestamps: {
|
|
getKnownVideoPostedAt: (video) => app.getKnownVideoPostedAt(video),
|
|
resolveVideoPostedAt: (video) => app.resolveVideoPostedAt(video),
|
|
},
|
|
},
|
|
});
|
|
} catch (error) {
|
|
return null;
|
|
}
|
|
}
|