thePR0M3TH3AN/seedPass
1
0
Fork 0
mirror of https://github.com/PR0M3TH3AN/SeedPass.git synced 2025-09-09 15:58:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #408 from PR0M3TH3AN/codex/remove-confirm_action-calls-in-handle_retrieve_entry

Browse Source 
Remove QR prompts during entry retrieval
This commit is contained in:
thePR0M3TH3AN
2025-07-08 15:36:51 -04:00
committed by GitHub
parent 1f0eda9bc6 ae34edc458
commit 238091b790
2 changed files with 5 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/password_manager/manager.py
View File

@@ -1944,10 +1944,7 @@ class PasswordManager:
)
else:
print(color_text(phrase, "deterministic"))
if confirm_action("Show Compact Seed QR? (Y/N): "):
from password_manager.seedqr import encode_seedqr
TotpManager.print_qr_code(encode_seedqr(phrase))
# Removed QR code display prompt and output
if confirm_action("Show derived entropy as hex? (Y/N): "):
from local_bip85.bip85 import BIP85
from bip_utils import Bip39SeedGenerator
@@ -2023,12 +2020,7 @@ class PasswordManager:
)
else:
print(color_text(f"nsec: {nsec}", "deterministic"))
if confirm_action("Show QR code for npub? (Y/N): "):
TotpManager.print_qr_code(f"nostr:{npub}")
if confirm_action(
"WARNING: Displaying the nsec QR reveals your private key. Continue? (Y/N): "
):
TotpManager.print_qr_code(nsec)
# QR code display removed for npub and nsec
if notes:
print(colored(f"Notes: {notes}", "cyan"))
except Exception as e:
@@ -2131,10 +2123,7 @@ class PasswordManager:
)
else:
print(color_text(seed, "deterministic"))
if confirm_action("Show Compact Seed QR? (Y/N): "):
from password_manager.seedqr import encode_seedqr
TotpManager.print_qr_code(encode_seedqr(seed))
# QR code display removed for managed account seed
self._entry_actions_menu(index, entry)
pause()
return

9
src/tests/test_nostr_qr.py
View File

@@ -21,7 +21,7 @@ class FakeNostrClient:
return None, "abcd"
def test_show_qr_for_nostr_keys(monkeypatch):
def test_no_qr_for_nostr_keys(monkeypatch):
with TemporaryDirectory() as tmpdir:
tmp_path = Path(tmpdir)
vault, enc_mgr = create_vault(tmp_path, TEST_SEED, TEST_PASSWORD)
@@ -46,11 +46,6 @@ def test_show_qr_for_nostr_keys(monkeypatch):
inputs = iter([str(idx), "n", "", ""])
monkeypatch.setattr("builtins.input", lambda *a, **k: next(inputs))
responses = iter([True, False])
monkeypatch.setattr(
"password_manager.manager.confirm_action",
lambda *_a, **_k: next(responses),
)
called = []
monkeypatch.setattr(
"password_manager.manager.TotpManager.print_qr_code",
@@ -58,4 +53,4 @@ def test_show_qr_for_nostr_keys(monkeypatch):
)
pm.handle_retrieve_entry()
assert called == [f"nostr:{npub}"]
assert called == []