Merge pull request #94 from PR0M3TH3AN/codex/fix-windows-rename-handling-in-tests

Fix path mismatch on Windows
This commit is contained in:
thePR0M3TH3AN
2025-05-26 14:46:19 -04:00
committed by GitHub
2 changed files with 18 additions and 5 deletions

View File

@@ -45,12 +45,18 @@ pub fn determine_scan_root(pattern: &str) -> PathBuf {
}
}
/// Canonicalize a path, falling back to the original on error.
pub fn canonicalize_lossy<P: AsRef<Path>>(p: P) -> PathBuf {
std::fs::canonicalize(&p).unwrap_or_else(|_| p.as_ref().to_path_buf())
}
/// Convert a filesystem path to a normalized database path.
///
/// On Windows this replaces backslashes with forward slashes so that paths
/// stored in the database are consistent across platforms.
pub fn to_db_path<P: AsRef<Path>>(p: P) -> String {
let s = p.as_ref().to_string_lossy();
let canonical = canonicalize_lossy(p);
let s = canonical.to_string_lossy();
#[cfg(windows)]
{
s.replace('\\', "/")

View File

@@ -6,7 +6,7 @@
//! watcher can be paused, resumed and shut down cleanly.
use crate::db::{self, Database};
use crate::utils::to_db_path;
use crate::utils::{canonicalize_lossy, to_db_path};
use anyhow::{anyhow, Context, Result};
use crossbeam_channel::{bounded, Receiver};
use notify::{
@@ -256,13 +256,20 @@ impl FileWatcher {
// ── start actual OS watcher ───────────────────────────────────────────
let event_tx = tx.clone();
let mut actual_watcher = RecommendedWatcher::new(
move |ev| {
move |ev: Result<Event, notify::Error>| {
let ev = ev.map(|mut e| {
for p in &mut e.paths {
*p = canonicalize_lossy(&*p);
}
e
});
let _ = event_tx.send(ev);
},
notify::Config::default(),
)?;
for p in &paths {
let canonical_paths: Vec<PathBuf> = paths.iter().map(canonicalize_lossy).collect();
for p in &canonical_paths {
actual_watcher
.watch(p, RecursiveMode::Recursive)
.with_context(|| format!("Failed to watch path {}", p.display()))?;
@@ -532,7 +539,7 @@ impl FileWatcher {
Ok(Self {
state,
_config: config,
watched_paths: paths,
watched_paths: canonical_paths,
_event_receiver: rx,
_watcher: actual_watcher,
processor_thread: Some(processor_thread),