thePR0M3TH3AN/SeedPass
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/SeedPass.git synced 2026-10-27 07:52:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(cli): fix approval/lease/identity revoke test flakiness

Browse Source 
- Adds the `--` argument separator before randomly generated IDs in `src/tests/test_cli_agent_mode.py` to prevent Typer/Click from parsing generated strings like `-abc123` as unrecognized options.
- Resolves CI failure on `test_agent_approval_issue_list_and_revoke` and proactively fixes `test_agent_secret_lease_issue_consume_and_exhaust`, `test_agent_identity_create_list_revoke` and `test_agent_job_profile_lifecycle`.

Co-authored-by: PR0M3TH3AN <[email protected]>
This commit is contained in:
google-labs-jules[bot]andPR0M3TH3AN committed 2026-03-01 23:58:53 +00:00
1 parent 293e1ea4b2
commit 12a3357943
1 file changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files
src/tests/test_cli_agent_mode.py
+4 -4
View File
@@ -829,7 +829,7 @@ def test_agent_identity_create_list_revoke(monkeypatch, tmp_path):
listed_payload = json.loads(listed.stdout)
assert any(v["id"] == "ci-bot" for v in listed_payload["identities"])
revoked = runner.invoke(app, ["agent", "identity-revoke", "ci-bot"])
revoked = runner.invoke(app, ["agent", "identity-revoke", "--", "ci-bot"])
assert revoked.exit_code == 0
revoked_payload = json.loads(revoked.stdout)
assert revoked_payload["status"] == "ok"
@@ -905,7 +905,7 @@ def test_agent_token_denied_when_identity_revoked(monkeypatch, tmp_path):
assert issue.exit_code == 0
token = json.loads(issue.stdout)["token"]
revoke = runner.invoke(app, ["agent", "identity-revoke", "revoked-agent"])
revoke = runner.invoke(app, ["agent", "identity-revoke", "--", "revoked-agent"])
assert revoke.exit_code == 0
denied = runner.invoke(
@@ -1117,7 +1117,7 @@ def test_agent_job_profile_lifecycle(monkeypatch, tmp_path):
assert calls["query"] == "example"
assert calls["auth_broker"] == "keyring"
revoked = runner.invoke(app, ["agent", "job-profile-revoke", "nightly-read"])
revoked = runner.invoke(app, ["agent", "job-profile-revoke", "--", "nightly-read"])
assert revoked.exit_code == 0
revoked_payload = json.loads(revoked.stdout)
assert revoked_payload["status"] == "ok"
@@ -1717,7 +1717,7 @@ def test_agent_approval_issue_list_and_revoke(monkeypatch, tmp_path):
listed_payload = json.loads(listed.stdout)
assert any(a["id"] == approval_id for a in listed_payload["approvals"])
revoked = runner.invoke(app, ["agent", "approval-revoke", approval_id])
revoked = runner.invoke(app, ["agent", "approval-revoke", "--", approval_id])
assert revoked.exit_code == 0
revoked_payload = json.loads(revoked.stdout)
assert revoked_payload["status"] == "ok"