fix(tests): skip pty/termios tests on non-unix systems

Added pytest.importorskip calls for 'pty' and 'termios' modules in
test_ai_tui_agent_harness.py to fix test failures on Windows where
these modules are unavailable.

Co-authored-by: PR0M3TH3AN <[email protected]>

src/tests/test_ai_tui_agent_harness.py

@@ -6,6 +6,9 @@ import sys
 
 import pytest
 
+pytest.importorskip("pty")
+pytest.importorskip("termios")
+
 
 def _load_harness_module():
     repo_root = Path(__file__).resolve().parents[2]

torch/scripts/test-audit/run_python_flaky_check.py

@@ -11,6 +11,7 @@ TEST_PATTERN = "src/tests"
 RESULTS = {}
 RUN_DIAGNOSTICS = []
 
+
 def run_tests(run_index):
     """Run pytest and parse output for pass/fail counts."""
     print(f"Run {run_index + 1}/{RUNS}...")
@@ -19,11 +20,13 @@ def run_tests(run_index):
     # -q: quiet
     # --no-header --no-summary: minimal output
     cmd = [
-        sys.executable, "-m", "pytest",
+        sys.executable,
+        "-m",
+        "pytest",
         TEST_PATTERN,
         "-q",
         "--no-header",
-        "--no-summary"
+        "--no-summary",
     ]
 
     start_time = time.time()
@@ -33,7 +36,7 @@ def run_tests(run_index):
             cmd,
             capture_output=True,
             text=True,
-            env={"PYTHONPATH": "src"}  # Ensure src is in path
+            env={"PYTHONPATH": "src"},  # Ensure src is in path
         )
         output = result.stdout
         exit_code = result.returncode
@@ -45,10 +48,10 @@ def run_tests(run_index):
 
     # Parse output character by character for status
     # . = pass, F = fail, E = error, s = skip, x = xfail, X = xpass
-    passed = output.count('.')
-    failed = output.count('F')
-    errors = output.count('E')
-    skipped = output.count('s')
+    passed = output.count(".")
+    failed = output.count("F")
+    errors = output.count("E")
+    skipped = output.count("s")
 
     # Store aggregate results (naive mapping, ideally we'd parse node ids)
     # Since we can't easily map node IDs without -v or --junitxml, we track totals for flakiness *rates* at suite level first.
@@ -56,26 +59,36 @@ def run_tests(run_index):
 
     junit_path = OUTPUT_DIR / f"flaky-run-{run_index + 1}.xml"
     subprocess.run(
-        [sys.executable, "-m", "pytest", TEST_PATTERN, f"--junitxml={junit_path}", "-q"],
-        capture_output=True, # We only care about the XML file
-        env={"PYTHONPATH": "src"}
+        [
+            sys.executable,
+            "-m",
+            "pytest",
+            TEST_PATTERN,
+            f"--junitxml={junit_path}",
+            "-q",
+        ],
+        capture_output=True,  # We only care about the XML file
+        env={"PYTHONPATH": "src"},
+    )
+
+    RUN_DIAGNOSTICS.append(
+        {
+            "run": run_index + 1,
+            "code": exit_code,
+            "duration": duration,
+            "passed": passed,
+            "failed": failed,
+            "errors": errors,
+            "skipped": skipped,
+        }
     )
 
-    RUN_DIAGNOSTICS.append({
-        "run": run_index + 1,
-        "code": exit_code,
-        "duration": duration,
-        "passed": passed,
-        "failed": failed,
-        "errors": errors,
-        "skipped": skipped
-    })
 
 def parse_junit_xmls():
     """Parse generated JUnit XML files to detect per-test flakiness."""
     import xml.etree.ElementTree as ET
 
-    test_stats = {} # "test_id": {pass: 0, fail: 0, error: 0, skip: 0}
+    test_stats = {}  # "test_id": {pass: 0, fail: 0, error: 0, skip: 0}
 
     for i in range(RUNS):
         xml_path = OUTPUT_DIR / f"flaky-run-{i + 1}.xml"
@@ -108,6 +121,7 @@ def parse_junit_xmls():
 
     return test_stats
 
+
 def main():
     OUTPUT_DIR.mkdir(parents=True, exist_ok=True)
 
@@ -129,5 +143,6 @@ def main():
 
     print(f"Flakiness matrix written to {OUTPUT_DIR / 'flakiness-matrix.json'}")
 
+
 if __name__ == "__main__":
     main()

torch/scripts/test-audit/run_python_static_analysis.py

@@ -20,29 +20,33 @@ PATTERNS = [
     (r"# todo", "Found '# todo' comment"),
 ]
 
+
 def scan_file(filepath):
     """Scan a single file for suspicious patterns."""
     issues = []
     try:
         content = filepath.read_text(encoding="utf-8")
     except Exception:
-        return # Skip non-text files
+        return  # Skip non-text files
 
     for pattern, message in PATTERNS:
         if re.search(pattern, content):
             issues.append(message)
 
     # Check for lack of assertions (very naive)
-    if "test_" in filepath.name and "assert" not in content and "expect" not in content and "raise" not in content:
+    if (
+        "test_" in filepath.name
+        and "assert" not in content
+        and "expect" not in content
+        and "raise" not in content
+    ):
         # Exclude conftest or helpers
         if "conftest" not in filepath.name and "helper" not in filepath.name:
-             issues.append("No obvious assertions found")
+            issues.append("No obvious assertions found")
 
     if issues:
-        SUSPICIOUS.append({
-            "file": str(filepath),
-            "issues": issues
-        })
+        SUSPICIOUS.append({"file": str(filepath), "issues": issues})
+
 
 def main():
     OUTPUT_DIR.mkdir(parents=True, exist_ok=True)
@@ -62,5 +66,6 @@ def main():
     print(f"Found {len(SUSPICIOUS)} suspicious files.")
     print(f"Report written to {OUTPUT_DIR / 'suspicious-tests.json'}.")
 
+
 if __name__ == "__main__":
     main()