TASK-console-attention-actions: keep cohort evidence enumerable

This commit is contained in:
thePR0M3TH3AN committed 2026-10-01 12:00:44 -04:00
1 parent da9f85fc18
commit 4fa9bd7d49
4 files changed
+23 -9

No files matched your search

+2
View File
@@ -2744,8 +2744,10 @@ test_integrity_note:
then: "The task reference remains visible while missing owner and provenance remain null and reproduction is labelled UNKNOWN"
observable_outcomes:
- "One 49-reference advisory cohort replaces duplicated stale/missing attention cards while preserving exact drilldown references"
- "A populated advisory group remains enumerable and JSON-serializable; an empty projection preserves its original owner/fleet/arbiter object shape"
- "Each deduplicated observation retains doctor and backlogHealth provenance; conflicting records are never merged by code alone"
- "Owner decisions, unsafe recovery, schema errors, unknown wakes, delivery operations, and same-code errors remain in their existing action groups"
- "Observed source/revision displays the exact observedAt SHA without presenting it as a clock timestamp"
- "Projection does not mutate snapshot data or invoke state-changing actions, and existing owner quick-action preview/revision/draft assertions remain unchanged"
- "Source/scenario qualification is not actual live desktop/mobile visual acceptance"
determinism_controls:
+1 -1
View File
@@ -18,7 +18,6 @@ function attentionGroups(snapshot) {
const approvals = (snapshot.approvalRequests?.items ?? []).filter((approval) => approval.status === 'pending');
const advisory = [];
Object.defineProperty(groups, 'advisory', { value: advisory });
const recheckCodes = new Set(['BACKLOG_OBSERVED_COMMIT_STALE', 'BACKLOG_OBSERVED_COMMIT_MISSING']);
const rechecks = new Map();
const recheckValue = (finding, key, fallback) => Object.hasOwn(finding, key) && finding[key] !== undefined
@@ -188,6 +187,7 @@ function attentionGroups(snapshot) {
href: '#backlog-board', action: 'Inspect backlog evidence',
observations, taskReferences,
});
groups.advisory = advisory;
}
return groups;
}
+2 -2
View File
@@ -968,7 +968,7 @@ function renderAttention(groups) {
const total = attentionItemCount(groups);
setText('#attention-count', `${total} ${total === 1 ? 'item' : 'items'}`);
setHtml('#attention-list', definitions.map(([key, title, description]) => {
const items = groups[key];
const items = groups[key] ?? [];
return `<section class="attention-group attention-group-${key}" aria-labelledby="attention-${key}-title">
<div class="attention-group-heading"><h3 id="attention-${key}-title">${title}</h3><span>${items.length}</span></div>
${items.length ? items.map((item) => `<article class="attention-item tone-${escapeHtml(item.tone)}">
@@ -981,7 +981,7 @@ function renderAttention(groups) {
${item.observations ? `<details class="attention-cohort-details"><summary>Recheck observations (${item.observations.length})</summary><ul>${item.observations.map((observation) => `<li>
<code>${escapeHtml(observation.taskId ?? 'Task reference not recorded')}</code> · ${escapeHtml(observation.code)}
· Owner: ${escapeHtml(observation.owner ?? 'Owner not recorded')}
· Observed at: ${escapeHtml(observation.observedAt ?? 'Not recorded')}
· Observed source/revision: ${escapeHtml(observation.observedAt ?? 'Not recorded')}
· Current observed commit: ${escapeHtml(observation.currentObservedCommit ?? 'Not recorded')}
· Reproduction: ${escapeHtml(observation.reproductionStatus ?? 'UNKNOWN')}
· Sources: ${escapeHtml(observation.sources.join(', ') || 'Not recorded')}
+18 -6
View File
@@ -25,7 +25,7 @@ function finding(task, source = {}) {
function cohortFixture(count = 49) {
const tasks = Array.from({ length: count }, (_, index) => ({
id: taskId(index + 1), owner: `domain-${String(index + 1).padStart(2, '0')}`,
observedAt: `2026-09-${String((index % 28) + 1).padStart(2, '0')}T12:00:00.000Z`,
observedAt: String(index + 1).padStart(40, '0'),
}));
const findings = tasks.map((task, index) => finding(task, {
code: index % 2 ? 'BACKLOG_OBSERVED_COMMIT_MISSING' : 'BACKLOG_OBSERVED_COMMIT_STALE',
@@ -47,6 +47,13 @@ test('SCN-attention-advisory-cohort-cardinality-and-exact-references: 49 equival
assert.equal(groups.fleet.filter((item) => /BACKLOG_OBSERVED_COMMIT_(STALE|MISSING)/.test(item.title)).length, 0);
assert.deepEqual(groups.advisory[0].taskReferences, expectedReferences);
assert.equal(groups.advisory[0].observations.length, 49);
assert.ok(Object.keys(groups).includes('advisory'));
assert.equal(Object.values(groups).reduce((count, group) => count + group.length, 0), 1,
'the enumerable cohort participates in the existing group-count boundary');
const serialized = JSON.parse(JSON.stringify(groups));
assert.equal(serialized.advisory.length, 1);
assert.deepEqual(serialized.advisory[0].taskReferences, expectedReferences);
assert.equal(serialized.advisory[0].observations.length, 49);
const fixture = cohortFixture();
for (const observation of groups.advisory[0].observations) {
const task = fixture.backlog.find((entry) => entry.id === observation.taskId);
@@ -90,6 +97,7 @@ test('SCN-attention-advisory-cohort-cardinality-and-exact-references: 49 equival
assert.equal(await advisory.locator('.attention-item').count(), 1);
assert.equal(await advisory.locator('.attention-cohort-details li').count(), 49);
assert.deepEqual(await advisory.locator('.attention-cohort-details li code').allTextContents(), expectedReferences);
assert.match(await advisory.locator('.attention-cohort-details li').first().textContent(), /Observed source\/revision: 0{39}1/);
assert.equal(await page.locator('#attention-list .attention-group-fleet .attention-item').filter({
hasText: /BACKLOG_OBSERVED_COMMIT_(STALE|MISSING)|task evidence record.*need refresh/,
}).count(), 0);
@@ -105,7 +113,7 @@ test('SCN-attention-advisory-provenance-and-semantic-conflicts: equal sources me
{ field: 'taskId', firstId: 'TASK-ID-A', secondId: 'TASK-ID-B' },
{ field: 'code', change: { code: 'BACKLOG_OBSERVED_COMMIT_MISSING' } },
{ field: 'owner', change: { owner: 'domain-conflict' } },
{ field: 'observedAt', change: { observedAt: '2026-10-01T12:01:00.000Z' } },
{ field: 'observedAt', change: { observedAt: '1'.repeat(40) } },
{ field: 'currentObservedCommit', change: { currentObservedCommit: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' } },
{ field: 'reproductionStatus', change: { reproductionStatus: 'REPRODUCED' } },
];
@@ -114,7 +122,7 @@ test('SCN-attention-advisory-provenance-and-semantic-conflicts: equal sources me
const tasks = [];
for (const [index, conflict] of conflictCases.entries()) {
const id = `TASK-CONFLICT-${conflict.field}`;
const firstTask = { id: conflict.firstId ?? id, owner: 'domain-a', observedAt: `2026-10-01T12:0${index}:00.000Z` };
const firstTask = { id: conflict.firstId ?? id, owner: 'domain-a', observedAt: String(index + 1).padStart(40, '0') };
const secondTask = conflict.secondId
? { ...firstTask, id: conflict.secondId }
: firstTask;
@@ -139,7 +147,7 @@ test('SCN-attention-advisory-provenance-and-semantic-conflicts: equal sources me
assert.ok(['doctor', 'backlogHealth'].includes(observation.sources[0]));
}
const equalTask = { id: 'TASK-EQUAL', owner: 'domain-equal', observedAt: '2026-10-01T13:00:00.000Z' };
const equalTask = { id: 'TASK-EQUAL', owner: 'domain-equal', observedAt: 'b'.repeat(40) };
const equalGroups = project({ repository: { head: '316d8b7480c2e10925ebdff8310fe26ef5a881a8' }, backlog: [equalTask],
doctor: { findings: [finding(equalTask)] }, backlogHealth: { findings: [finding(equalTask)] } });
assert.equal(equalGroups.advisory[0].observations.length, 1);
@@ -158,7 +166,7 @@ test('SCN-attention-advisory-does-not-hide-owner-or-fleet-risks: unsafe and unkn
{ severity: 'error', code: 'BACKLOG_HEALTH_INVALID', message: 'Backlog schema validation failed.' },
{ severity: 'warning', code: 'RECOVERABILITY', offMachine: false, recommendation: 'Verify the recovery copy.' },
] },
backlog: [{ id: 'TASK-ADVISORY', owner: 'provider-runtime', observedAt: '2026-10-01T10:00:00.000Z' }],
backlog: [{ id: 'TASK-ADVISORY', owner: 'provider-runtime', observedAt: 'f'.repeat(40) }],
managerWakes: { blockingCount: 1, reservations: [{ managerId: 'provider-runtime', scheduleId: 'wake-a', outcome: 'unknown', blocksManagerWake: true }] },
deliveryOperations: [{ operation: 'publish', state: 'unknown', actor: 'provider-runtime', commit: '316d8b7480c2e10925ebdff8310fe26ef5a881a8' }],
});
@@ -178,7 +186,7 @@ test('SCN-attention-advisory-does-not-hide-owner-or-fleet-risks: unsafe and unkn
test('SCN-attention-advisory-projection-is-read-only: projection preserves snapshot and existing owner decision shape', () => {
const snapshot = {
repository: { head: '316d8b7480c2e10925ebdff8310fe26ef5a881a8' },
backlog: [{ id: 'TASK-READONLY', owner: 'provider-runtime', observedAt: '2026-10-01T12:00:00.000Z' }],
backlog: [{ id: 'TASK-READONLY', owner: 'provider-runtime', observedAt: '0'.repeat(40) }],
doctor: { findings: [{ severity: 'warning', code: 'BACKLOG_OBSERVED_COMMIT_STALE', taskId: 'TASK-READONLY' }] },
backlogHealth: { findings: [{ severity: 'warning', code: 'BACKLOG_OBSERVED_COMMIT_STALE', taskId: 'TASK-READONLY' }] },
approvalRequests: { items: [{ id: 'owner-confirm', revision: 7, status: 'pending', approver: 'owner', requester: 'provider-runtime',
@@ -224,4 +232,8 @@ test('SCN-attention-advisory-unknown-fields-stay-unknown: absent owner and obser
assert.equal(observation.currentObservedCommit, null);
assert.equal(observation.reproductionStatus, 'UNKNOWN');
assert.deepEqual(observation.sources, ['doctor']);
assert.equal(Object.hasOwn(groups, 'advisory'), true);
const emptyGroups = project({ doctor: { findings: [] }, backlogHealth: { findings: [] } });
assert.deepEqual(emptyGroups, { owner: [], fleet: [], arbiter: [] });
assert.equal(Object.hasOwn(emptyGroups, 'advisory'), false);
});