Refactor: Unify string list parsing in torch-config

- Introduced `parseStringList` helper to handle parsing of string arrays from config.
- Replaced `parseRelayList` and `parseRoster` with `parseStringList`.
- Replaced inline parsing of `relays` and `dashboard.relays` with `parseStringList`.
- Unified behavior: empty lists in config now consistently return `null` instead of `[]`.
- Added unit test verifying consistent `null` return for empty lists.

Co-authored-by: PR0M3TH3AN <[email protected]>

src/torch-config.mjs

@@ -21,9 +21,9 @@ function parsePositiveInteger(value) {
   return Math.floor(value);
 }
 
-function parseRelayList(value) {
+function parseStringList(value) {
   if (!Array.isArray(value)) return null;
-  const parsed = value.map((relay) => String(relay).trim()).filter(Boolean);
+  const parsed = value.map((item) => String(item).trim()).filter(Boolean);
   return parsed.length > 0 ? parsed : null;
 }
 
@@ -63,11 +63,6 @@ function normalizeStatus(value, fallback) {
   return normalized === 'active' || normalized === 'all' ? normalized : fallback;
 }
 
-function parseRoster(value) {
-  if (!Array.isArray(value)) return null;
-  const parsed = value.map((item) => String(item).trim()).filter(Boolean);
-  return parsed.length > 0 ? parsed : null;
-}
 
 export function getTorchConfigPath() {
   const explicitPath = (process.env.TORCH_CONFIG_PATH || '').trim();
@@ -94,10 +89,8 @@ export function parseTorchConfig(raw, configPath = null) {
     raw,
     nostrLock: {
       namespace: typeof nostrLock.namespace === 'string' ? nostrLock.namespace.trim() : null,
-      relays: Array.isArray(nostrLock.relays)
-        ? nostrLock.relays.map((relay) => String(relay).trim()).filter(Boolean)
-        : null,
-      relayFallbacks: parseRelayList(nostrLock.relayFallbacks),
+      relays: parseStringList(nostrLock.relays),
+      relayFallbacks: parseStringList(nostrLock.relayFallbacks),
       ttlSeconds: Number.isFinite(nostrLock.ttlSeconds) && nostrLock.ttlSeconds > 0
         ? Math.floor(nostrLock.ttlSeconds)
         : null,
@@ -105,15 +98,13 @@ export function parseTorchConfig(raw, configPath = null) {
       publishTimeoutMs: parsePositiveInteger(nostrLock.publishTimeoutMs),
       minSuccessfulRelayPublishes: parsePositiveInteger(nostrLock.minSuccessfulRelayPublishes),
       minActiveRelayPool: parsePositiveInteger(nostrLock.minActiveRelayPool),
-      dailyRoster: parseRoster(nostrLock.dailyRoster),
-      weeklyRoster: parseRoster(nostrLock.weeklyRoster),
+      dailyRoster: parseStringList(nostrLock.dailyRoster),
+      weeklyRoster: parseStringList(nostrLock.weeklyRoster),
     },
     dashboard: {
       defaultCadenceView: normalizeCadence(dashboard.defaultCadenceView, 'daily'),
       defaultStatusView: normalizeStatus(dashboard.defaultStatusView, 'active'),
-      relays: Array.isArray(dashboard.relays)
-        ? dashboard.relays.map((relay) => String(relay).trim()).filter(Boolean)
-        : null,
+      relays: parseStringList(dashboard.relays),
       namespace: typeof dashboard.namespace === 'string' ? dashboard.namespace.trim() : null,
       hashtag: typeof dashboard.hashtag === 'string' ? dashboard.hashtag.trim() : null,
       auth: typeof dashboard.auth === 'string' ? dashboard.auth.trim() : null,
@@ -124,8 +115,8 @@ export function parseTorchConfig(raw, configPath = null) {
         weekly: typeof firstPromptByCadence.weekly === 'string' ? firstPromptByCadence.weekly.trim() : null,
       },
       paused: {
-        daily: parseRoster(paused.daily) || [],
-        weekly: parseRoster(paused.weekly) || [],
+        daily: parseStringList(paused.daily) || [],
+        weekly: parseStringList(paused.weekly) || [],
       },
     },
   };

test/torch-config-unit.test.mjs

@@ -68,4 +68,26 @@ describe('loadTorchConfig (Unit Tests with Mocked FS)', () => {
     assert.strictEqual(mockFs.existsSync.mock.calls.length, 1);
     assert.strictEqual(mockFs2.existsSync.mock.calls.length, 0);
   });
+
+  it('returns null for empty string lists (new consistent behavior)', () => {
+    const mockFs = {
+      existsSync: mock.fn(() => true),
+      readFileSync: mock.fn(() => JSON.stringify({
+        nostrLock: {
+          relays: [],
+          relayFallbacks: []
+        },
+        dashboard: {
+          relays: []
+        }
+      }))
+    };
+
+    const config = loadTorchConfig(mockFs);
+
+    // New behavior: all return null
+    assert.strictEqual(config.nostrLock.relays, null);
+    assert.strictEqual(config.dashboard.relays, null);
+    assert.strictEqual(config.nostrLock.relayFallbacks, null);
+  });
 });